clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I335e0c726360eaae85b9b54c16b5dcbe4a3f182e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ief40c08041429a57684a6debd84eecea2a298dff
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

types: Migrate to stdplus ip

Change-Id: I777aa701204b0c4dbe5f0088cc2e6a4deb4f5d15
Signed-off-by: William A. Kennington III <wak@google.com>

rtnetlink_server: Ignore errors on ignored interfaces

An example is MCTP device addresses that cannot be parsed by
phosphor-networkd. We don't need to parse them if they are ignored, so
we can just

rtnetlink_server: Ignore errors on ignored interfaces

An example is MCTP device addresses that cannot be parsed by
phosphor-networkd. We don't need to parse them if they are ignored, so
we can just ignored the errors.

Tested: Verified that MCTP devices no longer cause error messages to
print to the journal.

Change-Id: I60b0a24f1e9a2e1866ac902833eb94c034ddfce0
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

logging: switch phosphor-network-manager exe to lg2

Tested: Build passes with "ninja -C build".
Change-Id: Ib02682393aba65b16f55eece58ecf50321190a56
Signed-off-by: Jagpal Singh Gill <paligill@gmail.

logging: switch phosphor-network-manager exe to lg2

Tested: Build passes with "ninja -C build".
Change-Id: Ib02682393aba65b16f55eece58ecf50321190a56
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

treewide: Completely remove global refresh

We no longer need any of the global refresh code as we can dynamically
receive all of the updates to network configuration.

Change-Id: Ia8cb3af827c599c17d

treewide: Completely remove global refresh

We no longer need any of the global refresh code as we can dynamically
receive all of the updates to network configuration.

Change-Id: Ia8cb3af827c599c17d5df9fdddaf6cdc6546050d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

rtnetlink_server: Dump all netlink data at startup

We want to be able to build the configuration tree without performing an
initial object refresh.

Change-Id: I640ba802bb3ba2a8c0e6e5d4069ba4298f604

rtnetlink_server: Dump all netlink data at startup

We want to be able to build the configuration tree without performing an
initial object refresh.

Change-Id: I640ba802bb3ba2a8c0e6e5d4069ba4298f604b4d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

rtnetlink_server: Add interfaces dynamically

We don't need to refresh all of the interfaces anymore and can handle
just those that come and go.

Change-Id: Id6b3852f52065ff4a1ef412528261c826eae7e63

rtnetlink_server: Add interfaces dynamically

We don't need to refresh all of the interfaces anymore and can handle
just those that come and go.

Change-Id: Id6b3852f52065ff4a1ef412528261c826eae7e63
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

network_manager: Absorb all state change functions

We are going to need to keep track of more state for when interfaces are
not yet set up. It also makes testing easier if we can keep the
rtnetlink

network_manager: Absorb all state change functions

We are going to need to keep track of more state for when interfaces are
not yet set up. It also makes testing easier if we can keep the
rtnetlink_server as simple as possible.

Change-Id: Iad94bf609feeb96a78f1c4ec3313c4f638eda951
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

rtnetlink: Return neighbor even if addr is missing

There are valid configurations that return these type of messages from
the kernel and we don't want to fail for them

Change-Id: I74a0fd519e553c2e4

rtnetlink: Return neighbor even if addr is missing

There are valid configurations that return these type of messages from
the kernel and we don't want to fail for them

Change-Id: I74a0fd519e553c2e4bc3e114e7563fe93d8facf6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

rtnetlink: Handle parsing errors more gracefully

Change-Id: Ia0699263dc8f3f356e6d265fade4c13801fe730a
Signed-off-by: William A. Kennington III <wak@google.com>

rtnetlink_server: Don't refresh for neighbors

They can be dynamically added and removed now.

Change-Id: Ia09cf6378d54b31e4957fb8e6f09d2e110dd53ae
Signed-off-by: William A. Kennington III <wak@googl

rtnetlink_server: Don't refresh for neighbors

They can be dynamically added and removed now.

Change-Id: Ia09cf6378d54b31e4957fb8e6f09d2e110dd53ae
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

rtnetlink_server: Don't refresh for addresses

We can dynamically add and remove addresses without having to recreate
all of the objects.

Change-Id: Ic510263cc6ba5d2ec228ce94fa83cf5fe4664c6d
Signed-

rtnetlink_server: Don't refresh for addresses

We can dynamically add and remove addresses without having to recreate
all of the objects.

Change-Id: Ic510263cc6ba5d2ec228ce94fa83cf5fe4664c6d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

rtnetlink_server: Avoid refreshing for gateway changes

Instead of refreshing all of the objects, we can just update the
ethernet object that has the gateway route.

Change-Id: Ib1922273b625b1400625c

rtnetlink_server: Avoid refreshing for gateway changes

Instead of refreshing all of the objects, we can just update the
ethernet object that has the gateway route.

Change-Id: Ib1922273b625b1400625c6a851330e3642a8c647
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

rtnetlink_server: Also monitor links

Change-Id: Id172ae0390d23066940edba0c75e6a866ea71132
Signed-off-by: William A. Kennington III <wak@google.com>

rtnetlink: Remove unnecessary copy

Change-Id: I14268a99b8587c6b46a36023d7f31e132345f6db
Signed-off-by: William A. Kennington III <wak@google.com>

rtnetlink_server: Fix edge triggering

We need to receive messages until there are no more pending or else we
will leave messages in the file descriptor.

Change-Id: I3f4a5a7e57ccca62be76591d47c8317d

rtnetlink_server: Fix edge triggering

We need to receive messages until there are no more pending or else we
will leave messages in the file descriptor.

Change-Id: I3f4a5a7e57ccca62be76591d47c8317d995e527e
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

rtnetlink_server: Use netlink parser code

Change-Id: I97a8fd1c692973a8ac97171dfaf309cfc9cfceb1
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Move all sd-event to sdeventplus

Change-Id: I157d8b5cf4db96b75602efae55870950994dcc17
Signed-off-by: William A. Kennington III <wak@google.com>

rtnetlink: Switch to stdplus::Fd

Simplifies the code a little bit and will allow us to remove the
Descriptor.

Change-Id: If78ea4478fed9f818bcf1d00ef1c952cb5c7df00
Signed-off-by: William A. Kenningt

rtnetlink: Switch to stdplus::Fd

Simplifies the code a little bit and will allow us to remove the
Descriptor.

Change-Id: If78ea4478fed9f818bcf1d00ef1c952cb5c7df00
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Fix for Network Manager Crash

RTNet Link Packet is received with a buffer size of 4096 bytes, the
pointer to the buffer is not moved back to the start address of buffer
when the pointer to the buffe

Fix for Network Manager Crash

RTNet Link Packet is received with a buffer size of 4096 bytes, the
pointer to the buffer is not moved back to the start address of buffer
when the pointer to the buffer is used to receive the next packet in
queue causing the pointer access of array out of bound. The fix for this
in this patch re-initializes the pointer to start address of buffer
before the next packet is received. No other checking is required to
validate the case of array out of bound as the NLMSG preprocessor
macros is taking care of checking the received and remaining length of
data in the packet and send for processing.

Tested:
Flashed the BMC image on available platforms in which the crash was
reported and regression of sending the Net Link Packet continuously.
No core file/crash was observed during the time of regression and
reboot cycle tests.

Signed-off-by: sureshvijayv1 <suresh.vijayakumar@intel.com>
Change-Id: Ibcfbb03dcce694d4116163be3db25f0597cda1eb

show more ...

build: Split c++ sources into a subdirectory

Change-Id: Iedea50c688189ae4953195105e323f7173d17a4b
Signed-off-by: William A. Kennington III <wak@google.com>