Update the error on deleting a link local address

It is in reference to https://github.com/openbmc/openbmc/issues/2342

Currently, when a user tries to delete a non-static ip address,
it throws an e

Update the error on deleting a link local address

It is in reference to https://github.com/openbmc/openbmc/issues/2342

Currently, when a user tries to delete a non-static ip address,
it throws an error as "the operation failed internally"

With the update, when an attempt is made to delete the link-local
address of the bmc it throws "The operation is not allowed" error

Tested by:

Current behaviour:

busctl call xyz.openbmc_project.Network
/xyz/openbmc_project/network/eth1/_66e80_3a_3aa94...
xyz.openbmc_project.Object.Delete Delete

response: Call failed: The operation failed internally.

Modified behaviour:

busctl call xyz.openbmc_project.Network
/xyz/openbmc_project/network/eth1/_66e80_3a_3aa94...
xyz.openbmc_project.Object.Delete Delete

response: Call failed: The operation is not allowed

Change-Id: Ib5df33b8ad356a868aecc508ad6531ed15390a1d
Signed-off-by: Jishnu CM <jishnunambiarcm@duck.com>

show more ...

types: Migrate to stdplus ip

Change-Id: I777aa701204b0c4dbe5f0088cc2e6a4deb4f5d15
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Make logging variables more consistent

This aims to better group related variables and differentiate keywords
like INTERFACE_NAME into NET vs DBUS.

Tested: Ran on a machine to verify that

treewide: Make logging variables more consistent

This aims to better group related variables and differentiate keywords
like INTERFACE_NAME into NET vs DBUS.

Tested: Ran on a machine to verify that our info log messages still look
sane in the journal.

Change-Id: Ic4d1faaaf5c432e69cacd387fa972481916b6bc8
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia4966a0790437eb0fc011c747f3be2a52884e4d8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

logging: switch networkd static_library to lg2

This commit switches logging to lg2 in the following files -
1. src/dhcp_configuration.cpp
2. src/dhcp_configuration.cpp
3. src/ipaddress.cpp
4. src/sy

logging: switch networkd static_library to lg2

This commit switches logging to lg2 in the following files -
1. src/dhcp_configuration.cpp
2. src/dhcp_configuration.cpp
3. src/ipaddress.cpp
4. src/system_configuration.cpp
5. src/system_queries.cpp

Tested: Build passes with "ninja -C build".

Change-Id: I492c7579c968810b783836b652e450ff89b8cd4b
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

treewide: Codify memory pinning

This enforces movability constraints.

Change-Id: I49dbd43a791c1d70eb7e97f30708231c053901d9
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Cleanup signal emission

Don't emit properties changed prior to interfaces added.

Change-Id: I7f88b8052a323ca49ce9f16fe446596213e3fdb5
Signed-off-by: William A. Kennington III <wak@google.

treewide: Cleanup signal emission

Don't emit properties changed prior to interfaces added.

Change-Id: I7f88b8052a323ca49ce9f16fe446596213e3fdb5
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

treewide: Completely remove global refresh

We no longer need any of the global refresh code as we can dynamically
receive all of the updates to network configuration.

Change-Id: Ia8cb3af827c599c17d

treewide: Completely remove global refresh

We no longer need any of the global refresh code as we can dynamically
receive all of the updates to network configuration.

Change-Id: Ia8cb3af827c599c17d5df9fdddaf6cdc6546050d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

rtnetlink_server: Don't refresh for addresses

We can dynamically add and remove addresses without having to recreate
all of the objects.

Change-Id: Ic510263cc6ba5d2ec228ce94fa83cf5fe4664c6d
Signed-

rtnetlink_server: Don't refresh for addresses

We can dynamically add and remove addresses without having to recreate
all of the objects.

Change-Id: Ic510263cc6ba5d2ec228ce94fa83cf5fe4664c6d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

rtnetlink: Migrate IP functions

Change-Id: I4c87b59306911df4c5a73e441b2b962fbaab072c
Signed-off-by: William A. Kennington III <wak@google.com>

ipaddress: Refactor object creation

Change-Id: Icae934e3dc88d596812b75a31598636ae7b95823
Signed-off-by: William A. Kennington III <wak@google.com>

netlink: Add common function for extracting payload

Change-Id: I809bd17d50ccb8a8f624b6117c088193f55e79de
Signed-off-by: William A. Kennington III <wak@google.com>

ipaddress: Remove obsolete gateway parameter

Change-Id: I0eb7c84951c2277a5c69fb35eb989e7e19bd897d
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Cleanup unused includes

Change-Id: Ied2a0d97d2c31dc2b370452768a7f41d9ecf07f3
Signed-off-by: William A. Kennington III <wak@google.com>

Revert "ipaddress: Remove set property overrides"

This reverts commit a809f92e05bfbb07414a77cda64d5d75f3ad1bce.

This was overly optimistic and we need to keep the exception paths.

Change-Id: If17d

Revert "ipaddress: Remove set property overrides"

This reverts commit a809f92e05bfbb07414a77cda64d5d75f3ad1bce.

This was overly optimistic and we need to keep the exception paths.

Change-Id: If17d74a4af964eff6d2d14ca42402d8190f54484
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ipaddress: Remove set property overrides

This is now handled for us in the dbus interface.

Change-Id: I3cb78acf773f5327c3c51f87a5390c843f27c5cd
Signed-off-by: William A. Kennington III <wak@google.

ipaddress: Remove set property overrides

This is now handled for us in the dbus interface.

Change-Id: I3cb78acf773f5327c3c51f87a5390c843f27c5cd
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ipaddress: Parse from netlink

This improves on the old code for enumerating IP addresses by allowing
the application of filtering rules prior to listing out the IPs. The
netlink interface provides t

ipaddress: Parse from netlink

This improves on the old code for enumerating IP addresses by allowing
the application of filtering rules prior to listing out the IPs. The
netlink interface provides the information in a more direct form with
less superfluous enumeration of data about the address.

This will be required to determine deprecated / dynamic addresses from
static ones with IPv6.

Change-Id: I8ff2408b58921a82fd556d8ed08c203171c88035
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ief1b330c4f623ecc1be771f36083780a12260834

show more ...

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.

Change-Id: I2e7ce5e279d65d101e1249f2b41f126143d3f03d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

build: Split c++ sources into a subdirectory

Change-Id: Iedea50c688189ae4953195105e323f7173d17a4b
Signed-off-by: William A. Kennington III <wak@google.com>