Add network static gateway configuration support

This commit enables static gateway configuration on EthernetInterface
Implements CreateStaticGateway method which creates a new d-bus object
with Sta

Add network static gateway configuration support

This commit enables static gateway configuration on EthernetInterface
Implements CreateStaticGateway method which creates a new d-bus object
with StaticGateway interface.

Tested By:
Run StaticGateway D-bus method and verified D-bus object and
configuration.
Delete StaticGateway object
Add static gateway
Delete static gateway

Change-Id: I3fbc6f85ede00b6c1949a0ac85f501037a69c831
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

Replace originIsManuallyAssigned with inline test

The originIsManuallyAssigned function does not need to be present.

When automatic link local addresses are active, the conditional
compilation made

Replace originIsManuallyAssigned with inline test

The originIsManuallyAssigned function does not need to be present.

When automatic link local addresses are active, the conditional
compilation made sure to only test for addresses of 'static' origin.

When manual link local addresses are active, by definition the address
assignment is done using a IPSRC == static action. It is not possible
to use IPMI or Redfish to assert a "link local" flag. Thus all link
local addresses are merely statically assigned addresses. The
systemd-network stack asserts the link local scope based on the IP
address assigned.

Tested:
Enabled LINK_LOCAL_AUTOCONFIGURATION and used DHCP and static address
assignments.
When DHCPv4 is turned off, a link local address is assigned to the link.
With DHCPv4 turned on, the link local address is disabled.

Explicitly adding a static address inside the 169.254 address space
causes systemd to report the address scope to be link local.

Restoring DHCPv4 disables all link local addresses per IETF RFCs.

Manually disabled LINK_LOCAL_AUTOCONFIGURATION, as phosphor-network
does provide dynamic control.
Disabled DHCPv4 and confirmed there are no link local or DHCPv4
addresses.
Assigned a 169.254.x.x address w/o DHCPv4 or LinkLocalAddressing.
Confirmed a "scope link" address was reported via 'ip addr'.

Change-Id: I4d7e55dc3014b5b0acdd12bd8ac85ea650c13b9c
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I169e5e1674cfda3599ea585ca3fd7afcfed601c0
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

ethernet_interface: Simplify DHCPConfiguration enumeration

We don't have more than 2 types of DHCP objects, don't use an arbitrary
vector and depend on enum values for indices.

Change-Id: I5c519e8b

ethernet_interface: Simplify DHCPConfiguration enumeration

We don't have more than 2 types of DHCP objects, don't use an arbitrary
vector and depend on enum values for indices.

Change-Id: I5c519e8b95b273a4684e553f18027f038d025f17
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Configure DHCP4 and DHCP6 parameters independently

At present, DHCP parameters like DNSEnabled, NTPEnabled etc. are
shared between DHCPv4 and DHCPv6 in the network configuration.

Hence any update o

Configure DHCP4 and DHCP6 parameters independently

At present, DHCP parameters like DNSEnabled, NTPEnabled etc. are
shared between DHCPv4 and DHCPv6 in the network configuration.

Hence any update on the ipv4 parameters impacts the ipv6 and get
applied to both the interfaces.

This change is to enable the possibility to configure DHCP attributes
independently, by having different dbus objects for dhcp4 and dhcp6
and moving the dhcp configuration from network level to ethernet
interface.

tested by:

Used the busctl command to set and get the parameter values
individually for both DHCPv4 and DHCPv6.
Verified the network configuration file is updated accordingly

Tree Structure:
busctl tree xyz.openbmc_project.Network
`-/xyz
`-/xyz/openbmc_project
`-/xyz/openbmc_project/network
|-/xyz/openbmc_project/network/config
|-/xyz/openbmc_project/network/eth0
| |-/xyz/openbmc_project/network/eth0/dhcp4
| `-/xyz/openbmc_project/network/eth0/dhcp6
`-/xyz/openbmc_project/network/eth1
|-/xyz/openbmc_project/network/eth1/dhcp4
`-/xyz/openbmc_project/network/eth1/dhcp6

Change-Id: If7dbbf596bdaf866ea459d631e716153f54302ec
Signed-off-by: Jishnu CM <jishnunambiarcm@duck.com>

show more ...

DHCP: Populate nameservers D-bus property from resolv.conf

Currently when DHCP enabled, nameservers D-bus property does not have
updated DHCP provided nameservers.

This commit populates nameservers

DHCP: Populate nameservers D-bus property from resolv.conf

Currently when DHCP enabled, nameservers D-bus property does not have
updated DHCP provided nameservers.

This commit populates nameservers D-bus property from resolv.conf

Tested By: verify nameservers D-bus property value with DHCP
enable/disable

Change DHCP server nameservers configuration & verify name servers
D-bus property updated on the interface.

Change-Id: If1a2508927d5f4f0c9c5d8b3f533fdf384d68821
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

treewide: Add clang-tidy

Change-Id: I1aab00b0ff8c016650225fcd1c83678a91808941
Signed-off-by: William A. Kennington III <wak@google.com>

types: Migrate to stdplus ip

Change-Id: I777aa701204b0c4dbe5f0088cc2e6a4deb4f5d15
Signed-off-by: William A. Kennington III <wak@google.com>

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia4966a0790437eb0fc011c747f3be2a52884e4d8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

treewide: Codify memory pinning

This enforces movability constraints.

Change-Id: I49dbd43a791c1d70eb7e97f30708231c053901d9
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Cleanup signal emission

Don't emit properties changed prior to interfaces added.

Change-Id: I7f88b8052a323ca49ce9f16fe446596213e3fdb5
Signed-off-by: William A. Kennington III <wak@google.

treewide: Cleanup signal emission

Don't emit properties changed prior to interfaces added.

Change-Id: I7f88b8052a323ca49ce9f16fe446596213e3fdb5
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Migrate object creation from network_manager

Change-Id: I861a7e7484b33bfc94fc30ff17fa27fca2b95bfa
Signed-off-by: William A. Kennington III <wak@google.com>

ethernet_interface: Remove optional signal emission

We don't ever need to turn this off anymore, so we can simplify creation
arguments.

Change-Id: Idb1bde35041f16d409753ff661bfb248cfd4591e
Signed-o

ethernet_interface: Remove optional signal emission

We don't ever need to turn this off anymore, so we can simplify creation
arguments.

Change-Id: Idb1bde35041f16d409753ff661bfb248cfd4591e
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

treewide: Completely remove global refresh

We no longer need any of the global refresh code as we can dynamically
receive all of the updates to network configuration.

Change-Id: Ia8cb3af827c599c17d

treewide: Completely remove global refresh

We no longer need any of the global refresh code as we can dynamically
receive all of the updates to network configuration.

Change-Id: Ia8cb3af827c599c17d5df9fdddaf6cdc6546050d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

network_manager: Async query all interface states

This only queries the state during startup and relies on matches to keep
up with changes from the systemd-networkd daemon.

Change-Id: I30776d443c39

network_manager: Async query all interface states

This only queries the state during startup and relies on matches to keep
up with changes from the systemd-networkd daemon.

Change-Id: I30776d443c39a52a91826ad1b515da60c7ecf641
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

types: Migrate all of the Info types

Change-Id: I00f4fdf6141aafc4552d61fa06f75275dea71b20
Signed-off-by: William A. Kennington III <wak@google.com>

rtnetlink_server: Don't refresh for neighbors

They can be dynamically added and removed now.

Change-Id: Ia09cf6378d54b31e4957fb8e6f09d2e110dd53ae
Signed-off-by: William A. Kennington III <wak@googl

rtnetlink_server: Don't refresh for neighbors

They can be dynamically added and removed now.

Change-Id: Ia09cf6378d54b31e4957fb8e6f09d2e110dd53ae
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

rtnetlink_server: Don't refresh for addresses

We can dynamically add and remove addresses without having to recreate
all of the objects.

Change-Id: Ic510263cc6ba5d2ec228ce94fa83cf5fe4664c6d
Signed-

rtnetlink_server: Don't refresh for addresses

We can dynamically add and remove addresses without having to recreate
all of the objects.

Change-Id: Ic510263cc6ba5d2ec228ce94fa83cf5fe4664c6d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

neighbor: Refactor object creation

Change-Id: Ic46d39f4717799ecce1c1fa84096f27e674e69a6
Signed-off-by: William A. Kennington III <wak@google.com>

ipaddress: Refactor object creation

Change-Id: Icae934e3dc88d596812b75a31598636ae7b95823
Signed-off-by: William A. Kennington III <wak@google.com>

ethernet_interface: Merge VLAN into EthernetInterface

This simplifies the ethernet interface as it codepended on the vlan
interface to make VLANs. It also removes the naming dependency and
tracks VL

ethernet_interface: Merge VLAN into EthernetInterface

This simplifies the ethernet interface as it codepended on the vlan
interface to make VLANs. It also removes the naming dependency and
tracks VLANs by adapter type and parent indexes.

Change-Id: I8db09cc2474472e6d4a06c6be5cf0440ee48d132
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

system_queries: Get Interface Info from netlink

This reduces all of the interface information probing down to a single
netlink request for all the label + mac information needed to build an
ethernet

system_queries: Get Interface Info from netlink

This reduces all of the interface information probing down to a single
netlink request for all the label + mac information needed to build an
ethernet interface.

If we ever plumb the ethernet stats into dbus, we can get that
information with this same netlink code.

Change-Id: Ied8a73639dcd74bcfecda392905638573ab7970f
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Refactor object creation args

We want to be able to pass a bunch of interface properties directly into
interface instead of querying them directly. This will be used later for
rt

ethernet_interface: Refactor object creation args

We want to be able to pass a bunch of interface properties directly into
interface instead of querying them directly. This will be used later for
rtnetlink enabled interface creation.

Change-Id: I93fbd460a8a54515e84c415f085548cb5528f231
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

system_queries: Migrate system queries into a single place

This provides better separation of the DBus interface and the underlying
system interactions.

Change-Id: I8bf7a44c679ab065f959af19a00c2989

system_queries: Migrate system queries into a single place

This provides better separation of the DBus interface and the underlying
system interactions.

Change-Id: I8bf7a44c679ab065f959af19a00c29897c1d5c48
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Set static & dhcp sent ntp server ip on ethernet obj

Currently there is no way to differentiate between the Static
and DHCP assigned NTP servers at dbus

This commit adds StaticNTPServers peroperty

Set static & dhcp sent ntp server ip on ethernet obj

Currently there is no way to differentiate between the Static
and DHCP assigned NTP servers at dbus

This commit adds StaticNTPServers peroperty to hold the static
configuration of NTP servers. This is a read-write property.
The existing NTPServer propery will hold both static and DHCP
assigned NTP servers. This is a read-only property.

The static and dhcp sent ntp server details are present in the
dbus object hosted by systemd-timesyncd service (mentioned in
Tested By section).

In this change, networkd fetches the ntp server details from the
timesyncd dbus object and set the "NTPServers" property with dhcp sent
ip and "StaticNTPServers" will be set from the configuration file.

Tested By:

* Change the ntp server ips in dhcp config file & restart dhcpd
* timesyncd dbus object contains the new list of ips as below:

busctl introspect org.freedesktop.timesync1 /org/freedesktop/timesync1
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
org.freedesktop.timesync1.Manager interface - - -
.FallbackNTPServers property as 4 "time1.google.com" "time2.google.com"… const
.Frequency property x 0 -
.LinkNTPServers property as 1 "1.1.1.1" -
.NTPMessage property (uuuuittayttttbtt) 0 0 0 0 0 0 0 4 0 0 0 0 0 1844453508490… emits-change
.PollIntervalMaxUSec property t 2048000000 const
.PollIntervalMinUSec property t 32000000 const
.PollIntervalUSec property t 2048000000 -
.RootDistanceMaxUSec property t 5000000 const
.ServerAddress property (iay) 2 4 1 1 1 1 -
.ServerName property s "1.1.1.1" -
.SystemNTPServers property as 0 const

* Since network configuration has changed, the service restarts and
ntp server details are loaded from timesyncd dbus object & config file,
and are set in dbus objects hosted by networkd.

command: busctl introspect xyz.openbmc_project.Network /xyz/openbmc_project/network/eth0
busctl introspect xyz.openbmc_project.Network /xyz/openbmc_project/network/eth1

* Ethernet interface network config files will be updated with NTP=<ip addresses> under [Network]

command: cat /etc/systemd/network/00-bmc-eth0.network
cat /etc/systemd/network/00-bmc-eth1.network

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: If8b1b3ed2afb531f179e00da173f6f86a1bf0c18

show more ...