clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I335e0c726360eaae85b9b54c16b5dcbe4a3f182e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

treewide: Convert most fmt::format -> std::format

Change-Id: I3c9ac1eed1c86c6cd9f7fd3a1ba356734e79f937
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Remove uses of FMT_COMPILE

We can use stdplus::strCat which takes even less code space.

Change-Id: I91185afa7f5d9041ca7477eb19d5d53755ed329d
Signed-off-by: William A. Kennington III <wak@

treewide: Remove uses of FMT_COMPILE

We can use stdplus::strCat which takes even less code space.

Change-Id: I91185afa7f5d9041ca7477eb19d5d53755ed329d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia4966a0790437eb0fc011c747f3be2a52884e4d8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

config_parser: Add support for checking file existence

This will be used to reduce the number of config parser errors printed
to the logs.

Change-Id: Ia0337da386bc5dbe32c04bf2c3264997a9ad6da1
Signe

config_parser: Add support for checking file existence

This will be used to reduce the number of config parser errors printed
to the logs.

Change-Id: Ia0337da386bc5dbe32c04bf2c3264997a9ad6da1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

treewide: Remove redundant inline

Change-Id: Ibfc3d9cad1ae31c46bf432c90e406007e84df4d0
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Clean up string parameters

Change-Id: I0d3ea6a83465181d3edec1587ff824103489072e
Signed-off-by: William A. Kennington III <wak@google.com>

config_parser: Add function for writing files

This will be used by the configuration writers shortly.

Change-Id: I6e72b181e365e34808c8e5e4790c446124dc13a3
Signed-off-by: William A. Kennington III <

config_parser: Add function for writing files

This will be used by the configuration writers shortly.

Change-Id: I6e72b181e365e34808c8e5e4790c446124dc13a3
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Allow modifying Parser map

This makes it possible to mutate the map owned by the parser. This will
eventually be used for implementing write updates.

Change-Id: I89deb4073a0a3bd59528

config_parser: Allow modifying Parser map

This makes it possible to mutate the map owned by the parser. This will
eventually be used for implementing write updates.

Change-Id: I89deb4073a0a3bd59528c6b70fc55b49bc6cd944
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Add type checking to config map

In order to guarantee the output file is consistent, the
constructed values are checked for safety.

Change-Id: Ib70e369471e9f2f47a1cdb5522f4a3bebc3780

config_parser: Add type checking to config map

In order to guarantee the output file is consistent, the
constructed values are checked for safety.

Change-Id: Ib70e369471e9f2f47a1cdb5522f4a3bebc37805e
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Split up sections

We can't always combine sections together in network files as sections
like

[Address]
Address=::1/128
Peer=fe80::1
[Address]
Address=::2/128
Peer=fe80::2

Require t

config_parser: Split up sections

We can't always combine sections together in network files as sections
like

[Address]
Address=::1/128
Peer=fe80::1
[Address]
Address=::2/128
Peer=fe80::2

Require that they are grouped accordingly. Rewrite the storage logic of
the config parser to support this logical organization.

Change-Id: I34ae1523202f8770fe3dcac010fb6226dd28b9ec
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Reduce number of file reads

This changes focuses on reducing the number of Parser() constructions to
limit the number of duplicate file reads.

Change-Id: I05df943844c70dc6aa729ab744d

config_parser: Reduce number of file reads

This changes focuses on reducing the number of Parser() constructions to
limit the number of duplicate file reads.

Change-Id: I05df943844c70dc6aa729ab744d2d405cbfe2c76
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Add common boolean parser

This more accurately parses systemd values instead of just comparing to
"false" or "true".

Change-Id: I0d70ef418075d555bf6f090fefa0b34332491ed0
Signed-off-b

config_parser: Add common boolean parser

This more accurately parses systemd values instead of just comparing to
"false" or "true".

Change-Id: I0d70ef418075d555bf6f090fefa0b34332491ed0
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Add parser warnings

This makes it possible to determine if the file had formatting issues
and should be rewritten.

Change-Id: I1a1fd683b5733bff1841703dcd7be99688b66c54
Signed-off-by:

config_parser: Add parser warnings

This makes it possible to determine if the file had formatting issues
and should be rewritten.

Change-Id: I1a1fd683b5733bff1841703dcd7be99688b66c54
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Rewrite file parsing logic

This grealty improves the correctness of the config parser to
better match the way systemd parses config files. It also allows us to
provide errors / warnin

config_parser: Rewrite file parsing logic

This grealty improves the correctness of the config parser to
better match the way systemd parses config files. It also allows us to
provide errors / warnings when the file format doesn't match
expectations.

Tested: On an existing BMC system to verify NTP / DHCP settings were
still parsed as expected.

Change-Id: I1f0cb631f680f5957a29accaa749d491e6f68faf
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Cleanups and modern c++ standards

This was exposing many functions and semantics that are unused by the
application. The goal is to simplify the interface and convert to using
types l

config_parser: Cleanups and modern c++ standards

This was exposing many functions and semantics that are unused by the
application. The goal is to simplify the interface and convert to using
types like `string_view` and referenceable lists where possible.

Change-Id: I4cba6326f9a96a943d384165e656f8589f931959
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Manage configuration parser file state using RAII

Static code analysis tools flagged the file state handling as a
potential source of resource loss. Change the code to use RAII to
control the file s

Manage configuration parser file state using RAII

Static code analysis tools flagged the file state handling as a
potential source of resource loss. Change the code to use RAII to
control the file state automatically. This eliminates the need for
manual intervention, and errors that may arise from manual filehandle
management.

Tested:
Placed debug print statements to confirm the stream is still opened,
and the contents parsed. Removed the print statements following
confirmation.

Change-Id: I6f20117b948673a4babc4b702da741145e57a1c6
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

build: Split c++ sources into a subdirectory

Change-Id: Iedea50c688189ae4953195105e323f7173d17a4b
Signed-off-by: William A. Kennington III <wak@google.com>