clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I8d0072c279e4de87dc001190845d0ca6da233345
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Remove libmapper dependency

phosphor-net-ipmid does not use the API in libmapper. This patch
removes the dependence on libmapper.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Iffae

Remove libmapper dependency

phosphor-net-ipmid does not use the API in libmapper. This patch
removes the dependence on libmapper.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Iffaee8f84e0485c1b36a469d328b82ec4dad218c

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I5278656122f19da46fcd0a84bc96af420d4cb8bd
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Update System GUID handling to be more robust

If the service that owns the GUID has not yet started when
netipmid starts, netipmid was throwing an error and failing
to start. If the time difference

Update System GUID handling to be more robust

If the service that owns the GUID has not yet started when
netipmid starts, netipmid was throwing an error and failing
to start. If the time difference was too great, it would fail
to re-start and then stay stopped. This makes the error
handling more robust so that the order is not so important.

Tested: started netipmid with and without the UUID service
running and restarted the service to ensure that
netipmid would stay running.

Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
Change-Id: Id464330a2ba8416ff229fa258fff0ad7a1b8f51c

show more ...

Fix the wrong service and path to get the guid

The service and the path to get the guid is wrong; and the
'PropertiesChanged' also use the wrong path and interface

Test:
```
1. set the guid
busctl

Fix the wrong service and path to get the guid

The service and the path to get the guid is wrong; and the
'PropertiesChanged' also use the wrong path and interface

Test:
```
1. set the guid
busctl set-property xyz.openbmc_project.Settings /xyz/openbmc_project/inventory/item/bmc xyz.openbmc_project.Common.UUID UUID s 5c410eb0-ec99-11ec-831a-eec108c4c29c

2. restart netipmid
Jan 16 07:35:47 g220a systemd[1]: Stopping Network IPMI daemon...
Jan 16 07:35:47 g220a systemd[1]: phosphor-ipmi-net@bond1.service: Deactivated successfully.
Jan 16 07:35:47 g220a systemd[1]: Stopped Network IPMI daemon.
Jan 16 07:35:48 g220a systemd[1]: Started Network IPMI daemon.
Jan 16 07:35:48 g220a netipmid[735]: get guid
Jan 16 07:35:48 g220a netipmid-bond1[735]: 0x9c, 0xc2, 0xc4, 0x08, 0xc1, 0xee, 0x1a, 0x83, 0xec, 0x11, 0x99, 0xec, 0xb0, 0x0e, 0x41, 0x5c,

3. get the guid by ipmi
ipmitool raw 0x06 0x37
9c c2 c4 08 c1 ee 1a 83 ec 11 99 ec b0 0e 41 5c

4. change the guid property
busctl set-property xyz.openbmc_project.Settings /xyz/openbmc_project/inventory/item/bmc xyz.openbmc_project.Common.UUID UUID s 5c410eb0-ec99-11ec-831a-eec108c4c29d
Jan 16 07:36:09 g220a netipmid[735]: propertiesChanged
Jan 16 07:36:09 g220a netipmid[735]: get guid
Jan 16 07:36:09 g220a netipmid-bond1[735]: 0x9d, 0xc2, 0xc4, 0x08, 0xc1, 0xee, 0x1a, 0x83, 0xec, 0x11, 0x99, 0xec, 0xb0, 0x0e, 0x41, 0x5c,

5. get the guid by ipmi
ipmitool raw 0x06 0x37
9d c2 c4 08 c1 ee 1a 83 ec 11 99 ec b0 0e 41 5c
```

Signed-off-by: Xie Ning <xiening.xll@bytedance.com>
Change-Id: Icc81cb68c08ec019b717519028bd94def968e151

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I862ed296ce1f42dba7047a74540d9004ad78130c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

logging: switch to lg2

After switching to C++20, it is recommended to use `phosphor::lg2`
to format log, and the correct `CODE_LINE` and `CODE_FUNC` values
can be used in log tracking.

Signed-off-b

logging: switch to lg2

After switching to C++20, it is recommended to use `phosphor::lg2`
to format log, and the correct `CODE_LINE` and `CODE_FUNC` values
can be used in log tracking.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I4aabaafe997e13c10d655a83a9ef0071ad11126e

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic68a12ef7c12222b1300981282161c971b561dc1

show more ...

Update to latest clang-format

Refer:https://github.com/openbmc/docs/blob/ac5d544553934f8083c61c5986a1420261bc8a4c/style/cpp/.clang-format

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id:

Update to latest clang-format

Refer:https://github.com/openbmc/docs/blob/ac5d544553934f8083c61c5986a1420261bc8a4c/style/cpp/.clang-format

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I1e06864afc29ce7de463e62fa2a0eb6f70e8fd93

show more ...

Convert host-ipmid -> libipmid

phosphor-host-ipmid now exposes a library along with headers for
interfacing with the ipmi daemon. Compile and link against the new
library.

Change-Id: Ifb914004df2b7

Convert host-ipmid -> libipmid

phosphor-host-ipmid now exposes a library along with headers for
interfacing with the ipmi daemon. Compile and link against the new
library.

Change-Id: Ifb914004df2b73cff913bf653db14ff2e710434f
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

netipmid: replace std::cerr with phosphor::logging calls

This is part of a cleanup and standardization effort of code to get
existing code up to date.

Change-Id: I0c982ef8d7afa2f56a9cd204bb8ac31127

netipmid: replace std::cerr with phosphor::logging calls

This is part of a cleanup and standardization effort of code to get
existing code up to date.

Change-Id: I0c982ef8d7afa2f56a9cd204bb8ac3112769641c
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

style: cppcheck cleanup

[command/guid.cpp:37]: (style) The scope of the variable 'rc' can be
reduced.
[socket_channel.hpp:44]: (performance) Variable 'timeout' is assigned
in constructor body. Consi

style: cppcheck cleanup

[command/guid.cpp:37]: (style) The scope of the variable 'rc' can be
reduced.
[socket_channel.hpp:44]: (performance) Variable 'timeout' is assigned
in constructor body. Consider performing initialization in
initialization list.
[sd_event_loop.cpp:107]: (style) The scope of the variable 'instance'
can be reduced.
[sd_event_loop.cpp:108]: (style) The scope of the variable 'rc' can be
reduced.
[sd_event_loop.cpp:142]: (style) The scope of the variable 'instance'
can be reduced.
[sd_event_loop.cpp:304]: (style) The scope of the variable 'rc' can be
reduced.

Change-Id: Id090cb217ea7ed9019f1b8d39ebebd6bb73113b1
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

netipmid: apply clang-format rules

Lots of whitespace change. Let clang-format do its job and keep the code
looking nice.

Change-Id: Idfcad1a99cab8170d55a06163de8ad3f420b68b7
Signed-off-by: Vernon

netipmid: apply clang-format rules

Lots of whitespace change. Let clang-format do its job and keep the code
looking nice.

Change-Id: Idfcad1a99cab8170d55a06163de8ad3f420b68b7
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Cache system GUID in netipmid

GUID is used in the IPMI session setup steps RAKP12 and RAKP34.
The GUID is read from the DBUS property. It is observed that
when the host is booting, reading the GUID

Cache system GUID in netipmid

GUID is used in the IPMI session setup steps RAKP12 and RAKP34.
The GUID is read from the DBUS property. It is observed that
when the host is booting, reading the GUID takes a significant
delay and the session setup fails with ipmitool. Since GUID doesn't
change for a machine, it is safe to cache GUID in the netipmid and
speed up the session setup.

Resolves openbmc/openbmc#1812
Resolves openbmc/openbmc#2245
Resolves openbmc/openbmc#2246

Change-Id: I78c993b3e5ef8b6764457c8fdb3ecb985b965c0c
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

show more ...

Implementation to read System UUID from Chassis DBUS object

Implementation for reading system UUID which would be consumed
by RAKP12, RAKP34 and System GUID commands.

Change-Id: Ibee1c398368f67055c

Implementation to read System UUID from Chassis DBUS object

Implementation for reading system UUID which would be consumed
by RAKP12, RAKP34 and System GUID commands.

Change-Id: Ibee1c398368f67055cdba2a0f4d16c981e38c035
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

show more ...