Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I3b65183bab2be7aab90d1e184eb778216a54c145
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

gen_path_callouts: Add non strict mode

The targets generated from an MRW XML file may initially have some
structural problems, such as a unit target not having a parent chip
target. It's easier to

gen_path_callouts: Add non strict mode

The targets generated from an MRW XML file may initially have some
structural problems, such as a unit target not having a parent chip
target. It's easier to find all of the problems at once when the script
doesn't just die on the first one, so add a '-n' non strict mode where
it will continue on.

Change-Id: I7ca8097d6ad3c0dc44c661a474be63a727515457
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

utilize "/usr/bin/env perl" in perl scripts

When utilizing /usr/bin/perl, this expands to the full path of your
filesystem build. i.e. something like this:

/home/andrewg/Code/openbmc/build/withersp

utilize "/usr/bin/env perl" in perl scripts

When utilizing /usr/bin/perl, this expands to the full path of your
filesystem build. i.e. something like this:

/home/andrewg/Code/openbmc/build/witherspoon/tmp/work/x86_64-linux/mrw-perl-tools-native/1.0+gitAUTOINC+65ca8e19c4-r1/recipe-sysroot-native/usr/bin/perl

This now exceeds the allowed size by yocto:
"maximum shebang size exceeded, the maximum size is 128."

There are ways to disable this check in yocto, and we probably have a
case to argue this upstream, but our use in OpenBMC of perl is pretty
limited so the easiest solution is to just move the perl scripts over to
using /usr/bin/env. Half the perl scripts in this repo already do this.

Tested:
- Verified new yocto now builds this repo

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I1c6dfc49a9a1d5ace0d0b9fdd4fa7a0abdee033e

show more ...

ensure no space in script type string

New bitbake checks to ensure the #! line does not exceed 180 characters
and it requires no space between it and the script type info.

Signed-off-by: Andrew Gei

ensure no space in script type string

New bitbake checks to ensure the #! line does not exceed 180 characters
and it requires no space between it and the script type info.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: If52da98c06aced381a6b82cfc0756c1a322f7aec

show more ...

gen_path_callouts: Looks for I2C_BUS_ALIAS

The I2C_BUS_ALIAS bus attribute holds the alias value the BMC uses for
I2C buses behind I2C muxes. For example, a value of 30 could be an
alias for the bu

gen_path_callouts: Looks for I2C_BUS_ALIAS

The I2C_BUS_ALIAS bus attribute holds the alias value the BMC uses for
I2C buses behind I2C muxes. For example, a value of 30 could be an
alias for the bus on channel 3 of a mux on I2C bus 5. This is the
actual value the BMC uses, so it doesn't need to be adjusted later
(subtract 1) like the other buses in the MRW require.

If this attribute is filled in for a device, use that value as the I2C
bus.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I502d3cdabe19c8f47011fa941ad1c09e446c3a50

show more ...

gen_path_callouts: Fix usage string

The code had a string concat operator '.' instead of a ';'.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I4bf77d4eb639558882e904925920aa6e068a52e9

gen_path_callouts: Write callouts to JSON file

Save all of the Callout objects to a JSON file. This is where the FRU
callout has its duplicates removed and is sorted based on priority.

This also a

gen_path_callouts: Write callouts to JSON file

Save all of the Callout objects to a JSON file. This is where the FRU
callout has its duplicates removed and is sorted based on priority.

This also adds a new Util module function getLocationCode to find the
location code of a target.

The JSON file is organized into sections for each callout type,
with keys based on the type. I2c uses a bus and address, FSI uses a
link, and SPI uses a bus number. If FSI is combined with I2C or SPI,
then the link plus the I2C/SPI keys is used. Multi-hop FSI links are
indicated by a dash in between the links, eg "0-1". A contrived example
of an entry in the FSI section, on link 5, is:

"FSI":
{
"5":
{
"Callouts":[
{
"Priority":"H"
"LocationCode": "P1-C50",
"MRU":"/sys-0/node-0/motherboard/proc_socket-0/module-0/power9-0",
"Name":"/sys-0/node-0/motherboard/cpu0"
},
{
"Priority":"M",
"LocationCode": "P1-C42",
"MRU":"/sys-0/node-0/motherboard/ebmc-card/BMC-0",
"Name":"/sys-0/node-0/motherboard/ebmc-card"
},
{
"Priority":"L",
"LocationCode": "P1",
"Name":"/sys-0/node-0/motherboard"
}
],
"Dest":"/sys-0/node-0/motherboard-0/proc_socket-0/module-0/power9-0",
"Source":"/sys-0/node-0/motherboard-0/ebmc-card-connector-0/card-0/bmc-0"
}
}

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Iee3493834d5045c553a52c80bbb62f7aa71140e0

show more ...

gen_path_callouts: Create multi-segment callouts

The BMC FSI segments will be connected to other FSI segments to create
new FSI callouts as far out as there is a path, and all the FSI callouts
will

gen_path_callouts: Create multi-segment callouts

The BMC FSI segments will be connected to other FSI segments to create
new FSI callouts as far out as there is a path, and all the FSI callouts
will be connected with any I2C or SPI segments to create new FSII2C or
FSISPI callouts. For example, there could be a Callout object that
contains the path of: BMC -> FSI -> Proc -> FSI -> Proc -> I2C ->
end device.

When the new Callout objects are created from two other callout objects,
the FRU callout lists will be cumulative. In a future commit, they will
be sorted and made unique.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Id1aeb02ead755a876a25f28341c4693762b8b86a

show more ...

gen_path_callouts: Create objects for segments

Create FSI, I2C, and SPI callout objects for the bus segments directly
off of the BMC.

A future commit will extend the FSI callouts to other segments

gen_path_callouts: Create objects for segments

Create FSI, I2C, and SPI callout objects for the bus segments directly
off of the BMC.

A future commit will extend the FSI callouts to other segments further
away.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I3c34034162369bad6722bdebacd651bf37518c74

show more ...

Create gen_path_callouts.pl

This script will pull callouts out of the FRU_PATH attribute on
connections and create a JSON file that has those callouts along with
the FSI/I2C/SPI/FSI-I2C/FSI-SPI keys

Create gen_path_callouts.pl

This script will pull callouts out of the FRU_PATH attribute on
connections and create a JSON file that has those callouts along with
the FSI/I2C/SPI/FSI-I2C/FSI-SPI keys to look them up.

It will be used by OpenBMC code to add callouts to error logs for device
access failure.

This first commit just builds an array of all the FSI/I2C/SPI bus
segments in the system and optionally prints them to JSON.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I4c789ca82b48e00925e03e613b03e965edd383d4

show more ...