mbox: Forward-declare struct mbox_context

Avoid compilation errors such as:

$ make
make all-am
make[1]: Entering directory '/home/andrew/src/openbmc/phosphor-mboxd'
CC mbox

mbox: Forward-declare struct mbox_context

Avoid compilation errors such as:

$ make
make all-am
make[1]: Entering directory '/home/andrew/src/openbmc/phosphor-mboxd'
CC mboxd-common.o
CC mboxd-mboxd_dbus.o
CC mboxd-mboxd_lpc.o
CC mboxd-mboxd_msg.o
CC mboxd-mboxd_windows.o
CC mboxd-mtd.o
CC mboxd-mboxd_flash.o
CC mboxctl-mboxctl.o
CC mboxd-mboxd_lpc_reset.o
In file included from mboxd_dbus.c:28:0:
mbox.h:133:42: error: ‘struct mbox_context’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
typedef int (*mboxd_mbox_handler)(struct mbox_context *, union mbox_regs *,
^~~~~~~~~~~~
cc1: all warnings being treated as errors
Makefile:2201: recipe for target 'mboxd-mboxd_dbus.o' failed
make[1]: *** [mboxd-mboxd_dbus.o] Error 1
make[1]: *** Waiting for unfinished jobs....

Change-Id: Ie59a7b6a0831dc509b133fe35a2107f802afb49c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mbox_msg: Move handler table to struct mbox_context

This allows us to provide alternative implementations for the handlers
as necessary. The vpnor feature, which enforces the read-only property
of F

mbox_msg: Move handler table to struct mbox_context

This allows us to provide alternative implementations for the handlers
as necessary. The vpnor feature, which enforces the read-only property
of FFS partitions, requires this for handling CREATE_WRITE_WINDOW.

Change-Id: Ia969a6f085244b194c500e66b62adca5e10bacba
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

vpnor: Isolate relevant code in vpnor directory

This is prepatory work for introducing more vpnor-specific behaviours to
window handling. We will be introducing more objects to link, in order
to hoo

vpnor: Isolate relevant code in vpnor directory

This is prepatory work for introducing more vpnor-specific behaviours to
window handling. We will be introducing more objects to link, in order
to hook some of the window command handlers.

This change takes the opportunity to revert back to the upstream names
for some of the original C files.

Change-Id: I6b67ae466a2695054035e65ba752881be9c32d1a
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

misc: Replace license blurb with kernel-style SPDX markers

This was roughly achieved by the following shell script:

$ git ls-files |
grep '\.[ch]p*$' |
while read F; do EXT=${F##*.}; cat spdx.$EX

misc: Replace license blurb with kernel-style SPDX markers

This was roughly achieved by the following shell script:

$ git ls-files |
grep '\.[ch]p*$' |
while read F; do EXT=${F##*.}; cat spdx.$EXT <(sed '/^\/\*$/,/^ \*\/$/d' $F) > ${F}.tmp; mv ${F}.tmp $F; done

With the following context:

$ cat spdx.c
// SPDX-License-Identifier: Apache-2.0
// Copyright (C) 2018 IBM Corp.
$ cat spdx.h
/* SPDX-License-Identifier: Apache-2.0 */
/* Copyright (C) 2018 IBM Corp. */
$ ls -l spdx.*
-rw-r--r-- 1 andrew andrew 71 Feb 27 12:02 spdx.c
lrwxrwxrwx 1 andrew andrew 6 Feb 27 12:02 spdx.cpp -> spdx.c
-rw-r--r-- 1 andrew andrew 77 Feb 27 12:02 spdx.h
lrwxrwxrwx 1 andrew andrew 6 Feb 27 12:02 spdx.hpp -> spdx.h

The `sed` invocation catches a lot of function documentation, so the
hunks were manually added to avoid removing information that we want to
keep.

Change-Id: I63e49ca2593aa0db0568c7a63bfdead388642e76
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

Load the partitions into virtual pnor

Change-Id: I709c410009fb0047d7e59ddd3a681f25e49341a0
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

pnor: provide "C" interface to partition table

Change-Id: I35af6c4c43e9a43f6a21992bfb0c13542a2c8f0d
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

version: Update to version 2.1.0

Update to package version V2.1.0 to reflect that a backwards compatible
API change was made. This API change was the introduction of the timeout
to the GET_MBOX_INFO

version: Update to version 2.1.0

Update to package version V2.1.0 to reflect that a backwards compatible
API change was made. This API change was the introduction of the timeout
to the GET_MBOX_INFO command.

This version update also encompasses previous bug fixes.

The versioning scheme is now aligned to semver.

Use the version from config.h for both mboxd and mboxctl instead of an
independant value for the daemon and control programs.

Change-Id: I12d7fe8e40697801594b1727054342613923a784
Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>

show more ...

mbox: Add includes to header for used types

mbox.h makes use of struct pollfd and bool types, so lets include the
appropriate headers to make the mbox header self-contained.

Change-Id: Ia9e1ce4477a

mbox: Add includes to header for used types

mbox.h makes use of struct pollfd and bool types, so lets include the
appropriate headers to make the mbox header self-contained.

Change-Id: Ia9e1ce4477a510fb9a0fa841f6542327930e02bb
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mbox: Clarify sequence number constraints

And implement the specified behaviour.

Change-Id: I268d5896aa8dda3875cd79f4ff18929c8e3aea49
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mboxd: Update mboxd to implement protocol V2 and add dbus support

Version 2 of the mbox protocol contains a few changes such as:
- All sizes are in block size
- Adds an erase command
- Adds new r

mboxd: Update mboxd to implement protocol V2 and add dbus support

Version 2 of the mbox protocol contains a few changes such as:
- All sizes are in block size
- Adds an erase command
- Adds new response codes
- Adds new BMC events
- Open windows commands now take a size directive

Update the mailbox daemon to support version 2 of the protocol which
includes implementing all of the V2 functionality. Also entirely refactor
the mboxd.c code to make it more modular improving readability and
maintainability.

At the same time improve the functionality by adding:
- Multiple windows in the daemon (still only one active window) to cache
flash contents
- Implement a dbus interface to allow interaction with the daemon
- Handle sigterm and sigint and terminate cleanly

The previous implementation utilised the entire reserved memory region.
Update the daemon so that on the command line the number of windows and
the size of each which the reserved memory region will be split into can
be specified. The reserved memory region is then divided between the
windows, however there can still only be one "active" window at a time.
The daemon uses these windows to cache the flash contents meaning the
flash doesn't have to be copied when the host requests access assuming
the daemon already has a copy.

A dbus interface is added so that commands can be sent to the daemon to
control it's operation from the bmc. These include suspending and resuming
the daemon to synchronise flash access, telling the daemon to point the lpc
mapping back to flash and telling the daemon when the flash has been
modified out from under it.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: I10be01a395c2bec437cf2c825fdd144580b60dbc

show more ...

First commit