History log of /openbmc/phosphor-logging/test/openpower-pels/pel_values_test.cpp (Results 1 – 7 of 7)
Revision Date Author Comments
# 242be740 16-Sep-2021 Vijay Lobo <vijaylobo@gmail.com>

PEL: Update pel_values to support bmcweb

Updates done to support display of Message property in bmcweb.
With the redfish command the message property showed up as
--old-
"Message": "xyz.openbmc_proj

PEL: Update pel_values to support bmcweb

Updates done to support display of Message property in bmcweb.
With the redfish command the message property showed up as
--old-
"Message": "xyz.openbmc_project.Power.PowerSupply.Error.InputFault"
--New--
"Message": "110015F0 event in subsystem: Power Supply",

Note that the "Power Supply" is a $subsystem property and had ':' in the
description, to enhance readability the $subsystem for CEC Hardware is
update with '-' in place of ':'.

Change-Id: Ic6af0937f4e560753814462692b95185a6d84d07
Signed-off-by: Vijay Lobo <vijaylobo@gmail.com>

show more ...


# b181d9d1 05-Jun-2020 Matt Spinler <spinler@us.ibm.com>

Fixes to get unit tests to compile

There are 2 CI failures that started showing up at the same time:

1) sdbusplus recenty had a commit that started checking the return code
on sd_bus_add_object_

Fixes to get unit tests to compile

There are 2 CI failures that started showing up at the same time:

1) sdbusplus recenty had a commit that started checking the return code
on sd_bus_add_object_vtable and now 2 tests are getting those fails
in CI, so used the mocked bus objects instead.

2) pel_values_test.cpp fails with:
Expected equality of these values:
"cec_service_network"
Which is: 0x563efae570fc
std::get<registryNamePos>(*s)
Which is: 0x563efae57a64
because it is using EXPECT_EQ to compare to char* values instead of
EXPECT_STREQ. I'm not sure what changed that uncovered this.

Fix them both at the same time as CI won't pass when doing them
separately because of the other error.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I937bd6d6965be5c8aab26f6c539cf30537439e0b

show more ...


# a27e2e50 09-Apr-2020 Matt Spinler <spinler@us.ibm.com>

PEL: Get rid of the enum for a maint procedure

It simplifies the code to just use the string name of the procedure as defined
by the message registry schema, and make it be less maintenance to add
n

PEL: Get rid of the enum for a maint procedure

It simplifies the code to just use the string name of the procedure as defined
by the message registry schema, and make it be less maintenance to add
new procedures in the future, especially if they come from the registry
so the enum isn't even needed.

This will also make it the same as upcoming support for symbolic FRU
callouts, which will always just come from the registry or an external
user so would not need an enum.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia8550235678ba1fc717a6b0875e2d7ff3888bfec

show more ...


# 578e070f 13-Mar-2020 Matt Spinler <spinler@us.ibm.com>

PEL: Maintenance procedure callout definitions

A maintenance procedure is a short string that resides in the FRU
identity structure in the SRC section of a PEL that maps to a service
procedure in th

PEL: Maintenance procedure callout definitions

A maintenance procedure is a short string that resides in the FRU
identity structure in the SRC section of a PEL that maps to a service
procedure in the service documentation.

This commit adds the initial framework for dealing with these by adding
an enum type to specify them, and a pel_values.hpp function to get the
actual string value of the maintenance procedure based on its enum.

A single procedure is created in this commit, NoVPDforFRU, which will
be used in a future commit when the location code, part number, etc,
aren't available when trying to do a callout and so this procedure will
be used instead.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I45f366e98794462c70d851f743e4f497c0af77b4

show more ...


# 57a24e38 09-Dec-2019 Harisuddin Mohamed Isa <harisuddin@gmail.com>

PEL: Filled in PEL value descriptions

Updated getValue to return value description instead of registry name.
Updated unit test to add checking of value description.

Testing: Ran unit test successfu

PEL: Filled in PEL value descriptions

Updated getValue to return value description instead of registry name.
Updated unit test to add checking of value description.

Testing: Ran unit test successfully on QEMU and also verified peltool
output

Signed-off-by: Harisuddin Mohamed Isa <harisuddin@gmail.com>
Change-Id: Icf64f51a467c3bd4dd9bbcd78aea3df966b20eb7

show more ...


# 97f7abcf 06-Nov-2019 Matt Spinler <spinler@us.ibm.com>

PEL: Add license prologue to test source files

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I67c62ab5ac6e69ad0a84937834581f9a280a9167


# 835a8693 27-Aug-2019 Matt Spinler <spinler@us.ibm.com>

PEL: Support for going between PELs & registry

Add tables that allow one to go between how a PEL field actually shows
up in the PEL (raw bytes) and how it shows up in the message registry (a
string

PEL: Support for going between PELs & registry

Add tables that allow one to go between how a PEL field actually shows
up in the PEL (raw bytes) and how it shows up in the message registry (a
string enumeration). The tables also have a column to show a string
description of that value that can be used by the parser, though for now
those descriptions are all left at "TODO".

There only needs to be a table for a PEL field when there is a
corresponding message registry field that is a string enumeration, so
that when code looks up an error in the message registry it knows what
to fill in the PEL with.

Also provide APIs to look up a row in the table by either the PEL value
or the message registry value.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Iac849bcd2b0449a8d03fac7eb067484e91d28259

show more ...