#
d763db35 |
| 03-Sep-2024 |
harsh-agarwal1 <harsh.agarwal@ibm.com> |
PEL: Prevent deletion if it's associated with HWIsolation
- This ensures that PELs linked to HWIsolation records are protected from accidental deletion. - Shows error message of "Call failed: The se
PEL: Prevent deletion if it's associated with HWIsolation
- This ensures that PELs linked to HWIsolation records are protected from accidental deletion. - Shows error message of "Call failed: The service is temporarily unavailable.", when attempting to delete such a PEL individually. - If trying to Delete all, will skip such PELs without showing any message.
Tested: Sample output: ```bash $ busctl call xyz.openbmc_project.Logging /xyz/openbmc_project/ logging xyz.openbmc_project.Collection.DeleteAll DeleteAll
$ busctl call xyz.openbmc_project.Logging /xyz/openbmc_project/ logging/entry/2 xyz.openbmc_project.Object.Delete Delete Call failed: The service is temporarily unavailable.
``` Change-Id: I2d28de91bbb0fbc2a991e3d5e5631814d41fe044 Signed-off-by: Harsh Agarwal <Harsh.Agarwal@ibm.com>
show more ...
|
#
2544b419 |
| 04-Oct-2022 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: update with latest
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I329396457b83bb2eb8740629b4ac1fbe9106bced
|
#
45e83521 |
| 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are for: * bus_t * exception_t * manager_t * match_t * message_t * object_t * slot_t
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ibc25db433a6926f7ee43ea83312c3ac14f480c33
show more ...
|
#
aeccabc4 |
| 19-May-2021 |
William A. Kennington III <wak@google.com> |
extensions: Deterministic global construction ordering
Right now, we have an issue where the global variables owned by extensions.cpp are not necessarily constructed before other objects try and use
extensions: Deterministic global construction ordering
Right now, we have an issue where the global variables owned by extensions.cpp are not necessarily constructed before other objects try and use them in their own global constructors. We need to gate access on functions that guarantee the object is constructed before it is used.
Change-Id: I71f88a901c21b9121a25e3ccd365d2a74a9be709 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
#
ce0bdf1d |
| 16-Apr-2021 |
Patrick Williams <patrick@stwcx.xyz> |
test: fix compile warnings under -Werror
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Iae11cb541f238c8e6122afaef2186c9ea5aad0c6
|
#
b181d9d1 |
| 05-Jun-2020 |
Matt Spinler <spinler@us.ibm.com> |
Fixes to get unit tests to compile
There are 2 CI failures that started showing up at the same time:
1) sdbusplus recenty had a commit that started checking the return code on sd_bus_add_object_
Fixes to get unit tests to compile
There are 2 CI failures that started showing up at the same time:
1) sdbusplus recenty had a commit that started checking the return code on sd_bus_add_object_vtable and now 2 tests are getting those fails in CI, so used the mocked bus objects instead.
2) pel_values_test.cpp fails with: Expected equality of these values: "cec_service_network" Which is: 0x563efae570fc std::get<registryNamePos>(*s) Which is: 0x563efae57a64 because it is using EXPECT_EQ to compare to char* values instead of EXPECT_STREQ. I'm not sure what changed that uncovered this.
Fix them both at the same time as CI won't pass when doing them separately because of the other error.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I937bd6d6965be5c8aab26f6c539cf30537439e0b
show more ...
|
#
c64b7122 |
| 26-Mar-2020 |
Matt Spinler <spinler@us.ibm.com> |
Implement createWithFFDCFiles
This commit adds support for the createWithFFDCFiles D-Bus method. This method creates a new OpenBMC event log, just like create() does, but it also adds a new paramet
Implement createWithFFDCFiles
This commit adds support for the createWithFFDCFiles D-Bus method. This method creates a new OpenBMC event log, just like create() does, but it also adds a new parameter to pass through information about files containing FFDC (First Failure Data Capture) to any extensions. This FFDC may be stored by the extensions code to provide additional debug information about an error.
The FFDC parameter is a vector of tuples. Each tuple contains: * Format Type - An enumeration describing the format of the data * Subtype - If the format type is custom, then this can be used to provide a format type that is specific to the creator. * Version - If the format type is custom, then this can be used to provide the version of the custom data. * FD - A file descriptor to the file containing the FFDC. This does not need to be closed (an attempt will fail) by phosphor-log-manager.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I3e8e03d6393dfc145e9fd11bd078595868bb3767
show more ...
|
#
99c2b405 |
| 23-May-2019 |
Matt Spinler <spinler@us.ibm.com> |
OpenPower PEL Extension support framework
The goal of extensions is to extend phosphor-logging's `xyz.openbmc_project.Logging.Entry` log support to allow other log formats to be created without incu
OpenPower PEL Extension support framework
The goal of extensions is to extend phosphor-logging's `xyz.openbmc_project.Logging.Entry` log support to allow other log formats to be created without incurring extra D-Bus call overhead.
The README.md change in this commit provides additional documentation on how extensions work. The summary is that they allow code that resides in this repository to provide functions that can be called at certain points (startup, log creation/deletion) such that the code can then create their own logs based on the contents of an OpenBMC log. A specific extension's code is compiled in using a --enable configure option, so platforms that did not use those log formats would incur no performance/size penalties.
This commit provides the support for extensions, plus a basic OpenPower PEL (Platform Event Log) extension as the first extension. PELs are event logs used only on some OpenPower systems.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ifbb31325261c157678c29bbebc7f6d32d282582f
show more ...
|