log-manager: enable non-standard path for local tests

Enable the log-manager to be launched with a path other than
`/var/phosphor-logging` to allow it to be ran on a development system
for test purp

log-manager: enable non-standard path for local tests

Enable the log-manager to be launched with a path other than
`/var/phosphor-logging` to allow it to be ran on a development system
for test purposes. This required some refactoring throughout as to
how paths were handled.

Tested:

After running tests, `/tmp/phosphor-logging` is populated with
entries. Launching `./builddir/phosphor-log-manager
/tmp/phosphor-logging`, the log-manager will have the entries on
dbus:

```
$ busctl --user tree xyz.openbmc_project.Logging
└─ /xyz
└─ /xyz/openbmc_project
└─ /xyz/openbmc_project/logging
├─ /xyz/openbmc_project/logging/entry
│ ├─ /xyz/openbmc_project/logging/entry/100
│ ├─ /xyz/openbmc_project/logging/entry/101
│ ├─ /xyz/openbmc_project/logging/entry/102
│ ├─ /xyz/openbmc_project/logging/entry/103
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I84968edeed0dcf73aaf8bb653060b6d3400b9b7b

show more ...

PEL: Prohibit PEL resolving if associated guard record exists

The commit prohibits marking the 'Resolve' flag of the PEL as 'true'
until the associated guard record resolved if one exists.The user w

PEL: Prohibit PEL resolving if associated guard record exists

The commit prohibits marking the 'Resolve' flag of the PEL as 'true'
until the associated guard record resolved if one exists.The user will
get notified with the same by throwing the DBUS error
`sdbusplus::xyz::openbmc_project::Common::Error::Unavailable`.

Implemented approach:
The PELs will be prohibited from deleting also if the PEL is
associated with a guard record. Hence, implementation is like that
resolve will be prohibited until delete does the same.

Tested:
Sample output:

```
busctl set-property xyz.openbmc_project.Logging
/xyz/openbmc_project/logging/entry/406 xyz.openbmc_project.Logging.Entry
Resolved b true

Failed to set property Resolved on interface xyz.openbmc_project.Logging.Entry:
The service is temporarily unavailable.
```
Change-Id: I77cc191e95c494423d3c875c231fdace8237cf22
Signed-off-by: Arya K Padman<aryakpadman@gmail.com>

show more ...

PEL: Changing the remaining traces to lg2 style

Some of the logging traces of PEL files still uses old style of logging.

Changing the remaining traces in PEL files to lg2 style of logging.Some
of t

PEL: Changing the remaining traces to lg2 style

Some of the logging traces of PEL files still uses old style of logging.

Changing the remaining traces in PEL files to lg2 style of logging.Some
of the traces in phosphor logging code which use the old style is also
considered.

Change-Id: I0daf9589af443881cb61730047c23db17fdec2c3
Signed-off-by: Arya K Padman <aryakpadman@gmail.com>

show more ...

Remove SDBUSPP_REMOVE_DEPRECATED_NAMESPACE

Fix the code to support new sdbusplus error without
SDBUSPP_REMOVE_DEPRECATED_NAMESPACE.

Change-Id: I12713ec1757d3835e1acf07c7abf409ff97615e1
Signed-off-b

Remove SDBUSPP_REMOVE_DEPRECATED_NAMESPACE

Fix the code to support new sdbusplus error without
SDBUSPP_REMOVE_DEPRECATED_NAMESPACE.

Change-Id: I12713ec1757d3835e1acf07c7abf409ff97615e1
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Fix memory leak in Entry::getEntry()

The getEntry() function is a D-Bus method that returns a file
descriptor. While the file descriptor was being closed after the method
return was sent so descrip

Fix memory leak in Entry::getEntry()

The getEntry() function is a D-Bus method that returns a file
descriptor. While the file descriptor was being closed after the method
return was sent so descriptors didn't leak, an fclose() was never
called which appears to leak a bit over 300 bytes according to
valgrind.

Just use open() instead, as the code doesn't actually need to read the
file contents anyway.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Icbe1cd157054f1842aa5b90535f0e3f48db6460a

show more ...

PEL: Support resolution property

Support resolution property to add callouts

Tested: Created new PEL using busctl and checked for the property to
see if the value is updated. The error log daemon w

PEL: Support resolution property

Support resolution property to add callouts

Tested: Created new PEL using busctl and checked for the property to
see if the value is updated. The error log daemon was restarted and the
property is checked again to make sure the value is restored.

Verified serialization of new error log by recreating it on a old code
version to make sure logs are created w/o the new property and the
daemon did not crash.

Result:
root@rainier:~# busctl get-property xyz.openbmc_project.Logging \
/xyz/openbmc_project/logging/entry/1 xyz.openbmc_project.Logging.\
Entry Resolution
s "1. Priority: High, Procedure: BMCSP02\n2. Priority: Medium, PN: \
SVCDOCS\n"

Test with location Code:
root@p10bmc:~# busctl get-property xyz.openbmc_project.Logging \
/xyz/openbmc_project/logging/entry/3 xyz.openbmc_project.Logging.Entry \
Resolution
s "1. Location Code: U78DA.ND0.1234567-P0, Priority: Medium, PN: SVCDOCS\n2. \
Priority: Low, Procedure: BMCSP02\n"

Signed-off-by: Vijay Lobo <vijaylobo@gmail.com>
Change-Id: I44eebbf794efeb8e752fff98de7c638c927982cd

show more ...

PEL: Support eventId property

Support eventId property to add SRC and the hex words to the property

Tested by creating the PEL log and to make sure that the eventId
property was updated properly wi

PEL: Support eventId property

Support eventId property to add SRC and the hex words to the property

Tested by creating the PEL log and to make sure that the eventId
property was updated properly with 9 words and then its present in the
right format when the logging daemon is restarted

Test result:
root@rainier# busctl get-property xyz.openbmc_project.Logging
/xyz/openbmc_project/logging/entry/1 xyz.openbmc_project.Logging.Entry EventId
s "BD8D1001 00000055 2E2D0010 00000000 00000000 00000000 00000000
00000000 00000000"

Also tested with old version of error log and new version with the
eventId property to make sure we don't have issues in serialization

Change-Id: I8e39804cd3d47f0e321c1cf533b97bf165c07518
Signed-off-by: Vijay Lobo <vijaylobo@gmail.com>

show more ...

fix various warnings

Fix various warnings emitted by -Werror:

- Unused parameters.
- Excess semi-colons.
- Missing initializer.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Chan

fix various warnings

Fix various warnings emitted by -Werror:

- Unused parameters.
- Excess semi-colons.
- Missing initializer.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ifcdac2a66f9cc5f7d7e6571e139c0abdb1c86a8d

show more ...

elog_entry: Implement getEntry method

The getEntry method returns the file descriptor to the Entry file.
This method uses its File Path property to determine the path to
the Entry file. The file des

elog_entry: Implement getEntry method

The getEntry method returns the file descriptor to the Entry file.
This method uses its File Path property to determine the path to
the Entry file. The file descriptor is then scheduled to be closed
once the D-Bus call returns.

Tested: Verified calling this method returned a fd that was able to
read the file data from.

Change-Id: I176db463158eb755b325db5769ef4ab993c966ec
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Support UpdateTimestamp log entry property

The UpdateTimestamp property says when an event log property was last
updated. On log creation, this field is initialized with the time that
the log was c

Support UpdateTimestamp log entry property

The UpdateTimestamp property says when an event log property was last
updated. On log creation, this field is initialized with the time that
the log was created.

The only other time a log entry property can change is when the Resolved
property changes, so also added support there to update the new
UpdateTimestamp property.

While technically every property of the Entry interface is writeable,
there is no use case nor code for changing those in the field, so
UpdateTimestamp does not support those.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I9b1360b9c5424e130947045cee7b64ede6264829

show more ...

add .clang-format

Change-Id: I2c36b7886a25d0b235693b0776019d29608e1d52
Signed-off-by: Patrick Venture <venture@google.com>

Persist changes to 'Resolved' property

When an error is marked resolved, serialize and persist the changed
'Resolved' property.

Change-Id: I922af84cbb826e1e43a0f0c99740868222ccb1fe
Signed-off-by: D

Persist changes to 'Resolved' property

When an error is marked resolved, serialize and persist the changed
'Resolved' property.

Change-Id: I922af84cbb826e1e43a0f0c99740868222ccb1fe
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

entry: implement xyz.openbmc_project.Object.Delete

Implement xyz.openbmc_project.Object.Delete to delete an entry object.

Resolves openbmc/openbmc#1327.

Change-Id: I265c26fb9434d0d4cb066fbfa857297

entry: implement xyz.openbmc_project.Object.Delete

Implement xyz.openbmc_project.Object.Delete to delete an entry object.

Resolves openbmc/openbmc#1327.

Change-Id: I265c26fb9434d0d4cb066fbfa85729782318bd8f
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

Entry: Setup constructor

Persist the log manager dbus bus and create a
vector of Entry instances to store the Entry
dbus objects as they get created.

Change-Id: I4add43c4ce6795b6ec6c041e41cd7455d34

Entry: Setup constructor

Persist the log manager dbus bus and create a
vector of Entry instances to store the Entry
dbus objects as they get created.

Change-Id: I4add43c4ce6795b6ec6c041e41cd7455d34b3b6b
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

logging: Create Entry dbus interface

Implement the generated code to create an error/event
entry dbus object.

Change-Id: I881636fe3e8de680d9a15fff1fe933d5e22eed06
Signed-off-by: Adriana Kobylak <an

logging: Create Entry dbus interface

Implement the generated code to create an error/event
entry dbus object.

Change-Id: I881636fe3e8de680d9a15fff1fe933d5e22eed06
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...