| #
b6779846 |
| 07-Oct-2022 |
Jayashree Dhanapal <jayashree-d@hcl.com> |
Create a new Dbus interface for LED
A new Dbus API method is created in the phosphor-led-sysfs repository
under xyz.openbmc_project.Led.Sysfs.Internal interface name to add or
remove the LED, which
Create a new Dbus interface for LED
A new Dbus API method is created in the phosphor-led-sysfs repository
under xyz.openbmc_project.Led.Sysfs.Internal interface name to add or
remove the LED, which will be coming from each udev LED event to
create the LED dbus path.
xyz.openbmc_project.Led.Sysfs.Internal interface
.AddLED method
.RemoveLED method
This Dbus API method is added to support the multihost physical
LEDs design.
https://gerrit.openbmc.org/c/openbmc/docs/+/55230
Also support a executable for LED DBUS API method
Added a new executable for LED DBUS API method to communicate
between udev and application.
Executable will call Dbus API method to pass LED name as argument from
udev, after the primary service started.
Tested : Tested the dbus method is invoked for each LED udev event
in Facebook YosemiteV2 platform.
Signed-off-by: Jayashree Dhanapal <jayashree-d@hcl.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I3fa6c3caa130b2b71ebc9fe8d69541c029f516ab
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
show more ...
|
| #
e48bf95d |
| 17-Aug-2022 |
Jayashree Dhanapal <jayashree-d@hcl.com> |
controller: Heap-allocate LEDs
Do this in preparation for migrating to a single instance of the daemon
whose LED inventory is updated via DBus where the update is triggered by
udev.
Splitting out t
controller: Heap-allocate LEDs
Do this in preparation for migrating to a single instance of the daemon
whose LED inventory is updated via DBus where the update is triggered by
udev.
Splitting out this work reduces the review complexity of the patch that
rewrites the internals of the daemon.
Signed-off-by: Jayashree Dhanapal <jayashree-d@hcl.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I50e58126413514f7a64153f425629142fa5af6d4
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
show more ...
|
| #
eaa1c89f |
| 03-Aug-2023 |
George Liu <liuxiwei@inspur.com> |
Replace Argument class with CLI11
CLI11 is one of the most commonly use argument parser in OpenBMC.
The Argument class will be replaced with CLI11 and the
argument.(h/c)pp file will be removed.
Sig
Replace Argument class with CLI11
CLI11 is one of the most commonly use argument parser in OpenBMC.
The Argument class will be replaced with CLI11 and the
argument.(h/c)pp file will be removed.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ibff60a19d3ff9209ca70889acc9e6aec4a8d4fca
show more ...
|
| #
cb14f2d0 |
| 05-Feb-2023 |
Andrew Jeffery <andrew@aj.id.au> |
controller: Work around clang-tidy issue with boost
See https://bugs.llvm.org/show_bug.cgi?id=41141
```
../subprojects/boost_1_81_0/boost/algorithm/string/detail/classification.hpp:137:25: error: P
controller: Work around clang-tidy issue with boost
See https://bugs.llvm.org/show_bug.cgi?id=41141
```
../subprojects/boost_1_81_0/boost/algorithm/string/detail/classification.hpp:137:25: error: Potential memory leak [clang-analyzer-cplusplus.NewDeleteLeaks,-warnings-as-errors]
if(!use_fixed_storage(m_Size) && m_Storage.m_dynSet!=0)
^
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:100:9: note: Assuming the condition is false
if (options["path"].empty())
^~~~~~~~~~~~~~~~~~~~~~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:100:5: note: Taking false branch
if (options["path"].empty())
^
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:135:5: note: Calling 'getLedDescr'
getLedDescr(name, ledDescr);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:56:5: note: Calling 'split<std::vector<std::basic_string<char>>, const std::basic_string<char> &, boost::algorithm::detail::is_any_ofF<char>>'
boost::split(words, name, boost::is_any_of(":"));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/split.hpp:161:17: note: Calling 'token_finder<boost::algorithm::detail::is_any_ofF<char>>'
::boost::algorithm::token_finder( Pred, eCompress ) );
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/finder.hpp:219:20: note: Calling constructor for 'token_finderF<boost::algorithm::detail::is_any_ofF<char>>'
return detail::token_finderF<PredicateT>( Pred, eCompress );
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/detail/finder.hpp:554:25: note: Calling copy constructor for 'is_any_ofF<char>'
m_Pred(Pred), m_eCompress(eCompress) {}
^~~~~~~~~~~~
../subprojects/boost_1_81_0/boost/algorithm/string/detail/classification.hpp:116:21: note: Taking false branch
if(use_fixed_storage(m_Size))
^
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/detail/classification.hpp:125:44: note: Memory is allocated
m_Storage.m_dynSet=new set_value_type[m_Size];
^~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/detail/finder.hpp:554:25: note: Returning from copy constructor for 'is_any_ofF<char>'
m_Pred(Pred), m_eCompress(eCompress) {}
^~~~~~~~~~~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/finder.hpp:219:20: note: Returning from constructor for 'token_finderF<boost::algorithm::detail::is_any_ofF<char>>'
return detail::token_finderF<PredicateT>( Pred, eCompress );
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/split.hpp:161:17: note: Returned allocated memory
::boost::algorithm::token_finder( Pred, eCompress ) );
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/split.hpp:161:51: note: Calling '~is_any_ofF'
::boost::algorithm::token_finder( Pred, eCompress ) );
^
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/detail/classification.hpp:137:25: note: Potential memory leak
if(!use_fixed_storage(m_Size) && m_Storage.m_dynSet!=0)
^
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/detail/classification.hpp:141:17: error: Potential memory leak [clang-an
alyzer-cplusplus.NewDeleteLeaks,-warnings-as-errors]
}
^
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:100:9: note: Assuming the condition is false
if (options["path"].empty())
^~~~~~~~~~~~~~~~~~~~~~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:100:5: note: Taking false branch
if (options["path"].empty())
^
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:135:5: note: Calling 'getLedDescr'
getLedDescr(name, ledDescr);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:56:5: note: Calling 'split<std::vector<std::basic_string<char>>, const std::basic_string<char> &, boost::algorithm::detail::is_any_ofF<char>>'
boost::split(words, name, boost::is_any_of(":"));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/split.hpp:161:17: note: Calling 'token_finder<boost::algorithm::detail::is_any_ofF<char>>'
::boost::algorithm::token_finder( Pred, eCompress ) );
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/finder.hpp:219:55: note: Calling copy constructor for 'is_any_ofF<char>'
return detail::token_finderF<PredicateT>( Pred, eCompress );
^~~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/detail/classification.hpp:116:21: note: Taking false branch
if(use_fixed_storage(m_Size))
^
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/detail/classification.hpp:125:44: note: Memory is allocated
m_Storage.m_dynSet=new set_value_type[m_Size];
^~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/finder.hpp:219:55: note: Returning from copy constructor for 'is_any_ofF<char>'
return detail::token_finderF<PredicateT>( Pred, eCompress );
^~~~
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/finder.hpp:219:55: note: Calling '~is_any_ofF'
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/detail/classification.hpp:137:51: note: Left side of '&&' is false
if(!use_fixed_storage(m_Size) && m_Storage.m_dynSet!=0)
^
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../subprojects/boost_1_81_0/boost/algorithm/string/detail/classification.hpp:141:17: note: Potential memory leak
}
^
138378 warnings generated.
```
Change-Id: Ie7e36805f91971f6057ea1e6e143fcf4dffcac65
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
| #
b754cf02 |
| 05-Feb-2023 |
Andrew Jeffery <andrew@aj.id.au> |
controller: Fix bugprone-unused-raii
```
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:143:5: error: object destroyed immediately after creation; did you mean to name the objec
controller: Fix bugprone-unused-raii
```
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:143:5: error: object destroyed immediately after creation; did you mean to name the object? [bugprone-unused-raii,-warnings-as-errors]
sdbusplus::server::manager_t(bus, objPath.c_str());
^
give_me_a_name
```
Change-Id: I4225f71874dbabfc315c4ba5d252d0d075868a68
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
| #
444ee36b |
| 05-Feb-2023 |
Andrew Jeffery <andrew@aj.id.au> |
controller: Fix performance-move-const-arg
```
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:97:17: error: std::move of the const expression has no effect; remove std::move() [
controller: Fix performance-move-const-arg
```
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:97:17: error: std::move of the const expression has no effect; remove std::move() [performance-move-const-arg,-warnings-as-errors]
auto path = std::move((options)["path"]);
^~~~~~~~~~ ~
```
Change-Id: I5a26c0b9fa7fcd3d07a2495eeeb5cd0a1e089ceb
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
| #
e2dc00a6 |
| 05-Feb-2023 |
Andrew Jeffery <andrew@aj.id.au> |
controller: Fix readability-identifier-naming
```
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:85:27: error: invalid case style for variable 'BUSNAME' [readability-identifier-
controller: Fix readability-identifier-naming
```
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:85:27: error: invalid case style for variable 'BUSNAME' [readability-identifier-naming,-warnings-as-errors]
static constexpr auto BUSNAME = "xyz.openbmc_project.LED.Controller";
^~~~~~~
busname
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:86:27: error: invalid case style for variable 'OBJPATH' [readability-identifier-naming,-warnings-as-errors]
static constexpr auto OBJPATH = "/xyz/openbmc_project/led/physical";
^~~~~~~
objpath
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:87:27: error: invalid case style for variable 'DEVPATH' [readability-identifier-naming,-warnings-as-errors]
static constexpr auto DEVPATH = "/sys/class/leds/";
^~~~~~~
devpath
```
Change-Id: I0ea55045d60704ff5744481fdb907cdebda80368
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
| #
20aef9a3 |
| 05-Feb-2023 |
Andrew Jeffery <andrew@aj.id.au> |
controller: Fix readability-braces-around-statements
```
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:75:36: error: statement should be inside braces [readability-braces-aroun
controller: Fix readability-braces-around-statements
```
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:75:36: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
if (!ledDescr.function.empty())
^
{
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:77:33: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
if (!ledDescr.color.empty())
^
{
```
Change-Id: I2f1a487638786885ff4ebd9aba26e22c1b943fe1
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
| #
bd0b9e7c |
| 05-Feb-2023 |
Andrew Jeffery <andrew@aj.id.au> |
controller: Fix readability-identifier-naming
```
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:27:13: error: invalid case style for function 'ExitWithError' [readability-ident
controller: Fix readability-identifier-naming
```
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:27:13: error: invalid case style for function 'ExitWithError' [readability-identifier-naming,-warnings-as-errors]
static void ExitWithError(const char* err, char** argv)
^~~~~~~~~~~~~
exitWithError
```
Change-Id: I9fc779fcec82c00cb2168e07703a51548990f066
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
| #
f9e6cd3a |
| 02-Feb-2023 |
Andrew Jeffery <andrew@aj.id.au> |
argument: Fix clang-tidy readability-redundant-string-init
```
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../argument.cpp:30:35: error: redundant string initialization [readability-redundant-
argument: Fix clang-tidy readability-redundant-string-init
```
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../argument.cpp:30:35: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
const std::string ArgumentParser::empty_string = "";
^~~~~~~~~~~~~~~~~
empty_string
```
Change-Id: I6b802d85b6f0ac0911e3ce85f086e8df29239f37
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
| #
ff3d538b |
| 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I44db990b2509a639c17765e7db10314ed858bd4d
show more ...
|
| #
429750a0 |
| 18-May-2021 |
George Liu <liuxiwei@inspur.com> |
Remove config.h
The intent behind this commit is to define `BUSNAME`, `OBJPATH` and
`DEVPATH` variables in the main method, because they do not need and
absolutely have no reason to use autotools to
Remove config.h
The intent behind this commit is to define `BUSNAME`, `OBJPATH` and
`DEVPATH` variables in the main method, because they do not need and
absolutely have no reason to use autotools to configure them,
so remove config.h.
Tested: built phsphor-led-sysfs successfully and worked.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ic8a7309dc58694fef94a2a7a6b8d4e53f92df5db
show more ...
|
| #
45eba6fc |
| 18-May-2021 |
George Liu <liuxiwei@inspur.com> |
Replace std::experimental::filesystem with std::filesystem
Above c++17, std::filesystem is already supported, so replace
std::experimental::filesystem with std::filesystem.
Signed-off-by: George Li
Replace std::experimental::filesystem with std::filesystem
Above c++17, std::filesystem is already supported, so replace
std::experimental::filesystem with std::filesystem.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I864bd80905e9b61428d17b20a91b3482198d20bc
show more ...
|
| #
61b90636 |
| 21-Jun-2020 |
George Liu <liuxiwei@inspur.com> |
clang-format: update to latest from docs repo
Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, update the C++ standard to Latest.
https://github.com/
clang-format: update to latest from docs repo
Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, update the C++ standard to Latest.
https://github.com/llvm/llvm-project/commit/e5032567903de19962333c4bf7d2edceaf4f9824#diff-b49a097415dff2837d9626d422c58ba8R82
https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Id5684236b64867ba631a3a00dadababe2c36db16
show more ...
|
| #
97ddb723 |
| 16-Apr-2019 |
Alexander Soldatov <a.soldatov@yadro.com> |
Add ability to set LED colors in DBus
phosphor-led-sysfs parses sysfs LED node names
in the form of "devicename:colour:function" as
described in
https://github.com/torvalds/linux/blob/master/Docume
Add ability to set LED colors in DBus
phosphor-led-sysfs parses sysfs LED node names
in the form of "devicename:colour:function" as
described in
https://github.com/torvalds/linux/blob/master/Documentation/leds/leds-class.txt#L46
and then converts the "colour" part into the proper
value of the DBus 'Color' property using the
xyz.openbmc_project.Led.Physical.Palette interface.
In order for the led nodes to have their Color set,
the corresponding led nodes in devicetree must have
correct 'label' properties, e.g.:
leds {
compatible = "gpio-leds";
heartbeat {
label = "bmc:green:hearbeat";
gpios = <&gpio ASPEED_GPIO(R, 4) GPIO_ACTIVE_LOW>;
};
power_red {
label = "system:red:power";
gpios = <&gpio ASPEED_GPIO(N, 1) GPIO_ACTIVE_LOW>;
};
}
Change-Id: I094f0e434bdd262995752576a3c792ccd5dbb3e2
Signed-off-by: Alexander Soldatov <a.soldatov@yadro.com>
Signed-off-by: Alexander Amelkin <a.amelkin@yadro.com>
show more ...
|
| #
42e02d34 |
| 23-May-2018 |
Andrew Jeffery <andrew@aj.id.au> |
sysfs: Integrate class into Physical and tests
Change-Id: I7d5ad19df5ef1258a4e669ea3243b7411f371d9c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
| #
cd3b05e0 |
| 23-May-2018 |
Andrew Jeffery <andrew@aj.id.au> |
controller: Avoid pessimistic moves
clang-6.0 reports that some of the moves prevent further optimisations, so
remove them.
$ make
make all-am
make[1]: Entering directory '/home/andrew/src/openbmc
controller: Avoid pessimistic moves
clang-6.0 reports that some of the moves prevent further optimisations, so
remove them.
$ make
make all-am
make[1]: Entering directory '/home/andrew/src/openbmc/phosphor-led-sysfs'
CXX controller.o
controller.cpp:60:12: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
path = std::move(DEVPATH + name);
^
controller.cpp:60:12: note: remove std::move call here
path = std::move(DEVPATH + name);
^~~~~~~~~~ ~
controller.cpp:75:16: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
auto bus = std::move(sdbusplus::bus::new_default());
^
controller.cpp:75:16: note: remove std::move call here
auto bus = std::move(sdbusplus::bus::new_default());
^~~~~~~~~~ ~
2 errors generated.
Makefile:761: recipe for target 'controller.o' failed
make[1]: *** [controller.o] Error 1
make[1]: Leaving directory '/home/andrew/src/openbmc/phosphor-led-sysfs'
Makefile:617: recipe for target 'all' failed
make: *** [all] Error 2
Change-Id: I3da6415def4ab183cc9f6c5e176e8bb3666cf1b7
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
| #
c41bf5b7 |
| 25-May-2018 |
Andrew Jeffery <andrew@aj.id.au> |
Add OpenBMC C++ clang-format file and format code
Change-Id: Ib3a388bf5392159440682265b577fba023c3c3aa
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
| #
f9de54be |
| 25-May-2017 |
Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com> |
Work-around: Extract led name from device path
udev rule for leds subsystem in Witherspoon launches a systemd
service file with /sys/class/leds/$name. If the path is
sys-class-leds-rear-fault, syste
Work-around: Extract led name from device path
udev rule for leds subsystem in Witherspoon launches a systemd
service file with /sys/class/leds/$name. If the path is
sys-class-leds-rear-fault, systemd service file
interprets it as /sys/class/leds/rear/fault.
However, what is really needed by the service file is
/sys/class/leds/rear-fault.
This is a limitation in current systemd with template argument
containing hyphen.
Short term solution is to extract $name from path
and convert "/" to "-". It would then become:
/sys/class/leds/rear-fault and hence will work.
Refer: systemd/systemd#5072
Change-Id: I0acc11d039650857005ba75810e3ef6bcc4a3934
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
show more ...
|
| #
413fd348 |
| 30-Mar-2017 |
Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com> |
LEDS: Handle physical LED names containing hyphen
It is possible that LED names can contain hyphen(s) in them making it
inappropriate for announcing the name on dbus. Fix would be to
convert the hyp
LEDS: Handle physical LED names containing hyphen
It is possible that LED names can contain hyphen(s) in them making it
inappropriate for announcing the name on dbus. Fix would be to
convert the hyphen to underscores just for announcing on dbus
while using the actual name for rest everything.
Fixes openbmc/openbmc#802
Change-Id: Ia916786e9abf948970b36242f57c27aa90d4a962
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
show more ...
|
| #
e089173f |
| 10-Mar-2017 |
Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com> |
Link to dbus interfaces library for using generated code
Change-Id: Id1c45d8c66deb499a92bfd94bc271f378245da34
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
| #
75b5510f |
| 30-Nov-2016 |
Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com> |
Add overriding methods for the base interface definition
Defines the functions that override the default setter for
the led state property.
Change-Id: Ic3a8d43cc783003c43f53df8f7e90d7fc4d6715a
Sign
Add overriding methods for the base interface definition
Defines the functions that override the default setter for
the led state property.
Change-Id: Ic3a8d43cc783003c43f53df8f7e90d7fc4d6715a
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
show more ...
|
| #
bda97eb1 |
| 30-Nov-2016 |
Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com> |
Use generated bindings for physical led controller
Extends the generated interface and provides skeleton implementation of led
controller.
Change-Id: I13485f39755213b8a7324e526d6335f3ee0a2b67
Signe
Use generated bindings for physical led controller
Extends the generated interface and provides skeleton implementation of led
controller.
Change-Id: I13485f39755213b8a7324e526d6335f3ee0a2b67
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
show more ...
|
| #
835571eb |
| 29-Nov-2016 |
Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com> |
Add initial files for physical LED controller
This daemon uses sysfs entry for a particular LED and then triggers
necessary action. Name and Path of the LED is needed as command line
options to make
Add initial files for physical LED controller
This daemon uses sysfs entry for a particular LED and then triggers
necessary action. Name and Path of the LED is needed as command line
options to make sure this is genreric implementation.
Change-Id: I3d52f1491fcb6ae8119b399a4d2c6770a3f5db30
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
show more ...
|