meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I11f0b9ec49d8a0a7f180b379d9d28f45e6cc3799
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

yaml: add back support for empty LED groups

The old script had support for empty LED groups. I tried removing the
empty "bmc_booted" LED group, but that caused systemd to never "finish"
booting (sys

yaml: add back support for empty LED groups

The old script had support for empty LED groups. I tried removing the
empty "bmc_booted" LED group, but that caused systemd to never "finish"
booting (systemctl is-system-running returned "starting" because it was
blocked waiting for the "bmc_booted" LED service to start).

This adds back support for empty LED groups.

Tested:
Confirmed that with an empty "bmc_booted" LED group, the firmware will
build successfully and systemd doesn't get blocked waiting for the
"bmc_booted" LED service.

Change-Id: I11d7c50696cd50d989a4eaef28f8e5c43473ce6e
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

config: error on invalid configuration

Since the default led priority is no longer 'Blink', the priority now
has to be explicitly defined when using either group priority or led
priority.

If a conf

config: error on invalid configuration

Since the default led priority is no longer 'Blink', the priority now
has to be explicitly defined when using either group priority or led
priority.

If a configuration does not define the priority, the configuration is
invalid and in the yaml case, phosphor-led-manager should fail to build,
in the json case, the process should exit due to the configuration
error.

The config validation has been extracted into it's own file and made
separate from json config parsing.

So every config will go through the same validation even if its been
created via yaml.

Change-Id: Ifda65942b0768d6c0d3b25076f7a1236b46b3d9f
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

test: unit test parse_led.py

Providing a test for parse_led.py since it was refactored.

Testing that various keys in the yaml are available in the cpp literal.

Change-Id: I94d03eb2a4d2bd3129971c4a

test: unit test parse_led.py

Providing a test for parse_led.py since it was refactored.

Testing that various keys in the yaml are available in the cpp literal.

Change-Id: I94d03eb2a4d2bd3129971c4acbe75edd74449ed4
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

test: group priority

Test for the group priority feature. When configuring different groups,
they should overwrite each other based on their priority.

The examples are based on [1]

[1] OCP Panel I

test: group priority

Test for the group priority feature. When configuring different groups,
they should overwrite each other based on their priority.

The examples are based on [1]

[1] OCP Panel Indicator Specification_rev1.0.pdf

Change-Id: I91b96d9dc9307afb1a2abbde6278862045a28355
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I4db060ea85cfae7be96693ec04a09829767351a1
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Persistence the led group asserted value by default

Currently, only IBM's P10 machine will persist the Asserted attribute
value of ledGroup by default. But for other systems, most do not need
to per

Persistence the led group asserted value by default

Currently, only IBM's P10 machine will persist the Asserted attribute
value of ledGroup by default. But for other systems, most do not need
to perform persistence actions.

The intent behind this commit is to add a switch to control the
persistence function, and it is enabled by default in CI and disabled
by default in Yocto.

Tested: Regardless of whether `persistent-led-asserted` is enabled or
disabled, the ledmanager process works fine.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I75b59a12dde417a9ccadaf25b2af07fc33186a01

show more ...

manager: move code to subdirectory

The root has become pretty cluttered. Move code for the primary
manager application to a subdirectory.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change

manager: move code to subdirectory

The root has become pretty cluttered. Move code for the primary
manager application to a subdirectory.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8503cf08c72750c88a5ce94a4d94671d6b59aafb

show more ...

Fix utest-led-json.cpp should not depend on use-json

- The intent behind this commit is to fix the utest-led-json.cpp
should not depend on use-json, because use-json is for production
code and i

Fix utest-led-json.cpp should not depend on use-json

- The intent behind this commit is to fix the utest-led-json.cpp
should not depend on use-json, because use-json is for production
code and it should not affect test code.

Tested: built phosphor-led-manager successfully and Unit Test passes.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia19b68d0167fd8c690ad1b15d29c266e9e77d90b

show more ...

build: Add wrapfiles for dependencies

- Update meson.build and add wrapfiles so that all dependencies are
handled as subprojects.

- This allows builds completely outside of bitbake or an SDK.
r

build: Add wrapfiles for dependencies

- Update meson.build and add wrapfiles so that all dependencies are
handled as subprojects.

- This allows builds completely outside of bitbake or an SDK.
refer: https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-virtual-sensor/+/42349

Tested: built ledManager repo successfully using `meson build`.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I35db603d4aa9c2eee41c3cfb27eba6953950fe44

show more ...

Add meson build

This commit is to add meson build.
And later, we will remove Autotools and replace it with meson build.

In addition, fixed Layout::LedAction construct parameter error in test
file.

Add meson build

This commit is to add meson build.
And later, we will remove Autotools and replace it with meson build.

In addition, fixed Layout::LedAction construct parameter error in test
file.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I58c9a2c9de928db288e77ca2d6aa807d36e70144

show more ...