clang-tidy: Enable readability-simplify-boolean-expr check

This checks for boolean expressions involving boolean constants
and simplifies them to use the appropriate boolean expression
directly.

Si

clang-tidy: Enable readability-simplify-boolean-expr check

This checks for boolean expressions involving boolean constants
and simplifies them to use the appropriate boolean expression
directly.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: If2316dc52cbd280971f0333ee805b11e1b99d27f

show more ...

clang-tidy: Enable readability-avoid-const-params-in-decls check

Checks whether a function declaration has parameters that are top
level const.
const values in declarations do not affect the signatu

clang-tidy: Enable readability-avoid-const-params-in-decls check

Checks whether a function declaration has parameters that are top
level const.
const values in declarations do not affect the signature of a
function, so they should not be put there.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ic4c2fc0f4ce0ce03fd6621d1f8c928890cf5da88

show more ...

clang-tidy: Enable readability-redundant-member-init check

Finds member initializations that are unnecessary because the same
default constructor would be called if they were not present.

Signed-of

clang-tidy: Enable readability-redundant-member-init check

Finds member initializations that are unnecessary because the same
default constructor would be called if they were not present.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia112636b43360f6a4e14c0a7a80a2635754325c7

show more ...

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers readability-static-accessed-through
-instance check as we are trying to access a static member
function through an instance.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I6efe76666f75fb4f65621796466d9347cea25d01

show more ...

config: implement group priority

Enable group priority.

Change-Id: I1777906e60d07420835ede904785071ee308c307
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

manager: refactor setGroupState

setGroupState used to rely on std::set operations with non-obvious
workings involving std::inserter with custom comparators.

However the logic required seem to be si

manager: refactor setGroupState

setGroupState used to rely on std::set operations with non-obvious
workings involving std::inserter with custom comparators.

However the logic required seem to be simpler, therefore replacing the
set-based implementation with a map-based one.

The current state of the leds is now stored in a map, replacing the
previous two class members required with only one.

Change-Id: I3a812da4e5632c8258c45511f05ea1966b2f7208
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I47f3c815913ae34be19ce0d823fa233ed698d1a0
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

manager: add timer for failed LED actions

The current manager performs LED ActionSet one-time only when LED group
asserted property changes, so if the physical LED object path is not
ready when it i

manager: add timer for failed LED actions

The current manager performs LED ActionSet one-time only when LED group
asserted property changes, so if the physical LED object path is not
ready when it is set, the LED will be in an error state. Most of time
this error occurs at BMC booting due phospohr-led-manager starts before
LED driver is probed.

In order to correct LED state after physical LED is ready, add a timer
to repeatedly setting failed LED after 1 second.

Change-Id: I0bb46189c79c961cdaa501a7386346c2bb351252
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

Use the lower camel case of the C++ standard

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ied901f0cc7cc6606e199dad0e31a35f838c32ab9

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I223d58649a21565678bd7ef78d955b30d3fd6d84

show more ...

led-layout: use common types everywhere

Rather than scattered map and set typedefs, centralize the two common
structures into 'ledlayout.hpp': ActionSet, GroupMap. Use them
everywhere where previou

led-layout: use common types everywhere

Rather than scattered map and set typedefs, centralize the two common
structures into 'ledlayout.hpp': ActionSet, GroupMap. Use them
everywhere where previous raw maps and sets were used.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0ed5203146a6486a49caf4000f545ded0088dc15

show more ...

switch map to unordered_map

Generally, unordered_maps should be preferred over map because they have
faster access times (O(1)) and tend to allocate less dynamic memory. We
do not rely on ordered i

switch map to unordered_map

Generally, unordered_maps should be preferred over map because they have
faster access times (O(1)) and tend to allocate less dynamic memory. We
do not rely on ordered iteration in any current use of maps, so it is
safe to do a full replace.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ieaa28ac7f70f9913d13d25142fea9861d49bb23f

show more ...

manager: move code to subdirectory

The root has become pretty cluttered. Move code for the primary
manager application to a subdirectory.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change

manager: move code to subdirectory

The root has become pretty cluttered. Move code for the primary
manager application to a subdirectory.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8503cf08c72750c88a5ce94a4d94671d6b59aafb

show more ...