clang-tidy: Enable readability-braces-around-statements check

This checks that bodies of if statements and loops
(for, do while, and while) are inside braces.

Signed-off-by: George Liu <liuxiwei@ie

clang-tidy: Enable readability-braces-around-statements check

This checks that bodies of if statements and loops
(for, do while, and while) are inside braces.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I9b79aaa3d3299d42ae245afe4b9488ae58e2c28d

show more ...

clang-tidy: Enable readability-qualified-auto check

This check aims to improve code readability by suggesting the use
of const auto * instead of auto for variables that are pointers
or iterators. Th

clang-tidy: Enable readability-qualified-auto check

This check aims to improve code readability by suggesting the use
of const auto * instead of auto for variables that are pointers
or iterators. This helps clarify the const-ness of the pointed-to
object or container elements.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia132b6dd8ae4e3c16809326f6055396666abc95a

show more ...

clang-tidy: Enable readability-implicit-bool-conversion check

This check can be used to find implicit conversions between
built-in types and booleans.
the following conversion types are checked:
- i

clang-tidy: Enable readability-implicit-bool-conversion check

This check can be used to find implicit conversions between
built-in types and booleans.
the following conversion types are checked:
- integer expression/literal to boolean
- floating expression/literal to boolean
- pointer/pointer to member/nullptr/NULL to boolean
- boolean expression/literal to integer
- boolean expression/literal to floating

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I3f4bc8902e255d1c85ec57f47d9532ee7326a442

show more ...

clang-tidy: Enable readability-avoid-const-params-in-decls check

Checks whether a function declaration has parameters that are top
level const.
const values in declarations do not affect the signatu

clang-tidy: Enable readability-avoid-const-params-in-decls check

Checks whether a function declaration has parameters that are top
level const.
const values in declarations do not affect the signature of a
function, so they should not be put there.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ic4c2fc0f4ce0ce03fd6621d1f8c928890cf5da88

show more ...

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers readability-static-accessed-through
-instance check as we are trying to access a static member
function through an instance.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I6efe76666f75fb4f65621796466d9347cea25d01

show more ...

clang-tidy: Enable performance-for-range-copy check

The check is only applied to loop variables of types that are
expensive to copy which means they are not trivially copyable or have
a non-trivial

clang-tidy: Enable performance-for-range-copy check

The check is only applied to loop variables of types that are
expensive to copy which means they are not trivially copyable or have
a non-trivial copy constructor or destructor.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I9643e396c6bd95bb9bef9037f018fbaf20d506d7

show more ...

manager: led priority is optional

The default priority was "Blink" but now the priority is optional.

This helps to implement group priority.
So if someone wants to use group priority they can do so

manager: led priority is optional

The default priority was "Blink" but now the priority is optional.

This helps to implement group priority.
So if someone wants to use group priority they can do so, without the
default led priority getting in the way.

The led priority can still be assigned as "Blink" explicitly if needed.

Change-Id: I9336487bcc2edc0b3308ee76eb5330b8222b7f25
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

config: implement group priority

Enable group priority.

Change-Id: I1777906e60d07420835ede904785071ee308c307
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

manager: refactor setGroupState

setGroupState used to rely on std::set operations with non-obvious
workings involving std::inserter with custom comparators.

However the logic required seem to be si

manager: refactor setGroupState

setGroupState used to rely on std::set operations with non-obvious
workings involving std::inserter with custom comparators.

However the logic required seem to be simpler, therefore replacing the
set-based implementation with a map-based one.

The current state of the leds is now stored in a map, replacing the
previous two class members required with only one.

Change-Id: I3a812da4e5632c8258c45511f05ea1966b2f7208
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

readability: remove redundant check before iterate

There were some patterns like

if (collection.size()) {
for(auto& it : collection){
//...
}
}

which is redundant.

Change-Id: I10c

readability: remove redundant check before iterate

There were some patterns like

if (collection.size()) {
for(auto& it : collection){
//...
}
}

which is redundant.

Change-Id: I10c0ad1ecd0aa2e96b456dcf9c5ea4d8995ae016
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

manager: add timer for failed LED actions

The current manager performs LED ActionSet one-time only when LED group
asserted property changes, so if the physical LED object path is not
ready when it i

manager: add timer for failed LED actions

The current manager performs LED ActionSet one-time only when LED group
asserted property changes, so if the physical LED object path is not
ready when it is set, the LED will be in an error state. Most of time
this error occurs at BMC booting due phospohr-led-manager starts before
LED driver is probed.

In order to correct LED state after physical LED is ready, add a timer
to repeatedly setting failed LED after 1 second.

Change-Id: I0bb46189c79c961cdaa501a7386346c2bb351252
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

Replace std::exception_t with sdbusplus::exception

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I619957dfff03ee8237b1e6356a3da067ea5c2f8f

Use the lower camel case of the C++ standard

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ied901f0cc7cc6606e199dad0e31a35f838c32ab9

led-layout: use common types everywhere

Rather than scattered map and set typedefs, centralize the two common
structures into 'ledlayout.hpp': ActionSet, GroupMap. Use them
everywhere where previou

led-layout: use common types everywhere

Rather than scattered map and set typedefs, centralize the two common
structures into 'ledlayout.hpp': ActionSet, GroupMap. Use them
everywhere where previous raw maps and sets were used.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0ed5203146a6486a49caf4000f545ded0088dc15

show more ...

manager: move code to subdirectory

The root has become pretty cluttered. Move code for the primary
manager application to a subdirectory.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change

manager: move code to subdirectory

The root has become pretty cluttered. Move code for the primary
manager application to a subdirectory.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8503cf08c72750c88a5ce94a4d94671d6b59aafb

show more ...