clang-tidy: Enable readability-static-accessed-through-instance check

Checks for member expressions that access static members through
instances, and replaces them with uses of the appropriate
quali

clang-tidy: Enable readability-static-accessed-through-instance check

Checks for member expressions that access static members through
instances, and replaces them with uses of the appropriate
qualified-id.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I24de8ac8897de839594c6c71319febd0209bbc2e

show more ...

clang-tidy: Enable modernize-avoid-bind check

The check finds uses of std::bind and boost::bind and replaces them
with lambdas.

Lambdas will use value-capture unless reference capture is explicitly

clang-tidy: Enable modernize-avoid-bind check

The check finds uses of std::bind and boost::bind and replaces them
with lambdas.

Lambdas will use value-capture unless reference capture is explicitly
requested with std::ref or boost::ref.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I4491650a46eaab1588474b26efc622e89232ef02

show more ...

manager: include config-validator.hpp always

There was an issue with

phosphor::led::validateConfigV1(systemLedMap);

being not included when using meson option

use-json

as false (yaml config), si

manager: include config-validator.hpp always

There was an issue with

phosphor::led::validateConfigV1(systemLedMap);

being not included when using meson option

use-json

as false (yaml config), since it was transitively included
by manager/json-parser.hpp

Directly including it should fix the issue.

Change-Id: I056cd524ff255e4409844f74bd7755ab5ee857d6
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

config: error on invalid configuration

Since the default led priority is no longer 'Blink', the priority now
has to be explicitly defined when using either group priority or led
priority.

If a conf

config: error on invalid configuration

Since the default led priority is no longer 'Blink', the priority now
has to be explicitly defined when using either group priority or led
priority.

If a configuration does not define the priority, the configuration is
invalid and in the yaml case, phosphor-led-manager should fail to build,
in the json case, the process should exit due to the configuration
error.

The config validation has been extracted into it's own file and made
separate from json config parsing.

So every config will go through the same validation even if its been
created via yaml.

Change-Id: Ifda65942b0768d6c0d3b25076f7a1236b46b3d9f
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I47f3c815913ae34be19ce0d823fa233ed698d1a0
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I3a5360efb5b6a71d5eabb557accf939cd6abc864
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Reset lamps after reboot

In case lamp test has been triggered and reboot takes place,
even after reboot the lamps are found to be in the on state.

The commit switches off the lamps in case such sit

Reset lamps after reboot

In case lamp test has been triggered and reboot takes place,
even after reboot the lamps are found to be in the on state.

The commit switches off the lamps in case such situation is
found and restores the LEDs to the state in which they were
before lamp test was triggered.

Change-Id: I3d199b7066751e89bd6faffc38af3e36877ca003
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Persistence the led group asserted value by default

Currently, only IBM's P10 machine will persist the Asserted attribute
value of ledGroup by default. But for other systems, most do not need
to per

Persistence the led group asserted value by default

Currently, only IBM's P10 machine will persist the Asserted attribute
value of ledGroup by default. But for other systems, most do not need
to perform persistence actions.

The intent behind this commit is to add a switch to control the
persistence function, and it is enabled by default in CI and disabled
by default in Yocto.

Tested: Regardless of whether `persistent-led-asserted` is enabled or
disabled, the ledmanager process works fine.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I75b59a12dde417a9ccadaf25b2af07fc33186a01

show more ...

manager: add timer for failed LED actions

The current manager performs LED ActionSet one-time only when LED group
asserted property changes, so if the physical LED object path is not
ready when it i

manager: add timer for failed LED actions

The current manager performs LED ActionSet one-time only when LED group
asserted property changes, so if the physical LED object path is not
ready when it is set, the LED will be in an error state. Most of time
this error occurs at BMC booting due phospohr-led-manager starts before
LED driver is probed.

In order to correct LED state after physical LED is ready, add a timer
to repeatedly setting failed LED after 1 second.

Change-Id: I0bb46189c79c961cdaa501a7386346c2bb351252
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

Remove declared ledGroups variables from json-parser.hpp

Since not all companies use ledManager to enable `use-json` by
default, the declaration of ledGroups should not be defined in
the json-parser

Remove declared ledGroups variables from json-parser.hpp

Since not all companies use ledManager to enable `use-json` by
default, the declaration of ledGroups should not be defined in
the json-parser.hpp file.
Here we use hard-coded way to declare ledGroups.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I7def887614b246f74dbd0739d563f01661b1f8f8

show more ...

Remove declared DBus variables from meson

For defined DBus variables (eg: DBus name, DBus object path),
we prefer to define them in the code rather than in the meson file

Signed-off-by: George Liu

Remove declared DBus variables from meson

For defined DBus variables (eg: DBus name, DBus object path),
we prefer to define them in the code rather than in the meson file

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I7c08461e297f4e0da9ae521e0228ed7ff89a4d47

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I918b0a2e9d18c9810ee2940dbe78072754c75a94
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I223d58649a21565678bd7ef78d955b30d3fd6d84

show more ...

led-layout: use common types everywhere

Rather than scattered map and set typedefs, centralize the two common
structures into 'ledlayout.hpp': ActionSet, GroupMap. Use them
everywhere where previou

led-layout: use common types everywhere

Rather than scattered map and set typedefs, centralize the two common
structures into 'ledlayout.hpp': ActionSet, GroupMap. Use them
everywhere where previous raw maps and sets were used.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0ed5203146a6486a49caf4000f545ded0088dc15

show more ...

led-manager: add CLI11 option and config loading

To facilitate localized testing of JSON config loading, add an option
that allows the configuration to be directly passed, rather than try to
determi

led-manager: add CLI11 option and config loading

To facilitate localized testing of JSON config loading, add an option
that allows the configuration to be directly passed, rather than try to
determine it from entity-manager config off dbus.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I80d7051bf312044c68f44bcdb9ac02364f9abac3

show more ...

manager: move code to subdirectory

The root has become pretty cluttered. Move code for the primary
manager application to a subdirectory.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change

manager: move code to subdirectory

The root has become pretty cluttered. Move code for the primary
manager application to a subdirectory.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8503cf08c72750c88a5ce94a4d94671d6b59aafb

show more ...