clang-tidy: Enable modernize-use-override check

This check adds override (introduced in C++11) to overridden
virtual functions and removes virtual from those functions as it
is not required.

Signed

clang-tidy: Enable modernize-use-override check

This check adds override (introduced in C++11) to overridden
virtual functions and removes virtual from those functions as it
is not required.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I7ce6bf641dabf4d325a29a1b641e58beac6885bd

show more ...

clang-tidy: Add cert checks

This check corresponds to the CERT C++ Coding Standard rule.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ie31974d318a7b11a0295455595d7c330676ef45a

Add clang-tidy to phosphor-led-manager

This commit enables clang-tidy and adds few tidy checks.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I3a7b41545fef4c726b56aeab3e4b4000dfcac3

Add clang-tidy to phosphor-led-manager

This commit enables clang-tidy and adds few tidy checks.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I3a7b41545fef4c726b56aeab3e4b4000dfcac32f

show more ...

Resolve issues in lamp test feature

This commit implements the following changes in lamp test

1. Reset lamp test timer on assert to assert case
2. Reject stopping lamp test when there is a request

Resolve issues in lamp test feature

This commit implements the following changes in lamp test

1. Reset lamp test timer on assert to assert case
2. Reject stopping lamp test when there is a request to
deassert lamp test.

Test:
Case 1: Start lamp test (False to True).
Result: 4mins of lamp test execution and Asserted is set back to
false after 4mins.

Case 2: Stop lamp test (False to False).
Result: Lamp test is not performed and Asserted remains false.

Case 3: Stop request when lamp test is still on (True to false)
Result: Stop request not allowed and lamp test continues to execute.
Asserted stays true until the lamp test ends.

Case 4: Retrigger lamp test (True to True).
Result: 4mins timer restarts. Asserted should be back to false after
4mins.

Change-Id: Ib6086f223d5c5ce80b872ed5f35645893ce79cf9
Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>

show more ...

Persistence the led group asserted value by default

Currently, only IBM's P10 machine will persist the Asserted attribute
value of ledGroup by default. But for other systems, most do not need
to per

Persistence the led group asserted value by default

Currently, only IBM's P10 machine will persist the Asserted attribute
value of ledGroup by default. But for other systems, most do not need
to perform persistence actions.

The intent behind this commit is to add a switch to control the
persistence function, and it is enabled by default in CI and disabled
by default in Yocto.

Tested: Regardless of whether `persistent-led-asserted` is enabled or
disabled, the ledmanager process works fine.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I75b59a12dde417a9ccadaf25b2af07fc33186a01

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I223d58649a21565678bd7ef78d955b30d3fd6d84

show more ...

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.

Change-Id: I5fc79b0851bd5901b5b6c8dd24a291825163dbad
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

manager: move code to subdirectory

The root has become pretty cluttered. Move code for the primary
manager application to a subdirectory.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change

manager: move code to subdirectory

The root has become pretty cluttered. Move code for the primary
manager application to a subdirectory.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8503cf08c72750c88a5ce94a4d94671d6b59aafb

show more ...