clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers readability-static-accessed-through
-instance check as we are trying to access a static member
function through an instance.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I6efe76666f75fb4f65621796466d9347cea25d01

show more ...

clang-tidy: Enable modernize-avoid-bind check

The check finds uses of std::bind and boost::bind and replaces them
with lambdas.

Lambdas will use value-capture unless reference capture is explicitly

clang-tidy: Enable modernize-avoid-bind check

The check finds uses of std::bind and boost::bind and replaces them
with lambdas.

Lambdas will use value-capture unless reference capture is explicitly
requested with std::ref or boost::ref.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I4491650a46eaab1588474b26efc622e89232ef02

show more ...

Fix cppcheck warnings

Warning message:
```
/usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:97:16: error: invalid application of 'sizeof' to an incomplete type 'phosphor

Fix cppcheck warnings

Warning message:
```
/usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:97:16: error: invalid application of 'sizeof' to an incomplete type 'phosphor::led::fru::fault::monitor::Remove'
97 | static_assert(sizeof(_Tp)>0,
| ^~~~~~~~~~~
/usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:404:4: note: in instantiation of member function 'std::default_delete<phosphor::led::fru::fault::monitor::Remove>::operator()' requested here
404 | get_deleter()(std::move(__ptr));
| ^
/usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:88:15: note: in instantiation of member function 'std::unique_ptr<phosphor::led::fru::fault::monitor::Remove>::~unique_ptr' requested here
88 | __location->~_Tp();
| ^
/usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:149:12: note: in instantiation of function template specialization 'std::destroy_at<std::unique_ptr<phosphor::led::fru::fault::monitor::Remove>>' requested here
149 | std::destroy_at(__pointer);
| ^
/usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:163:11: note: in instantiation of function template specialization 'std::_Destroy<std::unique_ptr<phosphor::led::fru::fault::monitor::Remove>>' requested here
163 | std::_Destroy(std::__addressof(*__first));
| ^
/usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:193:35: note: in instantiation of function template specialization 'std::_Destroy_aux<false>::__destroy<std::unique_ptr<phosphor::led::fru::fault::monitor::Remove> *>' requested here
193 | return std::_Destroy_aux<false>::__destroy(__first, __last);
| ^
/usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/alloc_traits.h:948:12: note: in instantiation of function template specialization 'std::_Destroy<std::unique_ptr<phosphor::led::fru::fault::monitor::Remove> *>' requested here
948 | std::_Destroy(__first, __last);
| ^
/usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_vector.h:735:7: note: in instantiation of function template specialization 'std::_Destroy<std::unique_ptr<phosphor::led::fru::fault::monitor::Remove> *, std::unique_ptr<phosphor::led::fru::fault::monitor::Remove>>' requested here
735 | std::_Destroy(this->_M_impl._M_start, this->_M_impl._M_finish,
| ^
../../../fault-monitor/fru-fault-monitor.hpp:48:14: note: in instantiation of member function 'std::vector<std::unique_ptr<phosphor::led::fru::fault::monitor::Remove>>::~vector' requested here
48 | explicit Add(sdbusplus::bus_t& bus) :
| ^
../../../fault-monitor/fru-fault-monitor.hpp:28:7: note: forward declaration of 'phosphor::led::fru::fault::monitor::Remove'
28 | class Remove;
| ^
```

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I5c20a0031deff51e6bacccdd81310e95f14e52a0

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I223d58649a21565678bd7ef78d955b30d3fd6d84

show more ...

Fix some warnings by cppcheck

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Icee0abe2e3130aa225db776efdcd47200eb38f8d

clang-format: update to latest from docs repo

Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, udpate the C++ standard to Latest.

https://github.com/

clang-format: update to latest from docs repo

Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, udpate the C++ standard to Latest.

https://github.com/llvm/llvm-project/commit/e5032567903de19962333c4bf7d2edceaf4f9824#diff-b49a097415dff2837d9626d422c58ba8R82
https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Iaac09e3c11ead581114c4b7e45ff863ec56a63f6

show more ...

string: ensure string included when used

Latest upstream yocto appears to have removed a free include of string.
This is causing compile failures for files which do not include it
properly.

Signed-

string: ensure string included when used

Latest upstream yocto appears to have removed a free include of string.
This is causing compile failures for files which do not include it
properly.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I8df4c564af2c8e8294cdcb3e74f9d7cd106d4ec8

show more ...

Add clang-format to repo

Add clang-format to repo.

Change-Id: Ib3f81524b66414df3e6c93d8a6df6e22c43841e0
Signed-off-by: Patrick Venture <venture@google.com>

Use interfaces-removed for association removes

The mapper will no longer emit properties-changed signals
when the last endpoints property is removed from the fault
association object. It will only e

Use interfaces-removed for association removes

The mapper will no longer emit properties-changed signals
when the last endpoints property is removed from the fault
association object. It will only emit an interfaces-removed
signal in that case, so change the code to subscribe to the
interfaces-removed signal instead.

Change-Id: I225376e550d21b82473015324cd9a261e16fe6db
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Assert LEDs for existing callouts while service starts

Resolves openbmc/openbmc#1631

Change-Id: I1639c84cbb180dfe7f6494b5e80ca45514a3e730
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.

Assert LEDs for existing callouts while service starts

Resolves openbmc/openbmc#1631

Change-Id: I1639c84cbb180dfe7f6494b5e80ca45514a3e730
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

use new sdbusplus match constructors

Change-Id: Id833073b9e45fae24d6bd0e7f9310ef0ba8658de
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

Add class and stub for fru fault monitor application

This application waits for new fault entries and resolution of
exiting faults to assert or deassert LED for the corresponding FRUs,
respectively.

Add class and stub for fru fault monitor application

This application waits for new fault entries and resolution of
exiting faults to assert or deassert LED for the corresponding FRUs,
respectively.

Change-Id: I92ead0c8d3132dd7a6740b536231d6588ac42471
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...