clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I09e19a126d456dc184fd70e82d4e4e4217fa8ee7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I2ee8cbc4581d0c3ccdc130b646357c45fa0373db
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

updater: Cleanup Active blob to support multiple stages

Without the change, the update will fail due to existing active blob.
```
./burn_my_bmc --command update --interface ipmipci \
--image test

updater: Cleanup Active blob to support multiple stages

Without the change, the update will fail due to existing active blob.
```
./burn_my_bmc --command update --interface ipmipci \
--image test.txt --sig test.txt --type bios
Sending over the firmware image.
sendFile with /flash/bios and test.txt
Opening the cleanup blob
Committing to the cleanup blob
Closing cleanup blob
Exception received: blob exception received: Received IPMI_CC: 255
```

With the Change, it will delete the active blob to continue the update.
```
./burn_my_bmc --command update --interface ipmipci \
--image test.txt --sig test.txt --type bios
Found an active blob, deleting /flash/active/image
Opening the cleanup blob
Committing to the cleanup blob
Closing cleanup blob
Committing to the cleanup blob
Closing cleanup blob
Sending over the firmware image.
sendFile with /flash/bios and test.txt
000Find [0x1050 0x750]
bar0[0x90100000]
Progress: 100.00%
001Sending over the hash file.
sendFile with /flash/hash and test.txt
000Find [0x1050 0x750]
bar0[0x90100000]
Progress: 100.00%
001Opening the verification file
Committing to /flash/verify to trigger service
Calling stat on /flash/verify session to check status
running
running
failed
Returned non-success (could still be running (unlikely))
failed
Opening the cleanup blob
Committing to the cleanup blob
Closing cleanup blob
Exception received: Verification failed
```

Signed-off-by: Willy Tu <wltu@google.com>
Change-Id: I46a802c7faece60a9b5354db47860e796af99107

show more ...

Add option to skip p2a bridge disable

Add a new constructor for P2aDataHandler with skipBridgeDisable bool to
enable an option to skip disableBridge() in AspeedPciBridge and
NuvotonPciBridge.

Signe

Add option to skip p2a bridge disable

Add a new constructor for P2aDataHandler with skipBridgeDisable bool to
enable an option to skip disableBridge() in AspeedPciBridge and
NuvotonPciBridge.

Signed-off-by: Willy Tu <wltu@google.com>
Change-Id: I439bbaa2b7295adc54a8aa98157db60a7e820837

show more ...

tools/pci: refactor PCI bridge

Use polymorphism to handle the differences between Aspeed and Nuvoton
PCI devices.

Add unit tests (now at 100% line coverage for tools/pci.cpp).

Signed-off-by: Benja

tools/pci: refactor PCI bridge

Use polymorphism to handle the differences between Aspeed and Nuvoton
PCI devices.

Add unit tests (now at 100% line coverage for tools/pci.cpp).

Signed-off-by: Benjamin Fair <benjaminfair@google.com>
Change-Id: I43e63ec5eb9fce5fb0fc74e0e69667dd13b7433f

show more ...

tools/pci: replace pciutils with pciaccess

The pciutils library has a license which is incompatible with ours, so
switch to pciaccess instead since it's MIT-licensed.

Signed-off-by: Benjamin Fair <

tools/pci: replace pciutils with pciaccess

The pciutils library has a license which is incompatible with ours, so
switch to pciaccess instead since it's MIT-licensed.

Signed-off-by: Benjamin Fair <benjaminfair@google.com>
Change-Id: Ie40580d9992f7c30d9fdc904f97c89057791b10e

show more ...

update gcc10 and clang-format10

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I72239b884615d26b2c4311c49a26e2eced0a1fb0

tools: add configuration to enable PPC host memory access

Tested: Successfully updated on a Zaius (PPC platform) using ipmilpc

Change-Id: Ic744f6e0ca40df7aa3d5f914e2baef58114fa71b
Signed-off-by: Ru

tools: add configuration to enable PPC host memory access

Tested: Successfully updated on a Zaius (PPC platform) using ipmilpc

Change-Id: Ic744f6e0ca40df7aa3d5f914e2baef58114fa71b
Signed-off-by: Rui Zhang <ruizhan@google.com>

show more ...

tools: add network bridge support

Add support to the host tool for sending the image data over a network
connection.

Signed-off-by: Benjamin Fair <benjaminfair@google.com>
Change-Id: I88630d7949925

tools: add network bridge support

Add support to the host tool for sending the image data over a network
connection.

Signed-off-by: Benjamin Fair <benjaminfair@google.com>
Change-Id: I88630d79499254d6c80ceaa8c7721c241d394fc8

show more ...

tools: Add ignoreUpdate parameter

Adds ignoreUpdate flag to skip checking the update status and always
return success instead. This is needed for platforms that use the reboot
json and encounters an

tools: Add ignoreUpdate parameter

Adds ignoreUpdate flag to skip checking the update status and always
return success instead. This is needed for platforms that use the reboot
json and encounters an update failure due to IPMI going down during
shutdown.

Tested: Tried out an update with and without --ignore-update to verify
that the flag ignores the update status and returns success.

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: Ie20774f997229cd5ff8ae9082dc8a747079f9a2c

show more ...

tools: type field now matches the /flash/{type}

Instead of mapping one word to a pre-defined mapping of types, let the
host user specify any value.

A user shouldn't specify hash, or update, or some

tools: type field now matches the /flash/{type}

Instead of mapping one word to a pre-defined mapping of types, let the
host user specify any value.

A user shouldn't specify hash, or update, or something meaningful.
Perhaps this should be validated.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Icec103e0ade999d527923dcacb440086c93e175c

show more ...

tools: add bios support

Add type "bios" to burn_my_bmc, such that when used it'll use the
/flash/bios path for writing the bios contents.

Signed-off-by: Patrick Venture <venture@google.com>
Change-

tools: add bios support

Add type "bios" to burn_my_bmc, such that when used it'll use the
/flash/bios path for writing the bios contents.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I613af23b80eb99936b744d4138a61d2f7b39b962

show more ...

tools: add progress implementation

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I9da1674d6cbc688efc7bab0e033788d6ee4694f7

tools: add support for ubi tarball from host

Add a parameter that specifies the layout type, static or ubitar.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I86c09d8ffeb55ba789279d

tools: add support for ubi tarball from host

Add a parameter that specifies the layout type, static or ubitar.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I86c09d8ffeb55ba789279d2568b579a44b3923d7

show more ...

tools: specify parameter size limits for LPC

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ic7049ffc2a3c4e7dad3356e11f48f6e5ed8eeca1

tool: LPC data handler needs an address and length

The host needs to have memory set aside for this purpose, and this
enables the caller to provide those values.

Signed-off-by: Patrick Venture <ven

tool: LPC data handler needs an address and length

The host needs to have memory set aside for this purpose, and this
enables the caller to provide those values.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: If40ec3b08bd1932cba91d3f770c7fde6f280463d

show more ...

tools: add update handler

Add an UpdateHandler to handle each step of the update process.

This code was already in place but is now handled via an UpdateHandler
object.

Tested: Not yet tested.
Sig

tools: add update handler

Add an UpdateHandler to handle each step of the update process.

This code was already in place but is now handled via an UpdateHandler
object.

Tested: Not yet tested.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I36cd1b94d8e2c0788d09805d935738d86e6e33de

show more ...

add exception catch-all in main

Catch all derived exceptions that may be thrown from the Updater.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I7ab1e74fc1378a3e8f73eae40295e42ef7a

add exception catch-all in main

Catch all derived exceptions that may be thrown from the Updater.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I7ab1e74fc1378a3e8f73eae40295e42ef7a2833a

show more ...

tools: main: update ipmi-blob-tool constructors

ipmi-blob-tool changed the constructors to perform explicit ownership of
the inputs. Therefore, update our constructions to obey this pattern.

Signe

tools: main: update ipmi-blob-tool constructors

ipmi-blob-tool changed the constructors to perform explicit ownership of
the inputs. Therefore, update our constructions to obey this pattern.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I8029ce2ced3d75505f918a66afdc5fd61409c69d

show more ...

p2a: add initial p2a support (empty)

Add initial pci-to-ahb host-side support, by just listing the aspeed pci
devices.

Tested: This dumped the aspeed PCI device listed on my test platform.
Change-I

p2a: add initial p2a support (empty)

Add initial pci-to-ahb host-side support, by just listing the aspeed pci
devices.

Tested: This dumped the aspeed PCI device listed on my test platform.
Change-Id: I6dc4aeb3b38ec2f95bfd716bda2d8eb4786328ab
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

use ipmiblob library from ipmi-blob-tool

Drop all code that is now handled by the ipmiblob library provided by
the new ipmi-blob-tool. This is a library that can be included on the
BMC if necessary

use ipmiblob library from ipmi-blob-tool

Drop all code that is now handled by the ipmiblob library provided by
the new ipmi-blob-tool. This is a library that can be included on the
BMC if necessary, but relies on nothing that is strictly meant for the
BMC.

Change-Id: Iadbf0bd89c58cafc436fba05ea43e21c49e2b669
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: tie devmem io handler into lpc handler

The lpc handler requires mapping memory on the host.

Change-Id: Ic851dfa6c06d10566f66153ce7915cf5ad66992b
Signed-off-by: Patrick Venture <venture@googl

tools: tie devmem io handler into lpc handler

The lpc handler requires mapping memory on the host.

Change-Id: Ic851dfa6c06d10566f66153ce7915cf5ad66992b
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: put all host-side code into host_tool namespace

To avoid confusion and organize the code itself more cleanly, place the
host-side code into its own namespace.

Change-Id: I573eb0494eb59874adb

tools: put all host-side code into host_tool namespace

To avoid confusion and organize the code itself more cleanly, place the
host-side code into its own namespace.

Change-Id: I573eb0494eb59874adb1d1eadc502499e928e396
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: main: cleanup usage output

Cleanup the usage output to show the correct dashes for long options.

Change-Id: Id36c67911e3c892177de67b906327d3839c3fdb5
Signed-off-by: Patrick Venture <venture@

tools: main: cleanup usage output

Cleanup the usage output to show the correct dashes for long options.

Change-Id: Id36c67911e3c892177de67b906327d3839c3fdb5
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

tools: bugfix: main: print usage with no parameters

If the command isn't yet (the case with no parameters or missing the key
one), print the usage message and exit.

Change-Id: I1e708abfbe3d369d32c9

tools: bugfix: main: print usage with no parameters

If the command isn't yet (the case with no parameters or missing the key
one), print the usage message and exit.

Change-Id: I1e708abfbe3d369d32c96e5d2b88fd069b366396
Signed-off-by: Patrick Venture <venture@google.com>

show more ...