clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I09e19a126d456dc184fd70e82d4e4e4217fa8ee7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I2ee8cbc4581d0c3ccdc130b646357c45fa0373db
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

phosphor-ipmi-flash: Fix all C++ warnings

Change-Id: I89236b2dab88ca725e269bb8f5b2cbfd271e807a
Signed-off-by: Willy Tu <wltu@google.com>

handler_config: Split out from buildjson

This allows us to build the version-handler without the json
infrastructure.

Change-Id: I8c0a5715cb66f6cbb3e72cb714759f6e11e3f409
Signed-off-by: William A.

handler_config: Split out from buildjson

This allows us to build the version-handler without the json
infrastructure.

Change-Id: I8c0a5715cb66f6cbb3e72cb714759f6e11e3f409
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Produce errors for unavailable data

We want to make it clear to the reader that the data is actually
unavailable vs reading outside the bounds of the data space.

Change-Id: Ifb63df

version-handler: Produce errors for unavailable data

We want to make it clear to the reader that the data is actually
unavailable vs reading outside the bounds of the data space.

Change-Id: Ifb63dfe600c268af9e7df24397c28e20316dbb8f
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Add session stat

We need to be able to inform the blob user of the readiness of blob data
and how large the contents are.

Change-Id: Ic90f6e344160b48e7e58cb009558586c7c2fab9b
Signe

version-handler: Add session stat

We need to be able to inform the blob user of the readiness of blob data
and how large the contents are.

Change-Id: Ic90f6e344160b48e7e58cb009558586c7c2fab9b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version_handler: Support multiple sessions

We want to be able to support multiple concurrent readers of version
information. Otherwise, upstream version checks might fail if they end
up being sequen

version_handler: Support multiple sessions

We want to be able to support multiple concurrent readers of version
information. Otherwise, upstream version checks might fail if they end
up being sequenced concurrently.

Change-Id: I5420ad667622b7906e633562a5373e0be042c0c1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version_handler: Read doesn't need to catch missing sessions

The read() interface from phosphor-ipmi-blobs will never call read with
an invalid session, so we don't need to catch the exception if th

version_handler: Read doesn't need to catch missing sessions

The read() interface from phosphor-ipmi-blobs will never call read with
an invalid session, so we don't need to catch the exception if the
session doesn't exist.

Change-Id: I2ccb351b85d18a6eb96d4f92cfb3167a95f0509e
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version_handler: Expire shouldn't fail

We want to make sure any sessions which expire are successfully removed,
even if we don't have the session in our map.

Change-Id: I50c7f74509945e29ab3c04ecbcf

version_handler: Expire shouldn't fail

We want to make sure any sessions which expire are successfully removed,
even if we don't have the session in our map.

Change-Id: I50c7f74509945e29ab3c04ecbcf583a1a9ce0c92
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version_handler: Don't store session information immediately

This can cause spurious trigger aborts when open's fail and cleanup is
called on the failed session.

Change-Id: I1c49f248b6f56bbecc0d51f

version_handler: Don't store session information immediately

This can cause spurious trigger aborts when open's fail and cleanup is
called on the failed session.

Change-Id: I1c49f248b6f56bbecc0d51fafaabe871d23b1d7d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Remove superfluous open session check

The phosphor-ipmi-flash API guarantees that calls to open() will not
happen with duplicate session IDs.

Change-Id: Ife88b2743322387e5cc6ebe2b3

version-handler: Remove superfluous open session check

The phosphor-ipmi-flash API guarantees that calls to open() will not
happen with duplicate session IDs.

Change-Id: Ife88b2743322387e5cc6ebe2b34567c3d2d2957a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Refactor maps to simplify accesses

This reduces the number of map lookups needed for read() and close()
operations and the number of stored strings by referencing the pinned
blobId.

version-handler: Refactor maps to simplify accesses

This reduces the number of map lookups needed for read() and close()
operations and the number of stored strings by referencing the pinned
blobId.

Change-Id: I8c6af5749b8cc8415eedeba484bf4a39a98f0286
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Refactor handler construction

Instead of requiring callers to build maps and info blobs, take the
minimal required amount of information about the blob configuration and
build requi

version-handler: Refactor handler construction

Instead of requiring callers to build maps and info blobs, take the
minimal required amount of information about the blob configuration and
build required datastructures internally.

This reduces the amount of code, and nearly eliminates all of the
untested code in main.cpp.

Change-Id: Iaa398eb404814e9263e6707b71b38a9831d96697
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Remove create special cases

Our builder is validated to not pass invalid configurations to the
handler. Since we can guarantee the invariant that we will never
construct handlers wi

version-handler: Remove create special cases

Our builder is validated to not pass invalid configurations to the
handler. Since we can guarantee the invariant that we will never
construct handlers with null paramemters, we don't need have extra
checks.

Change-Id: I48d24874298c1c5ead74724921c86ea0a022a53c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Remove superfluous canHandleBlob

This is a guarantee of the upper layer interface, we don't need to check
for it again.

Change-Id: Ifdc52e0d64543bd45ced5dabb29639c35e0c7da9
Signed-

version-handler: Remove superfluous canHandleBlob

This is a guarantee of the upper layer interface, we don't need to check
for it again.

Change-Id: Ifdc52e0d64543bd45ced5dabb29639c35e0c7da9
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: add version-handler, blob handler

Implement version-handler: a blob handler for retrieving version
information about a blob.

Problem: ipmi-flash(firmware-handler) provides a mechan

version-handler: add version-handler, blob handler

Implement version-handler: a blob handler for retrieving version
information about a blob.

Problem: ipmi-flash(firmware-handler) provides a mechanism to transfer
firmware updates, verify them and perform updates but there is no
mechanism to interrogate the firmware for its version.

Solution: version-handler provides handlers for retrieving information
about firmware blobs. Adding "version" syntax to "/flash/blob" entries
in the json configuration file enables this feature.
The mechanism to retrieve version is identical to the mechanism used by
firmware-handler to perform preparation, verification and updates (kick
off systemd targets).

Signed-off-by: Jason Ling <jasonling@google.com>
Change-Id: I28868ca8dd76d63af668d2e46b9359401d45f0bc

show more ...