#
02e598ab |
| 16-Aug-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda forma
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda formatting also changed, so we have made changes to the organization default style format to better handle lambda formatting.
See I5e08687e696dd240402a2780158664b7113def0e for updated style. See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.
Change-Id: Iabfeec3ff53427c317ef9c0b5bf06326ab9a1e17 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
#
82f2db6e |
| 22-Jul-2024 |
Matt Spinler <spinler@us.ibm.com> |
Remove add_object_vtable expect from fanpwm UT
For some reason, having an expect on the sdbusplus mock sd_bus_add_object_vtable causes valgrind to fail in CI with errors such as:
``` ==729843== Con
Remove add_object_vtable expect from fanpwm UT
For some reason, having an expect on the sdbusplus mock sd_bus_add_object_vtable causes valgrind to fail in CI with errors such as:
``` ==729843== Conditional jump or move depends on uninitialized value(s) ==729843== at 0x5CB89AB: std::unique_ptr<sd_bus_slot, sdbusplus::slot::details::SlotDeleter>::~unique_ptr() (unique_ptr.h:403) ==729843== by 0x5CB8665: sdbusplus::slot::slot::~slot() (slot.hpp:43) ==729843== by 0x5CC3CC9: sdbusplus::server::interface::interface::~interface() (interface.cpp:38) ==729843== by 0x13189B: sdbusplus::server::xyz::openbmc_project::control::FanPwm::~FanPwm() (server.hpp:32) ==729843== by 0x13E267: sdbusplus::server::object::details::compose<sdbusplus::server::xyz::openbmc_project::control::FanPwm>::~compose() (object.hpp:181) ==729843== by 0x13E4BC: sdbusplus::server::object::object<sdbusplus::server::xyz::openbmc_project::control::FanPwm>::~object() (object.hpp:95) ==729843== by 0x13C5C9: hwmon::FanPwm::~FanPwm() (fan_pwm.hpp:18) ==729843== by 0x12C0D1: FanPwmTest_BasicConstructorDeferredTest_Test::TestBody() (fanpwm_unittest.cpp:76) ==729843== by 0x5E089FC: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (gtest.cc:2638) ==729843== by 0x5DFE67A: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (gtest.cc:2674) ==729843== by 0x5DD3BA3: testing::Test::Run() (gtest.cc:2713) ==729843== by 0x5DD4661: testing::TestInfo::Run() (gtest.cc:2859) ```
There are 4 more stanzas of similar 'Conditional jump or move...' errors. None of these show up without the vtable expect.
Other repositories that use this same expect also fail.
I opened sdbusplus issue openbmc/sdbusplus#97 for the problem. I spent time looking into it, and did not figure anything out.
This commit just removes the call to it because in these testcases the FanPwm object, which is just derived from the sdbuplus interface object, is simply created on the stack:
``` hwmon::FanPwm f(...); ```
The unit tests aren't actually testing any code that conditionally creates a FanPwm interface on D-Bus, so checking that it happens isn't that useful and seems to more just be testing sdbusplus.
Change-Id: Idf2df085bf909af1ad94ba06863c4605831a3824 Signed-off-by: Matt Spinler <spinler@us.ibm.com>
show more ...
|
#
c8e818dd |
| 20-Oct-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: I542db97d7dc7fe5b03ffedbbdbff968d4c1bb032 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
#
e8771fd4 |
| 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: I267a17e007b99caed10aef060e7dd9a0bcc5fc2e Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
#
82921ae8 |
| 02-Feb-2021 |
Matt Spinler <spinler@us.ibm.com> |
Change an sdbusplus mock signature
The signature of sd_bus_emit_properties_changed_strv changed.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I94cd218d04e4a79444314684020da1a1ff3969a3
|
#
778f5c39 |
| 07-Oct-2019 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
tests: fix warnings
Fix a couple of warnings:
-Werror=unused-parameter
so we can use meson's warning_level=3 and -Werror without build failures.
Change-Id: I1c3930226b34d6beeb7c5fb5ce135c722d3e87
tests: fix warnings
Fix a couple of warnings:
-Werror=unused-parameter
so we can use meson's warning_level=3 and -Werror without build failures.
Change-Id: I1c3930226b34d6beeb7c5fb5ce135c722d3e8758 Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
show more ...
|
#
cc86915b |
| 04-Sep-2018 |
Patrick Venture <venture@google.com> |
clang-format: fix pointer alignment, sort using
Change-Id: Ia1b19aeba59b2f680b62ce3855e929b9ad77377a Signed-off-by: Patrick Venture <venture@google.com>
|
#
043d3230 |
| 31-Aug-2018 |
Patrick Venture <venture@google.com> |
add .clang-format
Change-Id: I94ce26d595367e08d6fb3734535bcd855f1b1473 Signed-off-by: Patrick Venture <venture@google.com>
|
#
50552377 |
| 07-Jun-2018 |
Patrick Venture <venture@google.com> |
hwmonio:: Add Interface base class and tests
Enable injecting hwmonio::HwmonIO mocks for testing.
Tested: Ran on quanta-q71l and saw all sensors exported to dbus as expected with the expected value
hwmonio:: Add Interface base class and tests
Enable injecting hwmonio::HwmonIO mocks for testing.
Tested: Ran on quanta-q71l and saw all sensors exported to dbus as expected with the expected values.
Change-Id: I35912bf2a733932d9e1e774ff53b0114ae16560b Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|