apphandler: remove IPMI_CMD command

The IPMI_CMD declared in apphandler.hpp is redundant because these
commands are already declared in api-types.hpp, so this commit
removes all IPMI_CMD in apphandl

apphandler: remove IPMI_CMD command

The IPMI_CMD declared in apphandler.hpp is redundant because these
commands are already declared in api-types.hpp, so this commit
removes all IPMI_CMD in apphandler.hpp

Change-Id: I7c0e38ee00c906e2c1495d05fb66b99b4db62a11
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I01547e98d27910919e09ebf7907c86292a6c825d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

user_channel: switch to lg2

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I80149836f196f01eb09cc874f74eec0d787b5ac5

Fix the bugs found in static analysis

This commit fixes the following static analyzer reported issues:

Operands don't affect result
some conditions are not required to check as its always true

Fix the bugs found in static analysis

This commit fixes the following static analyzer reported issues:

Operands don't affect result
some conditions are not required to check as its always true
Unsigned compared against 0
Unchecked return value from library
Uninitialized scalar variable

Change-Id: I0b1fd426794bb88f6eafcc817cef5dd2f655e1ba
Signed-off-by: PavanKumarIntel <pavanx.kumar.martha@intel.com>

show more ...

treewide: Fix various compiler warnings

LTO is currently hiding these warnings.

Change-Id: I09560dfbb150f43d58f472e7592fc0c072e3cc29
Signed-off-by: William A. Kennington III <wak@google.com>

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I44441096113929ce96eb1439e2932e6ff3c87f27
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

GetPayloadVerCmd:Fix ErrCode IncorrectPayloadType

The error code 0x82 is returned for session less channels in
Get Payload Version command. The correct error code is
0x80 Payload type not available

GetPayloadVerCmd:Fix ErrCode IncorrectPayloadType

The error code 0x82 is returned for session less channels in
Get Payload Version command. The correct error code is
0x80 Payload type not available on given channel.

Tested:
Channels configured as multi-session:
The channels 1,2,3,4 are configurated for LAN ports (eth0-3).

Channels configured as session-less:
The channel 0 for IPMB, channel 8 for INTRABMC and
channel 0xf for system interface

Case 1: Response for session less channels 0,8 and 0xf

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x00 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4f rsp=0x80): Unknown (0x80)

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x08 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4f rsp=0x80): Unknown (0x80)

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x0f 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4f rsp=0x80): Unknown (0x80)

Case 2: Response for channels 1,2,3,4 (LAN) and 0xE (Present I/F)

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x01 0x00
Response: 10

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x02 0x00
Response: 10

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x03 0x00
Response: 10

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x04 0x00
Response: 10

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x0E 0x00
Response: 10

Case 3: Response for unconfigured channels 5,6,7,9,0xA,0xB,0xC and 0xD

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x05 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4f rsp=0xcc): Invalid data field in request

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x06 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4f rsp=0xcc): Invalid data field in request

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x07 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4f rsp=0xcc): Invalid data field in request

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x09 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4f rsp=0xcc): Invalid data field in request

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x0a 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4f rsp=0xcc): Invalid data field in request

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x0b 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4f rsp=0xcc): Invalid data field in request

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x0c 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4f rsp=0xcc): Invalid data field in request

Command: ipmitool -I lanplus -H <BMC IP> -U <user> -P <passwd> -C 17
raw 0x06 0x4F 0x0d 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4f rsp=0xcc): Invalid data field in request

Signed-off-by: Manoj Ashok <amanoj@ami.com>
Change-Id: Ib0a57bc007194620f8a12a5f30512265c011f85e

show more ...

types: Force underlying int conversion for enums

Boost 1.76.0 changed the behavior of numeric to not accept implicitly
converted ints from enum class types. This breaks many of our casts and
would r

types: Force underlying int conversion for enums

Boost 1.76.0 changed the behavior of numeric to not accept implicitly
converted ints from enum class types. This breaks many of our casts and
would require 2 casts in most cases.

This adds a convenience function to do the underlying type conversions
needed to cast enums to ints and vice versa.

Change-Id: Id653d6a10ef5cab8267c174848940807d693dbf1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

minor fix: corrected cc for get channel access

As per IPMI spec, get channel access don't have
specific cc code 0x83(Access mode not supported).
Whereas set channel access has that specific cc.
So c

minor fix: corrected cc for get channel access

As per IPMI spec, get channel access don't have
specific cc code 0x83(Access mode not supported).
Whereas set channel access has that specific cc.
So changed cc to generic 0xcc(invalid field request)
in get channel access mode command.

Tested:
For reserved access mode byte 2 request, return 0xCC.
ipmitool -I lanplus -U <> -P <> -H <IP> raw 6 0x41 0x01 0x00
Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x41 rsp=0xcc): Invalid data field in request

Change-Id: I75256b9f74eddaf95a9f78d95730332877d21dfd
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

Fix for get Channel Info cmd for reserved channels

Issue: Get channel info command returning improper response as "0x82"
which is not expected for reserved channels 5, 11, 12, 13.

Fix: Retur

Fix for get Channel Info cmd for reserved channels

Issue: Get channel info command returning improper response as "0x82"
which is not expected for reserved channels 5, 11, 12, 13.

Fix: Return proper completion code for reserved channels.

Tested:
Verified using ipmitool raw commands
Before:
Command: ipmitool raw 6 0x42 0x05 //get Channel Info
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x42 rsp=0x82): Unknown (0x82)
Command: ipmitool raw 6 0x42 0x0b
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x42 rsp=0x82): Unknown (0x82)
Command: ipmitool raw 6 0x42 0x0c
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x42 rsp=0x82): Unknown (0x82)
Command: ipmitool raw 6 0x42 0x0d
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x42 rsp=0x82): Unknown (0x82)
After:
Command: ipmitool raw 6 0x42 0x05 //get Channel Info
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x42 rsp=0xcc): Invalid data field in request
Command: ipmitool raw 6 0x42 0x0b
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x42 rsp=0xcc): Invalid data field in request
Command: ipmitool raw 6 0x42 0x0c
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x42 rsp=0xcc): Invalid data field in request
Command: ipmitool raw 6 0x42 0x0d
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x42 rsp=0xcc): Invalid data field in request

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ic5a5bb2317ee301a1ecc37350cbe1b289d33ca38

show more ...

Fix for Callback privilege

Issue: Not returning proper error when user privilege is Callback

Returning proper error codes.

Tested:
Command: ipmitool raw 0x06 0x40 0x3 0x42 0x41 //SetChannelAcce

Fix for Callback privilege

Issue: Not returning proper error when user privilege is Callback

Returning proper error codes.

Tested:
Command: ipmitool raw 0x06 0x40 0x3 0x42 0x41 //SetChannelAccess
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x40 rsp=0xcc): Invalid data field in request
Command: ipmitool raw 0x06 0x40 0x3 0x42 0xc2 //SetChannelAccess
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x40 rsp=0x83): Unknown (0x83)
Command: ipmitool user priv 2 0x01 1
Response: IPMI command failed: Invalid data field in request
Set Privilege Level command failed (user 2)
Command: ipmitool raw 0x06 0x38 1 1 //Get Channel Auth Capabilities
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x38 rsp=0xcc): Invalid data field in request
Command: ipmitool raw 0x06 0x40 0x1 0x42 0x81 //SetChannelAccess
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x40 rsp=0xcc): Invalid data field in request
Command: ipmitool raw 0x06 0x43 0x1 2 1 0 //Set User Access Command
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x43 rsp=0xcc): Invalid data field in request
Command: ipmitool raw 0x06 0x43 0x2 1 2 0 //Set User Access Command
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x43 rsp=0xff): Unspecified error
Command: ipmitool raw 0x06 0x42 0x02 //Get Channel Info Command
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x42 rsp=0x82): Unknown (0x82)
Command: ipmitool raw 0x06 0x4E 0x02 //Get Channel Payload Support
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4e rsp=0xff): Unspecified error
Command: ipmitool raw 0x06 0x4E 0x0F //Get Channel Payload Support
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4e rsp=0xcc): Invalid data field in request
Command: ipmitool raw 0x06 0x4F 0x02 0x00 //Get Channel Payload Version
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4f rsp=0xcc): Invalid data field in request
Command: ipmitool raw 0x06 0x4C 0x02 0x01 0x02 0x00 0x00 0x00
//Set User Payload Access
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4c rsp=0xcc): Invalid data field in request
Command: ipmitool raw 0x06 0x44 0x02 0x02 //Get User Access Command
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x44 rsp=0xcc): Invalid data field in request
Command: ipmitool raw 0x06 0x44 0x01 0x11 //Get User Access Command
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x44 rsp=0xc9): Parameter out of range
Command: ipmitool raw 0x06 0x4D 0x02 0x02 //Get User Payload Access
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x4d rsp=0xcc): Invalid data field in request
Command: ipmitool raw 0x06 0x40 0x3 0x44 0x43
// set channel access for Non-volatile priv limit
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x40 rsp=0x83): Unknown (0x83)
Command: ipmitool raw 0x06 0x40 0x1 0x85 0x82
// set channel access for volatile priv limit
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x40 rsp=0x83): Unknown (0x83)

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I4ff6fb5ae9a604e6b38fb92c249416605ec27cb5

show more ...

user_channel:Change fun ret&cmd cc as per New Std

Modified ipmi function return status code and
command completion codes as per new standard.

Tested:
verified using ipmitool commands.
1. create new

user_channel:Change fun ret&cmd cc as per New Std

Modified ipmi function return status code and
command completion codes as per new standard.

Tested:
verified using ipmitool commands.
1. create new user
Command : ipmitool user set name 5 user5
Response: //user created successfully
Command: ipmitool user set password 5 0penBmc\' //set password
Response: Set User Password command successful (user 5)

2. Set password
Command : ipmitool user set password 5 0penBmc\'
Response: Set User Password command successful (user 5)

3. set channel access
Command: ipmitool channel setaccess 1 5 callin=on ipmi=on link=on
privilege=4
Response: Set User Access (channel 1 id 5) successful.

4. get channel access
Command: ipmitool channel getaccess 1 5
Response:
Maximum User IDs : 15
Enabled User IDs : 5

User ID : 5
User Name : user5
Fixed Name : No
Access Available : call-in / callback
Link Authentication : enabled
IPMI Messaging : enabled
Privilege Level : ADMINISTRATOR
Enable Status : disabled

5. User list
Command: ipmitool user list 1
Response:
ID Name Callin Link Auth IPMI Msg Channel Priv Limit
1 root false true true ADMINISTRATOR
2 putty_operator true true true OPERATOR
3 ipmi_admin true true true ADMINISTRATOR
4 user2 false true true OPERATOR
5 user5 true true true ADMINISTRATOR
6 true false false NO ACCESS
7 true false false NO ACCESS
8 true false false NO ACCESS
9 true false false NO ACCESS
10 true false false NO ACCESS
11 true false false NO ACCESS
12 true false false NO ACCESS
13 true false false NO ACCESS
14 true false false NO ACCESS
15 true false false NO ACCESS

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Signed-off-by: NITIN SHARMA <nitin1x.sharma@intel.com>
Change-Id: I5f2c32f50edc2de204ac361364e21a61a4bcf237

show more ...

channelcmds:fix set chnl access sessionless chnl

Return proper error code 0x82 for session-less channel

Tested
1.verified with ipmitool raw commands

ipmitool raw 0x06 0x40 0x00 0x40 0x04
Unable to

channelcmds:fix set chnl access sessionless chnl

Return proper error code 0x82 for session-less channel

Tested
1.verified with ipmitool raw commands

ipmitool raw 0x06 0x40 0x00 0x40 0x04
Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x40
rsp=0x82): Unknown (0x82)

ipmitool raw 0x06 0x41 0x00 0x40
Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x41
rsp=0x82): Unknown (0x82)

Signed-off-by: anil kumar appana <anil.kumarx.appana@intel.com>
Change-Id: I9ada001427a6c3dcaaf6de026f8831faa54c182d

show more ...

Add get channel payload version command

Implement get channel payload version command (IPMI specification
section 24.9). As per the specification, this command is basically a
hard-coded value that s

Add get channel payload version command

Implement get channel payload version command (IPMI specification
section 24.9). As per the specification, this command is basically a
hard-coded value that says we are using IPMI 2.0.

Tested:
ipmitool raw 6 0x4F 3 1 // Command
10 // Response

Change-Id: Id16723e7257361814b98f3c14d759f2919ad4c03
Signed-off-by: Ayushi Smriti <smriti.ayushi@intel.com>
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

user_channel: Get Channel Payload Support command refactor

Update the get channel payload support command to use the new IPMI API.
This simplifies the code as well as adds support for the special IP

user_channel: Get Channel Payload Support command refactor

Update the get channel payload support command to use the new IPMI API.
This simplifies the code as well as adds support for the special IPMI
channel 0x0e.

Tested: ipmitool -I lanplus -H ... -U ... raw 6 0x4e 0xe
03 00 3f 00 00 00 00 00
ipmitool -I lanplus -H ... -U ... raw 6 0x4e 1
03 00 3f 00 00 00 00 00

Change-Id: I8b67d6f79c40299b4b653212a2f1f9d0c1a9087c
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Updates get channel info command to use the new provider API

Update the get channel info command to use the new IPMI provider API.
Because of the change, this command can support the use of the spec

Updates get channel info command to use the new provider API

Update the get channel info command to use the new IPMI provider API.
Because of the change, this command can support the use of the special
channel number 0x0e.

Tested-by:
(remote via RMCP+ interface)
ipmitool -I lanplus -H ... -U ... channel info
Channel 0x1 info:
Channel Medium Type : 802.3 LAN
Channel Protocol Type : IPMB-1.0
Session Support : multi-session
Active Session Count : 0
Protocol Vendor ID : 7154
Volatile(active) Settings
Alerting : disabled
Per-message Auth : enabled
User Level Auth : enabled
Access Mode : always available
Non-Volatile Settings
Alerting : disabled
Per-message Auth : enabled
User Level Auth : enabled
Access Mode : always available

(on host via kcs interface)
ipmitool channel info
Channel 0xf info:
Channel Medium Type : System Interface
Channel Protocol Type : KCS
Session Support : session-less
Active Session Count : 0
Protocol Vendor ID : 7154

Change-Id: Ica4262593acaefe12ccf70724ad4db40da344da4
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

channelcmds: move get channel access to new IPMI provider API

Update the get channel access command to use the new IPMI provider API. As a
part of this change, the command is now able to use the spe

channelcmds: move get channel access to new IPMI provider API

Update the get channel access command to use the new IPMI provider API. As a
part of this change, the command is now able to use the special channel 0x0e.

Tested-by:
ipmitool -I lanplus -H ... -U ... channel getaccess 0xe 1
Maximum User IDs : 15
Enabled User IDs : 1

User ID : 1
User Name : root
Fixed Name : No
Access Available : callback
Link Authentication : enabled
IPMI Messaging : enabled
Privilege Level : ADMINISTRATOR
Enable Status : enabled

Change-Id: I97ad74ae183a15dd5f45dfa70341225794087b2a
Signed-off-by: NITIN SHARMA <nitin1x.sharma@intel.com>
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

channelcmds: move set channel access to new ipmi provider API

This updates the set channel access command to use the new IPMI provider
API. As part of this change, this command should now work with

channelcmds: move set channel access to new ipmi provider API

This updates the set channel access command to use the new IPMI provider
API. As part of this change, this command should now work with the
special channel 0x0e.

Tested-by:
(set channel access: 6 0x40)
# ipmitool -I lanplus -H ... -U ... raw 6 0x40 0xe 0x82 0x84
(get channel access: 6 0x41)
# ipmitool -I lanplus -H ... -U ... raw 6 0x41 0xe 0x80
02 04
# ipmitool raw 6 0x40 1 0x80 0x83
# ipmitool raw 6 0x41 1 0x80
00 03

Change-Id: Icc6e8ff7deebb7a6f89af616fa70258ea18ed0ce
Signed-off-by: NITIN SHARMA <nitin1x.sharma@intel.com>
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Add: Get channel payload support command

Implemented Get Channel Payload Support command (IPMI Spec sec 24.8)
The same is implemented under channel commands, and will be
available for both Host & Ne

Add: Get channel payload support command

Implemented Get Channel Payload Support command (IPMI Spec sec 24.8)
The same is implemented under channel commands, and will be
available for both Host & Net ipmid. Uses channel configuration
to differentiate between session / session-less channel

Tested-by:
1. Verified command executed successfully for session
based channel
ipmitool raw 6 0x4E 0x1 // Command
03 00 15 00 00 00 00 00 // Response
2. Verified sessionless channel error is returned.

Change-Id: I8b294234415b4467aeae6c23c192750471536f4e
Signed-off-by: Saravanan Palanisamy <saravanan.palanisamy@intel.com>
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Fix: Check reserved fields in channel cmds request

Check reserved fields in channel cmds request and
return 0xCC, if reserved fields are set

Unit-Test:
1. Verified 0xCC is returned if reserved fiel

Fix: Check reserved fields in channel cmds request

Check reserved fields in channel cmds request and
return 0xCC, if reserved fields are set

Unit-Test:
1. Verified 0xCC is returned if reserved fields are set
ipmitool raw 0x6 0x40 0x11 0x82 0x81

Change-Id: I4ca18c35d1435c6f9a636eb2c2730e63d8df319b
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Change struct names to UpperCamelCase

Change struct names to UpperCamelCase to align with
OpenBMC coding guidelines

Change-Id: Ib71768be45e57556a26b14b64adec98db3bc7762
Signed-off-by: Richard Maria

Change struct names to UpperCamelCase

Change struct names to UpperCamelCase to align with
OpenBMC coding guidelines

Change-Id: Ib71768be45e57556a26b14b64adec98db3bc7762
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

libipmi: Decouple user commands

This makes them an optional, separate provider like the sysfs cmds.

Tested:
Ran on real hardware that included libusercmds.so in
/usr/lib/host-ipmid and on a

libipmi: Decouple user commands

This makes them an optional, separate provider like the sysfs cmds.

Tested:
Ran on real hardware that included libusercmds.so in
/usr/lib/host-ipmid and on a machine that did not include it. Ran
ipmitool on the host to verify that the user commands were present
when expected.

Change-Id: I07b3af5ae603c3e5f1ea41f0afc309329f4e185d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Channel commands updated to handle self channel

Channel commands are updated to handle self channel
number 0xE. When user request 0xE self channel number, it
will be converted to proper channel base

Channel commands updated to handle self channel

Channel commands are updated to handle self channel
number 0xE. When user request 0xE self channel number, it
will be converted to proper channel based on the interface
the command is requested.

Unit-Test:
Verified channel commands are working as expected.

Change-Id: If542f8e88b609d7b92f4a96acb572611dd883555
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Doxygen comments for enum & structure

Added doxygen comments for enums & structures for user & channel
layers.

Unit-test:
verified build.

Change-Id: Ie5af8d6cdd4c04cb396869b7a3dc44f84efedd19
Signe

Doxygen comments for enum & structure

Added doxygen comments for enums & structures for user & channel
layers.

Unit-test:
verified build.

Change-Id: Ie5af8d6cdd4c04cb396869b7a3dc44f84efedd19
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

IPMI Channel commands implementation

IPMI Channel commands implemenation - squashed

commit e9a75d8dd6e89d17381f0310c7930586c6b79996
Author: AppaRao Puli <apparao.puli@intel.com>
Date: Thu Jul 5 1

IPMI Channel commands implementation

IPMI Channel commands implemenation - squashed

commit e9a75d8dd6e89d17381f0310c7930586c6b79996
Author: AppaRao Puli <apparao.puli@intel.com>
Date: Thu Jul 5 14:47:22 2018 +0530

Channel layer separation

De-coupling the channel management from ipmi channel commands
implementation. This gives flexibility to load only needed
stuff in different modules(host-ipmi or netipmid)

Change-Id: Ib334562beb9325f7768ed6a15475cae15af17b19
Signed-off-by: AppaRao Puli <apparao.puli@intel.com>
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

commit 726ddf2af678ea6773f4b4b918fbd49be8c83e6a
Author: AppaRao Puli <apparao.puli@intel.com>
Date: Thu May 24 16:45:30 2018 +0530

IPMI Channel commands implementation

Following IPMI channel commands are implemented.
1) Set channel access (0x40)
2) Get channel access (0x41)
3) Get channel info (0x42)

Also added code supported for LAN configuration parameters
1) Authentication Type Support (selector #1)
2) Authentication Type Enables (selector #2)

Change-Id: Ic4156378c7756eca383dc3da52114fd119346ca6
Signed-off-by: AppaRao Puli <apparao.puli@intel.com>
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

Change-Id: Ic4156378c7756eca383dc3da52114fd119346ca6
Signed-off-by: AppaRao Puli <apparao.puli@intel.com>
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...