ipmid: Switch to /var/run for lockfiles

- This prevents IPMI connections from the host to the BMC from failing
if the BMC's root ('/') partition fills up or is otherwise
unwriteable.

- In the f

ipmid: Switch to /var/run for lockfiles

- This prevents IPMI connections from the host to the BMC from failing
if the BMC's root ('/') partition fills up or is otherwise
unwriteable.

- In the full filesystem case, this error only happens if the filesystem
fills up prior to the first operation after flashing an image.

This is because lockfiles are only created at connection time
(e.g. see cacheUserDataFile() in user_channel/user_mgmt.cpp),
so the failure only happens if no other operation has been performed
since the image was first flashed.

- For the "root is otherwise unwriteable" case, all locking operations
would fail, since even though the files may exist, they can't be
opened as writeable.

- This approach is chosen since (a) `/var/run` is arguably the correct
place for daemons to write runtime info, and (b) `/var/run` uses
`tmpfs` so it should always be able to mount `rw`.

- Note that this does not prevent the "full filesystem" failure
entirely, since other things may fill up `tmpfs`.

The complete solution would include creating the files at start time
(e.g. using systemd), which I will do in a followup change.

Tested: Flashed BMC with new image containing updated IPMI daemons.
Verified that IPMI operations work and that lock files are now created
in `/var/run/ipmi/` instead of `/var/lib/ipmi/`.

Signed-off-by: Tyson Tuckerbear <ttucker@google.com>
Change-Id: I33eb33ddb0009a978d5cea3fcd5615c45ce4416c

show more ...

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

Change-Id: Ia40d9435ab57651ec6d13d5408cf69130043fa79
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Ic23653be3ed404980fd0e723d9ed8354e2b32579
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Ic23653be3ed404980fd0e723d9ed8354e2b32579
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

usercommands: remove IPMI_CMD command

The IPMI_CMD declared in usercommands.hpp is redundant because these
commands are already declared in api-types.hpp, so this commit
removes all IPMI_CMD in user

usercommands: remove IPMI_CMD command

The IPMI_CMD declared in usercommands.hpp is redundant because these
commands are already declared in api-types.hpp, so this commit
removes all IPMI_CMD in usercommands.hpp.

Change-Id: I347c30e1907b6fd0b2d311c970455195ade383ee
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

apphandler: remove IPMI_CMD command

The IPMI_CMD declared in apphandler.hpp is redundant because these
commands are already declared in api-types.hpp, so this commit
removes all IPMI_CMD in apphandl

apphandler: remove IPMI_CMD command

The IPMI_CMD declared in apphandler.hpp is redundant because these
commands are already declared in api-types.hpp, so this commit
removes all IPMI_CMD in apphandler.hpp

Change-Id: I7c0e38ee00c906e2c1495d05fb66b99b4db62a11
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

build: use allowed over enabled or not-disabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`)

build: use allowed over enabled or not-disabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and
auto.

Switch all uses of `enabled` to `allowed`.
Switch all uses of `not disabled` to `allowed`.

Change-Id: Ib0b26af4bd0e8685c83b1b0181f70bfca59ab2bc
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I1dbf4ae74d383552995432add3d2f548eb844ee5
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

meson: switch code dependency to libsystemd

For a while now systemd has packaged a separate `libsystemd`. For
meson dependency, `systemd` should be used when looking for systemd
service file paths

meson: switch code dependency to libsystemd

For a while now systemd has packaged a separate `libsystemd`. For
meson dependency, `systemd` should be used when looking for systemd
service file paths and `libsystemd` should be used for `sd_*` functions.

Update the dependency accordingly.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9768dd66c4180085f201a0b77385d696bdd1680f

show more ...

Optimize the response value of ipmiSetUserPassword method

ipmiCCPasswdFailMismatch has been declared in usercommands.hpp, so
there is no need to declare a static variable.

Signed-off-by: George Li

Optimize the response value of ipmiSetUserPassword method

ipmiCCPasswdFailMismatch has been declared in usercommands.hpp, so
there is no need to declare a static variable.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I1989c4674392544aaf736823c8b5f9b2ac7acefa

show more ...

Remove unused variables

Using clang-tidy, it was detected that some variables are no longer
in use. This commit remove unused variables.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id

Remove unused variables

Using clang-tidy, it was detected that some variables are no longer
in use. This commit remove unused variables.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I382e6ce07e66dc5ad082be9b36d217a037e609b5

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I01547e98d27910919e09ebf7907c86292a6c825d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

user_channel: switch to lg2

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I80149836f196f01eb09cc874f74eec0d787b5ac5

convert channel_mgmt.cpp to use lg2

Change-Id: I4bd78d3aa3bf3c5717fcf3e2a9186888587456d1
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

Refactor to call the getProperty method

Uniformly use the getProperty method of utils.hpp to obtain values

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I9eae6bba6806215b51090637a7e

Refactor to call the getProperty method

Uniformly use the getProperty method of utils.hpp to obtain values

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I9eae6bba6806215b51090637a7e42c8c8d90be87

show more ...

user_mgmt: Fix incorrect log description

The entry method in log debug should be getManagedObjectsMethod
instead of getSubTree.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I1dfdbd

user_mgmt: Fix incorrect log description

The entry method in log debug should be getManagedObjectsMethod
instead of getSubTree.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I1dfdbd67412284f385466b56a67e86026ec97be1

show more ...

Remove libmapper dependency

After this commit is merged [1], phosphor-ipmi-host no longer depends
on libmapper. This commit removes the dependence on libmapper.

[1] https://gerrit.openbmc.org/c/ope

Remove libmapper dependency

After this commit is merged [1], phosphor-ipmi-host no longer depends
on libmapper. This commit removes the dependence on libmapper.

[1] https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/69082

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Iacf20716b3dd02f0c3173eb6c1fcb39d416f72a6

show more ...

BugFix: user name contains invalid characters

There is an typo in the policy "[a-zA-z_]" configuration.
It it should be "[a-zA-Z_]"

Tested: Create a username contains invalid characters like: ^, [,

BugFix: user name contains invalid characters

There is an typo in the policy "[a-zA-z_]" configuration.
It it should be "[a-zA-Z_]"

Tested: Create a username contains invalid characters like: ^, [, or ].

Before: invalid character can be added as username
ipmitool user list 1
ID Name Callin
4 ^test true
5 [test true
7 ]test true
8 _test true

After: error will be returned once user name has invalid character.
ipmitool user set name 4 ^test4
Set User Name command failed (user 4, name ^test4): Unspecified error

Change-Id: I28a7f36f10b44b59909536214e6688c1895ac14f
Signed-off-by: nichanghao.nch <nichanghao@linux.alibaba.com>

show more ...

Fix the bugs found in static analysis

This commit fixes the following static analyzer reported issues:

Operands don't affect result
some conditions are not required to check as its always true

Fix the bugs found in static analysis

This commit fixes the following static analyzer reported issues:

Operands don't affect result
some conditions are not required to check as its always true
Unsigned compared against 0
Unchecked return value from library
Uninitialized scalar variable

Change-Id: I0b1fd426794bb88f6eafcc817cef5dd2f655e1ba
Signed-off-by: PavanKumarIntel <pavanx.kumar.martha@intel.com>

show more ...

user_channel: strlen isn't constexpr

Change-Id: Id08b03dc487a1c772fa39459cc4e6e3138675910
Signed-off-by: Peter Foley <pefoley@google.com>

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ic5fd073faa7391d3f0b37787d6a9c7688c9a3253
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

ipmid: Update sdbuspp namespaces

Fixed all errors when we remove
`SDBUSPP_REMOVE_DEPRECATED_NAMESPACE` in sdbusplus.

Change-Id: I5607585b2709faa7aee347d26e458ef769ca1626
Signed-off-by: Willy Tu <wl

ipmid: Update sdbuspp namespaces

Fixed all errors when we remove
`SDBUSPP_REMOVE_DEPRECATED_NAMESPACE` in sdbusplus.

Change-Id: I5607585b2709faa7aee347d26e458ef769ca1626
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

treewide: Fix various compiler warnings

LTO is currently hiding these warnings.

Change-Id: I09560dfbb150f43d58f472e7592fc0c072e3cc29
Signed-off-by: William A. Kennington III <wak@google.com>

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I44441096113929ce96eb1439e2932e6ff3c87f27
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Revoking the GetUserAccess privilege for Operator

In IPMITOOL, operator can see all the accounts for "user list 3" command. This
poses a security issue. It not consistent with Redfish beheviour wher

Revoking the GetUserAccess privilege for Operator

In IPMITOOL, operator can see all the accounts for "user list 3" command. This
poses a security issue. It not consistent with Redfish beheviour where the
Operator user is unable to view other users. This change revokes the Operator
to see other users over IPMITOOL.

Tested: Operator unable to view the users through IPMI
ipmitool -I lanplus -H <ip-address> -U <userid> -P <password> -L Operator -C 17 user list 3
IPMI command failed: Insufficient privilege level

Change-Id: I5b200a85662a05bfdf1fce395e7acff6bbf1a22e
Signed-off-by: Ankita Prasad <ankita.prasad@intel.com>

show more ...

channel-config: reduce logspam

If a channel isn't configured in the channel_config, it is initialized
with `isChValid = false`, which effectively disables it. Unfortunately,
the code was also emitt

channel-config: reduce logspam

If a channel isn't configured in the channel_config, it is initialized
with `isChValid = false`, which effectively disables it. Unfortunately,
the code was also emitting a warning log for every possible channel.
On Bletchley I was observing tens of these log messages every few
seconds, which is not particularly helpful. Delete the logspam.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie130c8eb891476e26f25cafce94cb6522bc3a66e

show more ...