storagehandler: remove storagehandler.hpp

The IPMI_CMD declared in storagehandler.hpp is redundant because
these commands are already declared in api-types.hpp, so this commit
remove the storagehand

storagehandler: remove storagehandler.hpp

The IPMI_CMD declared in storagehandler.hpp is redundant because
these commands are already declared in api-types.hpp, so this commit
remove the storagehandler.hpp file.

Change-Id: I3b8beefe54833e9954525057034f382a33cb3944
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

convert storageaddsel.cpp to use lg2

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Id1a0515fecab74ff4dbb98d6a6bd47fe8b8e1558

Remove libmapper dependency

After this commit is merged [1], phosphor-ipmi-host no longer depends
on libmapper. This commit removes the dependence on libmapper.

[1] https://gerrit.openbmc.org/c/ope

Remove libmapper dependency

After this commit is merged [1], phosphor-ipmi-host no longer depends
on libmapper. This commit removes the dependence on libmapper.

[1] https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/69082

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Iacf20716b3dd02f0c3173eb6c1fcb39d416f72a6

show more ...

ipmid: Update sdbuspp namespaces

Fixed all errors when we remove
`SDBUSPP_REMOVE_DEPRECATED_NAMESPACE` in sdbusplus.

Change-Id: I5607585b2709faa7aee347d26e458ef769ca1626
Signed-off-by: Willy Tu <wl

ipmid: Update sdbuspp namespaces

Fixed all errors when we remove
`SDBUSPP_REMOVE_DEPRECATED_NAMESPACE` in sdbusplus.

Change-Id: I5607585b2709faa7aee347d26e458ef769ca1626
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

remove generated elog-errors.hpp

Remove the generated file and rely on the ones directly in
phosphor-logging.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib56e3caadeabb0a7afdd2d7

remove generated elog-errors.hpp

Remove the generated file and rely on the ones directly in
phosphor-logging.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib56e3caadeabb0a7afdd2d784dc2eb3fc8d1252c

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I44441096113929ce96eb1439e2932e6ff3c87f27
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Only include ipmid/api.hpp for the new API

After some feedback from users of the new IPMI API, they wanted to see
two things:
1) don't require ipmid/api.hpp and ipmid/registration.hpp to be able to

Only include ipmid/api.hpp for the new API

After some feedback from users of the new IPMI API, they wanted to see
two things:
1) don't require ipmid/api.hpp and ipmid/registration.hpp to be able to
write new handlers
2) only require including ipmid/api.hpp (instead of ipmid/api.h)

So now, by simply including ipmid/api.hpp instead of ipmid/api.h
(deprecated), handlers incorporating the new IPMI API can be written.

Change-Id: I446dcce70cff03d4ecc28c658292d052485f77fc
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

move types.hpp to ipmid/types.hpp for export

types.hpp is required by utility.hpp, which is exported, so it needs to
be exported as well. This moves it to the include/libipmid directory,
changes the

move types.hpp to ipmid/types.hpp for export

types.hpp is required by utility.hpp, which is exported, so it needs to
be exported as well. This moves it to the include/libipmid directory,
changes the Makefile to export it, and changes all the files that
include it so it can be found in the right place.

Change-Id: I30ec365446e4de466c266ec4faa327478460ec05
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

eSEL: Remove code related to logging eSEL

Change-Id: I5392202352c2baa70d61768cbaef9eb0e1faad56
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

Create libipmid and libipmid-host

This starts a transition to common ipmid libraries that providers can
link against. It will allow for a cleaner separation between common
ipmid functionality and da

Create libipmid and libipmid-host

This starts a transition to common ipmid libraries that providers can
link against. It will allow for a cleaner separation between common
ipmid functionality and daemon type specific code. This is needed so we
can resolve all of the symbols in the providers at link time instead of
discovering bad linkage by building and running a full ipmi daemon.

In future commits libraries will be packaged for libipmid and libipmid-host
which provide all of the symbols used by the current set of ipmid
providers.

This is the first step, it just separates and renames the headers.
Legacy symlinks are still kept around for compatability. It also adds
stub libraries so that external users can start linking as intended.

Change-Id: I6bbd7a146362012d26812a7b039d1c4075862cbd
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Revert "eSEL: Remove unused code related to logging eSEL"

This reverts commit 54fad6de0541c2f98e9b511f1d30bbcbcd743db6.

This commit is reverted because the mapping of D-Bus object path to
sensor in

Revert "eSEL: Remove unused code related to logging eSEL"

This reverts commit 54fad6de0541c2f98e9b511f1d30bbcbcd743db6.

This commit is reverted because the mapping of D-Bus object path to
sensor information is still needed. The mapping is needed to serve
the SEL commands which translate D-Bus logging objects to SEL entries.

Change-Id: I2505299671db1f0bd7f116ef0e2ca4a0273eead8

show more ...

eSEL: Remove unused code related to logging eSEL

Change-Id: Ia9815102064d20795a44b8e6a7d8b324c280756c
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

cleanup: scope reduction

[app/channel.cpp:102]: (style) The scope of the variable 'resp' can be reduced.
[ipmisensor.cpp:310]: (style) The scope of the variable 'i' can be reduced.
[ipmid.cpp:5

cleanup: scope reduction

[app/channel.cpp:102]: (style) The scope of the variable 'resp' can be reduced.
[ipmisensor.cpp:310]: (style) The scope of the variable 'i' can be reduced.
[ipmid.cpp:506]: (style) The scope of the variable 'num_handlers' can be reduced.
[read_fru_data.cpp:82]: (style) The scope of the variable 'fruId' can be reduced.
[sensorhandler.cpp:256]: (style) The scope of the variable 'p' can be reduced.
[storageaddsel.cpp:68]: (style) The scope of the variable 'p' can be reduced.

Also delete two extra vertical lines.

Change-Id: I8e72f8e1d94381f456674abf523d2f2fbdd8046d
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

cleanup: transition to find_if

[utils.cpp:81]: (style) Consider using std::find_if algorithm instead
of a raw loop.
[storageaddsel.cpp:170]: (style) Consider using std::find_if algorithm in

cleanup: transition to find_if

[utils.cpp:81]: (style) Consider using std::find_if algorithm instead
of a raw loop.
[storageaddsel.cpp:170]: (style) Consider using std::find_if algorithm instead
of a raw loop.

Change-Id: I7ebbb6428fbbae9196912837d2ac9820420b77df
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

cleanup: c-style casting

[ipmisensor.cpp:308]: (style) C-style pointer casting
[sensorhandler.cpp:302]: (style) C-style pointer casting
[sensorhandler.cpp:376]: (style) C-style pointer casting
[s

cleanup: c-style casting

[ipmisensor.cpp:308]: (style) C-style pointer casting
[sensorhandler.cpp:302]: (style) C-style pointer casting
[sensorhandler.cpp:376]: (style) C-style pointer casting
[sensorhandler.cpp:404]: (style) C-style pointer casting
[sensorhandler.cpp:405]: (style) C-style pointer casting
[storageaddsel.cpp:157]: (style) C-style pointer casting
[storageaddsel.cpp:187]: (style) C-style pointer casting
Added missing const in reportSensorEventAssert and
reportSensorEventDeassert as the *pTable->func(...) take the const
pointer and the casting then was using the proper const casting.

Change-Id: I54a591b4e5e678b8ec3cae2633617a5f7aac7a66
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

replaced c headers with cpp where applicable

Change-Id: I23a70eb540ccde5d2aba467426769feffb07b516
Signed-off-by: Patrick Venture <venture@google.com>

rename headers to match style

Moving headers from ".h" to ".hpp"

Reworked the header inclusion a bit so that host-ipmid is treated as a
library, and local headers aren't.

renamed apphandler.h => a

rename headers to match style

Moving headers from ".h" to ".hpp"

Reworked the header inclusion a bit so that host-ipmid is treated as a
library, and local headers aren't.

renamed apphandler.h => apphandler.hpp
renamed chassishandler.h => chassishandler.hpp
renamed globalhandler.h => globalhandler.hpp
renamed sensorhandler.h => sensorhandler.hpp
renamed storageaddsel.h => storageaddsel.hpp
renamed storagehandler.h => storagehandler.hpp
renamed systemintfcmds.h => systemintfcmds.hpp

Change-Id: I9d4ce3dd57e2e996800f9020a10cc10cdf2c3914
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

add .clang-format

Change-Id: I7c2a527b4751a560703a61fcbe9638b150546af5
Signed-off-by: Patrick Venture <venture@google.com>

Replace tabs with 4 spaces

replaced tabs with four spaces.

Change-Id: Ib36bf7956a280921c45a7944a972c0f19fe39e5c
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>

Reducing IPMI logging footprint

-host-ipmid is very noisy in terms of journal logging. A small step
towards cleaning that up.
-Also converted printfs to phosphor-logging.

Partially Resolves openbmc

Reducing IPMI logging footprint

-host-ipmid is very noisy in terms of journal logging. A small step
towards cleaning that up.
-Also converted printfs to phosphor-logging.

Partially Resolves openbmc/openbmc#2507

Change-Id: I749c19c18d1cabf6f0216830c8cb0a08ee43d6de
Signed-off-by: Aditya Saripalli <aditya0124@gmail.com>
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>

show more ...

Fix error level lookup

The mapping between an error level in the esel to a phosphor-logging
error level was broken. This commit fixes it.

This commits also specifies the error level while calling t

Fix error level lookup

The mapping between an error level in the esel to a phosphor-logging
error level was broken. This commit fixes it.

This commits also specifies the error level while calling the error
report() API, so that error D-Bus objects reflect the right error level
(as per the esel).

Resolves openbmc/openbmc#3014.

Change-Id: I9891d468d98d169f73275a3693df4f3a2166001d
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

Commit a MaintenanceProcedure log entry on a 0xDE SEL record

In the case of a procedure callout, HB sends a eSEL of 0xDF type.
It is followed by a Add SEL record with OEM record type 0xDE
and byte 1

Commit a MaintenanceProcedure log entry on a 0xDE SEL record

In the case of a procedure callout, HB sends a eSEL of 0xDF type.
It is followed by a Add SEL record with OEM record type 0xDE
and byte 11 in the record indicate the procedure associated
with the eSEL.

Resolves openbmc/openbmc#2368

Change-Id: Ia57f423c9d533cd8968b613d7522b409a9820198
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

show more ...

Fixed the duplicated event string in error message

The message for the host event was org.open_power.Host.Event.Error.Event,
it is corrected to org.open_power.Host.Error.Event.

Resolves openbmc/ope

Fixed the duplicated event string in error message

The message for the host event was org.open_power.Host.Event.Error.Event,
it is corrected to org.open_power.Host.Error.Event.

Resolves openbmc/openbmc#1960

Change-Id: I86304b1f2e4bec740e2e9ec58f98ea9df0d752ea
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I78e9d

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I78e9d126f19fd9fb2e3f2fa9fe8c2404dc505f82
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add inventory path metadata to host event log entry

The ESEL data contains sensor number to related to the event. The
generated code maps sensor number to inventory path. The inventory
path is added

Add inventory path metadata to host event log entry

The ESEL data contains sensor number to related to the event. The
generated code maps sensor number to inventory path. The inventory
path is added as metadata to the log entry for the admin to figure
out the inventory affected by the system event.

The generated header for Host event exception type is generated in the
org/open_power/Host/Event/error.hpp. Phosphor repositories should not
include open power specific header files. The eventual plan to is to
move the code to add ESEL to an OEM repo, till then we would check in
the header file in the repo. TODO: openbmc/openbmc#1658

The elog-errors.hpp is checked in for the CI to pass.
TODO: openbmc/openbmc#1772 issue would take care, so that CI
passes without the checking in elog-errors.hpp.

Resolves openbmc/openbmc#1920

Change-Id: I31d68de475ef84b8755c5de6d7ce6d311dd32214
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

show more ...