clang-tidy: Remove unused lambda captures

The following errors were reported during clang-tidy enablement due
to unused lambda captures.

'''
/ipmid-new.cpp:399:11: error: lambda capture 'io' is not

clang-tidy: Remove unused lambda captures

The following errors were reported during clang-tidy enablement due
to unused lambda captures.

'''
/ipmid-new.cpp:399:11: error: lambda capture 'io' is not used [-Werror
'''

The fix involves removing these unused lambda captures.

Tested: Build and unit testing verified.

Change-Id: If6113441c905cf782f26798d0e856521bd546f90
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

Allow building with boost 1.87

Boost for whatever reason added nodiscard on boost::asio::spawn. Long
term someone likely needs to move this coroutine stuff over to c++20
coroutines, but for now, pu

Allow building with boost 1.87

Boost for whatever reason added nodiscard on boost::asio::spawn. Long
term someone likely needs to move this coroutine stuff over to c++20
coroutines, but for now, put in maybe_unused where appropriate.

Change-Id: I59d1851476ed29290e260ba31ef1fe7508b3f441
Signed-off-by: Ed Tanous <ed@tanous.net>

show more ...

Revert "drop sdevents hack"

This reverts commit d2dd5bc2eddc73504734112c0d6f745202b1b3a0.

The commit was inadvertently merged upstream.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-I

Revert "drop sdevents hack"

This reverts commit d2dd5bc2eddc73504734112c0d6f745202b1b3a0.

The commit was inadvertently merged upstream.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icf03e2ca476271b4606500846593e36fe326f3c5

show more ...

drop sdevents hack

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I04833cc2a39c032a4d9c29079ee92fdf24c89245

boost version 1.86 support

Added fix for boost::asio::spawn overload issue reported similar
to chriskohlhoff/asio#1524, during boost 1.86 migration build.

Proposed fix is to use default completion

boost version 1.86 support

Added fix for boost::asio::spawn overload issue reported similar
to chriskohlhoff/asio#1524, during boost 1.86 migration build.

Proposed fix is to use default completion token.

Tested: verified build

Change-Id: Ie3ebcf963f998fd6064e8efab49d1fe584d4b587
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I01547e98d27910919e09ebf7907c86292a6c825d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

convert ipmid-new.cpp to use lg2

Change-Id: I0ebb51a11032c5925c0f2c2f949dd064bc5a8673
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

sdbusplus: avoid deprecated phosphor::Timer

sdbusplus had an older type named `phosphor::Timer` which was
recently renamed to `sdbusplus::Timer`. Update the code to use
the new type alias.

Change-

sdbusplus: avoid deprecated phosphor::Timer

sdbusplus had an older type named `phosphor::Timer` which was
recently renamed to `sdbusplus::Timer`. Update the code to use
the new type alias.

Change-Id: If69434b3a3639b8f97ab16cab5da4d70e3379cb2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ic5fd073faa7391d3f0b37787d6a9c7688c9a3253
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

more debug logs for ipmi OEM commands

- log IANA as unpacked from request
- log if the request was filtered
- log sucessful / unsucessful registering of OEM Command Handler

Tested: ipmid logs the e

more debug logs for ipmi OEM commands

- log IANA as unpacked from request
- log if the request was filtered
- log sucessful / unsucessful registering of OEM Command Handler

Tested: ipmid logs the expected messages.

Change-Id: If4387d2d1927768f697e29d2230d9e3491e8ed48
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

change to use non-deprecated dcmi group value

All new code should be using the constants from the
new API, rather than the old code. This is a minor change
to remove usage of the DCMI group value fr

change to use non-deprecated dcmi group value

All new code should be using the constants from the
new API, rather than the old code. This is a minor change
to remove usage of the DCMI group value from all internal
phosphor-ipmi-host code.

Change-Id: Ib4b44bbb4a40945639eeb0f72e817f3dc716903b
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I44441096113929ce96eb1439e2932e6ff3c87f27
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

remove return statement for void function

The function signature shows return type void, the return statement
returns a value from a function that is void, so while not really an
error right now, co

remove return statement for void function

The function signature shows return type void, the return statement
returns a value from a function that is void, so while not really an
error right now, could be if the called function signature changed.

Tested: Builds as expected.

Change-Id: If93fcf531c173dfeb7048afbb50e365c538a0b45
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibd2a0b512bfb7caf65bfab64b271d194da520aac

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic2b49715c7b81ac5bcfc12ff2d3b4c593cd95ce7

properly handle unexpected exceptions

Prior code followed a poorly explained example and then would
just re-throw the exception without actually catching it. The
new code (while specific to gcc and

properly handle unexpected exceptions

Prior code followed a poorly explained example and then would
just re-throw the exception without actually catching it. The
new code (while specific to gcc and clang) will log the unexpected
exception type so it will not be fatal.

Tested: throw an std::string in a handler and see that it is not fatal.
MESSAGE=Handler failed to catch exception
EXCEPTION=std::__cxx11::basic_string<char,
std::char_traits<char>, std::allocator<char> >

Change-Id: I4734aba8ea6fb02ad8ce54be55e860d2b4c6576c
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Add a SecureBuffer class

SecureBuffer is like SecureString, but a specialization of
std::vector<uint8_t> that cleans up after itself

Tested: Executed various ipmi commands to see that they still wo

Add a SecureBuffer class

SecureBuffer is like SecureString, but a specialization of
std::vector<uint8_t> that cleans up after itself

Tested: Executed various ipmi commands to see that they still work

Change-Id: Ifd255ef682d6e46d981de6a5a294d12f3666698b
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Fix static analysis (uninitialized var) warnings

Initialized variables with default value

Tested:
Build got successful

Signed-off-by: Snehalatha Venkatesh <snehalathax.v@intel.com>
Change-Id: Ied1

Fix static analysis (uninitialized var) warnings

Initialized variables with default value

Tested:
Build got successful

Signed-off-by: Snehalatha Venkatesh <snehalathax.v@intel.com>
Change-Id: Ied1a5e188d49e28d0b64a20ff9f31016735b82c2

show more ...

Do not insert twice for first filter

On the first call, the filter list is empty,
the element will be insert two times, just return after the first insert.

Tested:
Check the filter callback functio

Do not insert twice for first filter

On the first call, the filter list is empty,
the element will be insert two times, just return after the first insert.

Tested:
Check the filter callback functions, there is no duplicated call;

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: I4e4d5147b5c0466b651700f79afcb34940e6f48a

show more ...

phosphor-host-ipmid : yosemitev2: Add host Identification support

Added host Identification support in ipmid. This helps to
identify the particular hosts. The channel indexes for
hosts are getting f

phosphor-host-ipmid : yosemitev2: Add host Identification support

Added host Identification support in ipmid. This helps to
identify the particular hosts. The channel indexes for
hosts are getting from ipmb json config and passed from ipmb.

TESTED : Built Facebook YosemiteV2 & Tiogapass images and loaded on
the target hardware. We are able to see hostId's for all the hosts.

Note : This is the follow-up patch for multiple channels
support in ipmbbridge.
https://gerrit.openbmc-project.xyz/c/openbmc/ipmbbridge/+/34579

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: I01f1783f6c95780a62639d5ce9edc0b420d57be9

show more ...

Fix includes

This patchset tries to fix some of the include problems in
phosphor-ipmi-host. First, it relies on io_service, which is
deprecated, and will not compile in boost 1.74. It also relies

Fix includes

This patchset tries to fix some of the include problems in
phosphor-ipmi-host. First, it relies on io_service, which is
deprecated, and will not compile in boost 1.74. It also relies on the
fact that sdbusplus #includes <asio.hpp> as a whole, this patchset makes
it add the correct includes, so it can compile on its own, and we can
improve compile times by removing asio.hpp from sdbusplus.

Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I0ab3b202b07a716368711dc6528d984c73bcb9d9

show more ...

Add LUN to the IPMI sensor context structure

Systems monitored by BMCs may have more than 255 sensors. This code
change provides the necessary piece to allow a BMC to support more
than 255 sensors.

Add LUN to the IPMI sensor context structure

Systems monitored by BMCs may have more than 255 sensors. This code
change provides the necessary piece to allow a BMC to support more
than 255 sensors. It does this by adding a variable to store a LUN
value. This allows LUN 0 to manage 255 sensors, and any overflow may
be assigned to LUN 1.

Tested:

Confirmed the following commands still work:
"ipmitool sdr elist"
"ipmitool sensor list"
"ipmitool raw 4 0x20 0"
"ipmitool raw -l 1 4 0x20 0"

Change-Id: I92d5205eac33829d8133f2e38ed96bfc5a9bc033
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

ipmid: allow command not found for filtered commands

Filters are executed first and the actual ipmi command handler will not
execute if the filter rejects it for any reason.

However, if a filter re

ipmid: allow command not found for filtered commands

Filters are executed first and the actual ipmi command handler will not
execute if the filter rejects it for any reason.

However, if a filter returns a value for a command that is not even
implemented, the old logic would return that value instead of command
not implemented (C1h). This is incorrect behavior.

This fix will run the filter and then check to see if the command is
registered. If the command is registered AND the filter has returned
some error, only then will the filter error get returned. If the command
is registered and the filter returns no error, the command is executed.
If the command is not registered, C1h is returned, as per the spec.

Tested:
1) Add some bogus command definitions to the whitelist filter
2) Run the bogus command
3) See that C1h is returned, not insufficient privilege

Change-Id: I069df8f47a169d6b2961460a561bf9cae6ae285c
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

[ipmid]: Advertise D-Bus signals, only when ready

Requesting the bus name & sending out InterfacesAdded signal earlier
causes phosphor-mapper introspect to fail, as ipmi command handler
registration

[ipmid]: Advertise D-Bus signals, only when ready

Requesting the bus name & sending out InterfacesAdded signal earlier
causes phosphor-mapper introspect to fail, as ipmi command handler
registration & initialization was in progress before hitting io->run().
Hence moved the code to advertise about D-Bus signal, once ipmid is done
with init & registration. This fixes phosphor-mapper timeout.

Tested:
1. Verified that phosphor-mapper timeout doesn't happen, even when
there is delay in cmd handler registrations etc.

Change-Id: I3bb565c0e39f2604dde30e21b9539ce88b73cb0e
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Provide proper exit code for signals

Currently ipmid only exits 0, allow it to exit based
on the signal captured.

Tested:

journalctl -u phosphor-pid-control -o json-pretty

{
"_SYSTEMD_SLI

Provide proper exit code for signals

Currently ipmid only exits 0, allow it to exit based
on the signal captured.

Tested:

journalctl -u phosphor-pid-control -o json-pretty

{
"_SYSTEMD_SLICE" : "-.slice",
"_GID" : "0",
"_CAP_EFFECTIVE" : "3fffffffff",
"MESSAGE" : "phosphor-ipmi-host.service: Main process exited, code=killed, status=9/KILL",
"EXIT_STATUS" : "9",
"__CURSOR" : "s=cd10fcb9010e4cfdbcdad08709c2265d;i=399;b=2efcc2f735f74bc99588861556589a72;m=7c0ed53;t=592853b62b677;x=1ae3833ab435621e",
"__MONOTONIC_TIMESTAMP" : "130084179",
"MESSAGE_ID" : "98e322203f7a4ed290d09fe03c09fe15",
"_EXE" : "/lib/systemd/systemd",
"CODE_LINE" : "5797",
"UNIT" : "phosphor-ipmi-host.service",
"_SYSTEMD_CGROUP" : "/init.scope",
"_SYSTEMD_UNIT" : "init.scope",
"SYSLOG_IDENTIFIER" : "systemd",
"_COMM" : "systemd",
"_UID" : "0",
"PRIORITY" : "4",
"_HOSTNAME" : "intel-obmc",
"SYSLOG_FACILITY" : "3",
"CODE_FILE" : "src/core/unit.c",
"CODE_FUNC" : "unit_log_process_exit",
"_CMDLINE" : "/lib/systemd/systemd",
"__REALTIME_TIMESTAMP" : "1568475808183927",
"_SOURCE_REALTIME_TIMESTAMP" : "1568475808183827",
"COMMAND" : "ExecStart",
"INVOCATION_ID" : "67ff87a3ad4b4a4da3fe7e0ff083e2b8",
"_TRANSPORT" : "journal",
"_MACHINE_ID" : "f7182be05e2147feba2eaceaea0aded3",
"_BOOT_ID" : "2efcc2f735f74bc99588861556589a72",
"EXIT_CODE" : "killed",
"_PID" : "1"
}

Change-Id: I9f3233546b43a331076d21b73beabbf2aaca9d8b
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...