Remove unused variables

Using clang-tidy, it was detected that some variables are no longer
in use. This commit remove unused variables.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id

Remove unused variables

Using clang-tidy, it was detected that some variables are no longer
in use. This commit remove unused variables.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I382e6ce07e66dc5ad082be9b36d217a037e609b5

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I01547e98d27910919e09ebf7907c86292a6c825d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

convert ipmi_fru_info_area.cpp to use lg2

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ibf3f513d8b7f32d205e912918c67badcc32c6876

ipmid: fru-reader: Use timegm instead of mktime

timegm is the inverse of gmtime. Currently, we are missing UTC time with
localtime when converting between timestamp and time string. This is not
an i

ipmid: fru-reader: Use timegm instead of mktime

timegm is the inverse of gmtime. Currently, we are missing UTC time with
localtime when converting between timestamp and time string. This is not
an issue when the localtime is the same as UTC.

This issue is detected when we change the timezone to PST/PDT with
https://gerrit.openbmc.org/c/openbmc/openbmc/+/58293
and the FRU EEPROM time does not match the expected Mfg Date anymore.

Required:
https://gerrit.openbmc.org/c/openbmc/ipmi-fru-parser/+/58446

Tested:
Fru EEPROM Mfg Time now is in the same (after timezone conversion)
between the raw data and FRU output.

Change-Id: I4c636b0044e1b2a6dd2c078b62f65665d4b1108c
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I44441096113929ce96eb1439e2932e6ff3c87f27
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic2b49715c7b81ac5bcfc12ff2d3b4c593cd95ce7

ipmi_fru_info_area: remove move calls

error: moving a temporary object prevents copy elision

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I054d8b395661545413e320673699153b2b48e28e

ipmi_fru_info_area: Fix Model Number name

The FRU parser has always used the string `Model Number` for the IPMI
FRU property name. The change 45e93cbae0aa0d0f5385d40f5685b23e18f95351
broke reading t

ipmi_fru_info_area: Fix Model Number name

The FRU parser has always used the string `Model Number` for the IPMI
FRU property name. The change 45e93cbae0aa0d0f5385d40f5685b23e18f95351
broke reading this value since it stopped using the DBus property name
and switched to the FRU parser name.

Change-Id: Ie83f1a576680b7254f7858daacdc8803049b66f0
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Increase FRU data field length up to 63 bytes

IPMI spec v2.0 rev. 1.1, the type/length byte (section 43.15)
has bit 5 reserved and only bits [4:0] for data length (with value 11111b reserved),
which

Increase FRU data field length up to 63 bytes

IPMI spec v2.0 rev. 1.1, the type/length byte (section 43.15)
has bit 5 reserved and only bits [4:0] for data length (with value 11111b reserved),
which limits the data length up to 31 bytes max.

However, FRU spec v1.0 rev. 1.3, the type/length byte (section 13)
has bits [5:0] used for data length, allowing up to 63 bytes of data.

Change-Id: I105b58fba04cdfed1f338284ac1454fd11784cc5
Signed-off-by: Kirill Pakhomov <k.pakhomov@yadro.com>

show more ...

fru: support two time string formats

Support parsing two time string formats to enable use of ipmi-fru-parser
and entity-manager to provide FRU details on dbus.

Tested: Verified the entity-manager

fru: support two time string formats

Support parsing two time string formats to enable use of ipmi-fru-parser
and entity-manager to provide FRU details on dbus.

Tested: Verified the entity-manager dbus output for the FRU MfgDate is
now parsed correctly.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I053ec225b51166269c5a5a800ad8d607fd0cc233

show more ...

fru: use ipmifruproperty for property lookup

The member IPMIFruData::property was unused and instead the property
lookup was performed with the phosphor-dbus-interface property name.
The IPMIFruData

fru: use ipmifruproperty for property lookup

The member IPMIFruData::property was unused and instead the property
lookup was performed with the phosphor-dbus-interface property name.
The IPMIFruData::property field is meant to map from dbus property to
FRU property to allow a variety of dbus mappings.

Tested: Verified the member was unused.
Tested: Verified that a configuration yaml mapping is respected and
ipmid will report the information expected given a FRU published to
dbus.
Note: The fields for IPMI FRU properties were taken from the example
YAML and are expected to be what was used by machines leveraging this
feature.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I44f73b67ecdeae2d772daa38cc21cc18cdf9c7ce

show more ...

ipmi_fru_info_area: Handle exception during parsing of chassis type

This is a fix for 40f59e2c50572705496ae743577f124f24afd77e.

Change-Id: I850f87968600759c2758841803ebd23c0856319d
Signed-off-by: O

ipmi_fru_info_area: Handle exception during parsing of chassis type

This is a fix for 40f59e2c50572705496ae743577f124f24afd77e.

Change-Id: I850f87968600759c2758841803ebd23c0856319d
Signed-off-by: Oskar Senft <osk@google.com>

show more ...

ipmi_fru_info_area: Pad output buffer.

Always pad the output buffer to the maximum IPMI FRU size. This enables
tools like ipmitool to write a new FRU blob with data longer than the
original payload.

ipmi_fru_info_area: Pad output buffer.

Always pad the output buffer to the maximum IPMI FRU size. This enables
tools like ipmitool to write a new FRU blob with data longer than the
original payload.

Change-Id: Id6eb2c80504fb42ac72d7b643d186e9641a0832c
Signed-off-by: Oskar Senft <osk@google.com>

show more ...

ipmi_fru_info_area: Add support for chassis type

Change-Id: Ifd89fb37dc8515757d6014edeb028eb25e37bb95
Signed-off-by: Oskar Senft <osk@google.com>

add std namespace prefix to common methods

Standard clib methods should be explicitly grabbed from the standard
namespace.

Change-Id: I8bcfcb260a99180d535ec8102c1a24c318cbc209
Signed-off-by: Patric

add std namespace prefix to common methods

Standard clib methods should be explicitly grabbed from the standard
namespace.

Change-Id: I8bcfcb260a99180d535ec8102c1a24c318cbc209
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

add .clang-format

Change-Id: I7c2a527b4751a560703a61fcbe9638b150546af5
Signed-off-by: Patrick Venture <venture@google.com>

Validate Mfg Date/Time in Board Info Area

-FRU's Mfg Date/Time is the number of minutes from 0:00 hrs
1/1/96 and a 3 byte field length for Mfg Data/Time in Board Info Area.
-So max Mfg date equals t

Validate Mfg Date/Time in Board Info Area

-FRU's Mfg Date/Time is the number of minutes from 0:00 hrs
1/1/96 and a 3 byte field length for Mfg Data/Time in Board Info Area.
-So max Mfg date equals to 1006632900 secs from 00:00:00 hrs 1/1/1996.

Resolves openbmc/openbmc#3202

Change-Id: I6a71b8b881b699195fee2a18b743e195fa4703a5
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>

show more ...

Fix FRU BuildDate DBus/IPMI exporting

When BMC exports the date into DBUS it translates/expands the 3 bytes FRU
format date into an easy to read string as in "2015-11-06 - 22:23:00", when
exporting

Fix FRU BuildDate DBus/IPMI exporting

When BMC exports the date into DBUS it translates/expands the 3 bytes FRU
format date into an easy to read string as in "2015-11-06 - 22:23:00", when
exporting the DBUS date back to IPMI it needs to translate back this date
into the 3 bytes FRU format, without this fix we get a build date in 1996
that is the epoch for the FRU date format. This change reconstructs the
FRU date from the easy to read string for exporting into IPMI.

Tested: Manual check that BuildDate from busctl and ipmitool match

Resolves openbmc/openbmc#3013

Change-Id: I0fd1dd8f945f18b53c14bff321c9e233fdb2d742
Signed-off-by: Andres Oportus <andresoportus@google.com>

show more ...

Fix the typo

Change-Id: I5eff36514969ca7e301578f0913b5da250b426c9
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

FRU: Change the type code to ASCII

In board and product area format there is type and length
field for each field.

6-7 bit of typelength field specifies the type and first
five bits specify the len

FRU: Change the type code to ASCII

In board and product area format there is type and length
field for each field.

6-7 bit of typelength field specifies the type and first
five bits specify the length.a

eg:- Board Manufacturer type/length byte followed by actual
number of bytes defined in first five bits of type length
of Board Manufacturer field.

Change-Id: Iaaf608cc93829fb1dd8d0c54a49bd467a7cadbea
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

FRU: Fix the area offset calculation of Read FRU Data response

Common header contains the offset of areas
This commit fixes the offset calculation.

Change-Id: Iba002d1832063a329df43834d4e30d359ecaf

FRU: Fix the area offset calculation of Read FRU Data response

Common header contains the offset of areas
This commit fixes the offset calculation.

Change-Id: Iba002d1832063a329df43834d4e30d359ecaf7b0
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

construct IPMI FRU Info data based on inventory data

Change-Id: If8ee75b48323d29b568ef807d381a3e5600527d5
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>