globalhandler: switch to asynchronous dbus calls

Use the latest asynchronous D-Bus method calls instead of synchronous
methods.

Change-Id: I1afd8a526f8dbed6359d93ec4a1a4e0853f205de
Signed-off-by: G

globalhandler: switch to asynchronous dbus calls

Use the latest asynchronous D-Bus method calls instead of synchronous
methods.

Change-Id: I1afd8a526f8dbed6359d93ec4a1a4e0853f205de
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

Update the registered IPMI method name

Update registered IPMI method names to use `Lower Camel Case`.

Change-Id: I5539771c4ba8567f6cdb22aa3c8df58db5e883f2
Signed-off-by: George Liu <liuxiwei@ieisys

Update the registered IPMI method name

Update registered IPMI method names to use `Lower Camel Case`.

Change-Id: I5539771c4ba8567f6cdb22aa3c8df58db5e883f2
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

globalhandler: remove globalhandler.hpp

The IPMI_CMD declared in globalhandler.hpp is redundant because these
commands are already declared in api-types.hpp, so this commit
remove the globalhandler.

globalhandler: remove globalhandler.hpp

The IPMI_CMD declared in globalhandler.hpp is redundant because these
commands are already declared in api-types.hpp, so this commit
remove the globalhandler.hpp file.

Change-Id: Id4b41ca90cd5f1ceb2179cefc237f5117ac9e14c
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I01547e98d27910919e09ebf7907c86292a6c825d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

convert globalhandler.cpp to use lg2

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I813779ee83fa19df01afd0b5c1cfd6294d3be777

ipmid: Update sdbuspp namespaces

Fixed all errors when we remove
`SDBUSPP_REMOVE_DEPRECATED_NAMESPACE` in sdbusplus.

Change-Id: I5607585b2709faa7aee347d26e458ef769ca1626
Signed-off-by: Willy Tu <wl

ipmid: Update sdbuspp namespaces

Fixed all errors when we remove
`SDBUSPP_REMOVE_DEPRECATED_NAMESPACE` in sdbusplus.

Change-Id: I5607585b2709faa7aee347d26e458ef769ca1626
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I44441096113929ce96eb1439e2932e6ff3c87f27
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibd2a0b512bfb7caf65bfab64b271d194da520aac

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic2b49715c7b81ac5bcfc12ff2d3b4c593cd95ce7

Remove the global warm reset ipmi command

This warm reset command is using the duplicated API as cold reset.
As per IPMI spec, warm reset should not alter volatile settings,
and has to just reset th

Remove the global warm reset ipmi command

This warm reset command is using the duplicated API as cold reset.
As per IPMI spec, warm reset should not alter volatile settings,
and has to just reset the interface which is not what current code does.
Hence to avoid confusion, remove this warm reset command

Tested:
"ipmitool raw 6 3" command return "Invalid command",
and BMC does not reboot

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: I62f37c9b8386a817ce069c26ade6760de73b1d16
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>

show more ...

globalhandler: move cold & warm reset to new API

Rewritten "cold & warm reset" command to use the newly
introduced IPMI provider API.

Tested:
verified ipmitool cold reset and warm reset commands

i

globalhandler: move cold & warm reset to new API

Rewritten "cold & warm reset" command to use the newly
introduced IPMI provider API.

Tested:
verified ipmitool cold reset and warm reset commands

ipmitool raw 6 2 //cold reset command
system reboots

ipmitool raw 6 3 //warm reset command
system reboots

Change-Id: I4638fffe33deb1c97f51f97c8f09fef6a8688fba
Signed-off-by: anil kumar appana <anil.kumarx.appana@intel.com>
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Only include ipmid/api.hpp for the new API

After some feedback from users of the new IPMI API, they wanted to see
two things:
1) don't require ipmid/api.hpp and ipmid/registration.hpp to be able to

Only include ipmid/api.hpp for the new API

After some feedback from users of the new IPMI API, they wanted to see
two things:
1) don't require ipmid/api.hpp and ipmid/registration.hpp to be able to
write new handlers
2) only require including ipmid/api.hpp (instead of ipmid/api.h)

So now, by simply including ipmid/api.hpp instead of ipmid/api.h
(deprecated), handlers incorporating the new IPMI API can be written.

Change-Id: I446dcce70cff03d4ecc28c658292d052485f77fc
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Move util.cpp/util.hpp to libipmid

These are functions that are used widely by ipmid providers, so it makes
sense to put them in libipmi.so (the library that all providers must
link against).

Teste

Move util.cpp/util.hpp to libipmid

These are functions that are used widely by ipmid providers, so it makes
sense to put them in libipmi.so (the library that all providers must
link against).

Tested-by: use nm to inspect the binaries to see that the symbols are in
the expected library.

arm-openbmc-linux-gnueabi-nm libipmid.so.0.0.0 \
| grep getDbusObject
0001063c T _ZN4ipmi13getDbusObjectERN9sdbusplus....

Change-Id: I1221f807f2711c5301c5574623564ea1ae48a437
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Create libipmid and libipmid-host

This starts a transition to common ipmid libraries that providers can
link against. It will allow for a cleaner separation between common
ipmid functionality and da

Create libipmid and libipmid-host

This starts a transition to common ipmid libraries that providers can
link against. It will allow for a cleaner separation between common
ipmid functionality and daemon type specific code. This is needed so we
can resolve all of the symbols in the providers at link time instead of
discovering bad linkage by building and running a full ipmi daemon.

In future commits libraries will be packaged for libipmid and libipmid-host
which provide all of the symbols used by the current set of ipmid
providers.

This is the first step, it just separates and renames the headers.
Legacy symlinks are still kept around for compatability. It also adds
stub libraries so that external users can start linking as intended.

Change-Id: I6bbd7a146362012d26812a7b039d1c4075862cbd
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

replaced c headers with cpp where applicable

Change-Id: I23a70eb540ccde5d2aba467426769feffb07b516
Signed-off-by: Patrick Venture <venture@google.com>

rename headers to match style

Moving headers from ".h" to ".hpp"

Reworked the header inclusion a bit so that host-ipmid is treated as a
library, and local headers aren't.

renamed apphandler.h => a

rename headers to match style

Moving headers from ".h" to ".hpp"

Reworked the header inclusion a bit so that host-ipmid is treated as a
library, and local headers aren't.

renamed apphandler.h => apphandler.hpp
renamed chassishandler.h => chassishandler.hpp
renamed globalhandler.h => globalhandler.hpp
renamed sensorhandler.h => sensorhandler.hpp
renamed storageaddsel.h => storageaddsel.hpp
renamed storagehandler.h => storagehandler.hpp
renamed systemintfcmds.h => systemintfcmds.hpp

Change-Id: I9d4ce3dd57e2e996800f9020a10cc10cdf2c3914
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

add .clang-format

Change-Id: I7c2a527b4751a560703a61fcbe9638b150546af5
Signed-off-by: Patrick Venture <venture@google.com>

Remove use of legacy bmc control interface

Tested:
Tested using below given command for cold/warm resets
>ipmitool mc reset [ warm | cold ] -I dbus

Resolves openbmc/openbmc#2919

Change-Id: I15fc5a

Remove use of legacy bmc control interface

Tested:
Tested using below given command for cold/warm resets
>ipmitool mc reset [ warm | cold ] -I dbus

Resolves openbmc/openbmc#2919

Change-Id: I15fc5ab53b7d8b2b17bc9fa8f3f2030e93bd0483
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>

show more ...

Add privilege level for each IPMI command

Change-Id: I07f160c6ea83dc91f46e21f263c4cf994aff081d
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

global: replace mapper method with library call

Use the sdbus client binding for this to protect
from changes within the binding itself.

Change-Id: I152b254bbf21360a5096d9e0f48bd99fc29d737b
Signed-

global: replace mapper method with library call

Use the sdbus client binding for this to protect
from changes within the binding itself.

Change-Id: I152b254bbf21360a5096d9e0f48bd99fc29d737b
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Add IPMI coldReset command support

* Implement by calling dbus method for coldReset
* Optimize warmReset/coldReset code
* Be implemented with related changes in skeleton repository

Resolves openbmc

Add IPMI coldReset command support

* Implement by calling dbus method for coldReset
* Optimize warmReset/coldReset code
* Be implemented with related changes in skeleton repository

Resolves openbmc/openbmc#437

Change-Id: Ia33805c73b5d345419918c467ef7b9cf6fbb246d
Signed-off-by: Nan Li <william.bjlinan@hotmail.com>

show more ...

Ensure all tools are building with -Wall and -Werror

Corrected resulting compiler errors from correctly adding -Wall &
-Werror within configure.ac.

Change-Id: Ia7aaafa83103322ad4b50171d62144624dd71

Ensure all tools are building with -Wall and -Werror

Corrected resulting compiler errors from correctly adding -Wall &
-Werror within configure.ac.

Change-Id: Ia7aaafa83103322ad4b50171d62144624dd71e42
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Allow out-of-tree builds

Change-Id: If4b97e65f63c3abbf23140dd97b9febe00b3be0d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

Switch C++ source files to .cpp extension

Change-Id: I495186b4afd58ec1e5d9d5c6472394f96541d17d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>