7acc8a2d | 08-Dec-2024 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy: Initial commit
Enabled minimum checks now for validating the clang-tidy feature.
Additionally: - Disable all checks by default. - Treat all warnings as errors. - Apply checks to a
clang-tidy: Initial commit
Enabled minimum checks now for validating the clang-tidy feature.
Additionally: - Disable all checks by default. - Treat all warnings as errors. - Apply checks to all files except subproject headers.
Tested: Verified build.
Change-Id: Ibe298cc0fd835f6e28baa15e194c401884c24fa6 Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
9db18cdb | 07-Mar-2025 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy: fix unused parameters warning
Updated the Handler lambda function to include the [[maybe_unused]] attribute for the unused parameter.
Change-Id: I087e546967eacc3bed838a98e711ee3af3c0136
clang-tidy: fix unused parameters warning
Updated the Handler lambda function to include the [[maybe_unused]] attribute for the unused parameter.
Change-Id: I087e546967eacc3bed838a98e711ee3af3c0136c Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
3ad19716 | 26-Jan-2025 |
Lei YU <yulei.sh@bytedance.com> |
Fix clang++ warnings
To enable clang-tidy, fix the build warnings by clang++.
Signed-off-by: Lei YU <yulei.sh@bytedance.com> Change-Id: I4a1e8dd897f631493e9600267b3b9b999cda902b |
9706bc8d | 17-Mar-2025 |
Jayanth Othayoth <ojayanth@gmail.com> |
Fix include path for message.hpp
This resolves the below compilation error related to the missing message.hpp file during full build.
''' usr/include/ipmid/message/pack.hpp:18:10: fatal error: incl
Fix include path for message.hpp
This resolves the below compilation error related to the missing message.hpp file during full build.
''' usr/include/ipmid/message/pack.hpp:18:10: fatal error: include/ipmid/message.hpp: No such file or directory '''
Updated the include directive to use the correct relative path for message.hpp
Change-Id: Ice8a60a7030448ce75f0fa255ded9117beb1a71f Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
8c1376ca | 05-Jan-2024 |
Chau Ly <chaul@amperecomputing.com> |
chassishandler: Interpret intrusion sensor values
Chassis Intrusion Sensor value on D-Bus was updated with new format that adapts PDI enum definition [1]. This patch modifies how the value from D-Bu
chassishandler: Interpret intrusion sensor values
Chassis Intrusion Sensor value on D-Bus was updated with new format that adapts PDI enum definition [1]. This patch modifies how the value from D-Bus be interpreted to adapt with the change from D-Bus. This commit uses GetSubTree to look for all object paths that implement the Chassis Intrusion interface, instead of using hardcoded path. phosphor-dbus-interfaces class is used to ensure consistency.
When more than one path is returned from GetSubTree. If all the Status values are Normal, the final result is inactive. If one of the Status value is not Normal, the final result is active. If no Status value can be read from D-Bus, the final result is inactive.
[1]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Chassis/Intrusion.interface.yaml#L30
Tested: If value on D-Bus is: "xyz.openbmc_project.Chassis.Intrusion.Status.Normal" $ ipmitool chassis status | grep -i intrusion Chassis Intrusion: inactive
Otherwise, Chassis Intrusion: active
Signed-off-by: Chau Ly <chaul@amperecomputing.com> Change-Id: I3bf7d6c8db9d8537cde10a8e8b20d325b86a9c73
show more ...
|
c84add58 | 07-Mar-2025 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy: rename mako file extesnsion
Renamed mako.cpp to cpp.mako to prevent clang-tidy from running checks on this file. Also updated build scripts to accommodate the new file extension.
Change
clang-tidy: rename mako file extesnsion
Renamed mako.cpp to cpp.mako to prevent clang-tidy from running checks on this file. Also updated build scripts to accommodate the new file extension.
Change-Id: I2ad35ec653cb3ebf684ddd0ba697a966fe7ed540 Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
13d938cd | 07-Mar-2025 |
Jayanth Othayoth <ojayanth@gmail.com> |
Fix: Update Boost header file inclusion
This change resolves issues related to the use of deprecated header files.
Change-Id: Ic3b0d658f3c82431accec34f0fdb63d9395ad49b Signed-off-by: Jayanth Othayo
Fix: Update Boost header file inclusion
This change resolves issues related to the use of deprecated header files.
Change-Id: Ic3b0d658f3c82431accec34f0fdb63d9395ad49b Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
a8205ff6 | 07-Mar-2025 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy: fix use of undeclared identifier error
This commit resolves the clang-diagnostic-error related to missing identifiers by ensuring all necessary header files are included in the same sour
clang-tidy: fix use of undeclared identifier error
This commit resolves the clang-diagnostic-error related to missing identifiers by ensuring all necessary header files are included in the same source file.
Also Correct undeclared identifier 'cmdWildcard' to 'ipmi::cmdWildcard'
Change-Id: Ic818af97557c7bc74b7fc9478315fe181a9a4cfc Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
3022f1f3 | 07-Mar-2025 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy:test fix file not found error
This commit resolves the clang-diagnostic-error related to the missing 'sample.h' file.
Change-Id: I2cd7afe57362eba18f2d2a08c09947c8118e2a74 Signed-off-by:
clang-tidy:test fix file not found error
This commit resolves the clang-diagnostic-error related to the missing 'sample.h' file.
Change-Id: I2cd7afe57362eba18f2d2a08c09947c8118e2a74 Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
a6c307a8 | 08-Dec-2024 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy: Fix Dangling Pointer Warning
The following error was reported during clang-tidy enablement due to a temporary object being destroyed at the end of the full-expression, leaving a dangling
clang-tidy: Fix Dangling Pointer Warning
The following error was reported during clang-tidy enablement due to a temporary object being destroyed at the end of the full-expression, leaving a dangling pointer. This fix addresses the issue by changing str to a proper string instead of a string_view.
''' 0m../apphandler.cpp:545:36: error: object backing the pointer will be destroyed at the end of the full-expression [-Werror 0m../apphandler.cpp:564:40: error: object backing the pointer will be destroyed at the end of the full-expression [-Werror 1m../apphandler.cpp:523:36: error: object backing the pointer will be destroyed at the end of the full-expression [-Werror '''
Tested: Build and unit testing verified.
Change-Id: I4f8f2dc3f24a4e417e6805075cfaefddb111efaa Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
a6fb32d8 | 15-Dec-2024 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy: Replace NULL with nullptr
Replaced all instances of NULL with nullptr to improve type safety and clarity, as nullptr is the modern C++ standard for null pointers.
Tested: Build verified
clang-tidy: Replace NULL with nullptr
Replaced all instances of NULL with nullptr to improve type safety and clarity, as nullptr is the modern C++ standard for null pointers.
Tested: Build verified
Change-Id: Ia40d9435ab57651ec6d13d5408cf69130043fa79 Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
ceee811e | 08-Dec-2024 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy: Fix braces warning
The following error was reported during clang-tidy enablement due to the initialization of a subobject without braces in apphandler.cpp. This fix addresses the issue b
clang-tidy: Fix braces warning
The following error was reported during clang-tidy enablement due to the initialization of a subobject without braces in apphandler.cpp. This fix addresses the issue by modifying the initialization to include braces around each subobject.
''' apphandler.cpp:653:31: error: suggest braces around initialization of subobject [-Werror] '''
Tested: Build and unit testing verified.
Change-Id: Icfe58be0ff65ae17fc8f6a7c1f5ac06aedbb1e61 Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
9f3073a6 | 08-Dec-2024 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy: Remove unused lambda captures
The following errors were reported during clang-tidy enablement due to unused lambda captures.
''' /ipmid-new.cpp:399:11: error: lambda capture 'io' is not
clang-tidy: Remove unused lambda captures
The following errors were reported during clang-tidy enablement due to unused lambda captures.
''' /ipmid-new.cpp:399:11: error: lambda capture 'io' is not used [-Werror '''
The fix involves removing these unused lambda captures.
Tested: Build and unit testing verified.
Change-Id: If6113441c905cf782f26798d0e856521bd546f90 Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
082de3c9 | 03-Mar-2025 |
George Liu <liuxiwei@ieisystem.com> |
globalhandler: switch to asynchronous dbus calls
Use the latest asynchronous D-Bus method calls instead of synchronous methods.
Change-Id: I1afd8a526f8dbed6359d93ec4a1a4e0853f205de Signed-off-by: G
globalhandler: switch to asynchronous dbus calls
Use the latest asynchronous D-Bus method calls instead of synchronous methods.
Change-Id: I1afd8a526f8dbed6359d93ec4a1a4e0853f205de Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
69b4c281 | 03-Mar-2025 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: update latest spec and reformat
Copy the latest format file from the docs repository and apply.
Change-Id: Ic23653be3ed404980fd0e723d9ed8354e2b32579 Signed-off-by: Patrick Williams <p
clang-format: update latest spec and reformat
Copy the latest format file from the docs repository and apply.
Change-Id: Ic23653be3ed404980fd0e723d9ed8354e2b32579 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
5087b075 | 11-Mar-2025 |
George Liu <liuxiwei@ieisystem.com> |
Update the registered IPMI method name
Update registered IPMI method names to use `Lower Camel Case`.
Change-Id: I5539771c4ba8567f6cdb22aa3c8df58db5e883f2 Signed-off-by: George Liu <liuxiwei@ieisys
Update the registered IPMI method name
Update registered IPMI method names to use `Lower Camel Case`.
Change-Id: I5539771c4ba8567f6cdb22aa3c8df58db5e883f2 Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
ce3e487a | 03-Mar-2025 |
Patrick Williams <patrick@stwcx.xyz> |
meson: reformat with meson formatter
Apply the `meson format` results.
Change-Id: I3395494124ea1c7305056d7a58a02a4db68c0144 Signed-off-by: Patrick Williams <patrick@stwcx.xyz> |
e2fae4b9 | 13-Nov-2024 |
John Chung <john.chung@arm.com> |
Support IPMI Serial Transport
Support IPMI Serial interface (basic mode) based on Sec 14, IPMI 2.0 spec. Serial transport tested with meta-evb-arm platform with socat and ipmitool.
HW transport can
Support IPMI Serial Transport
Support IPMI Serial interface (basic mode) based on Sec 14, IPMI 2.0 spec. Serial transport tested with meta-evb-arm platform with socat and ipmitool.
HW transport can be selected by meson configure flasg.
Tested:
1. socat -x pty,raw,echo=0,link=/tmp/ttyHOST2BMC tcp:localhost:5066 2. ipmitool -I serial-basic -D /tmp/ttyHOST2BMC:115200 mc info
Device ID : 0 Device Revision : 0 Firmware Revision : 2.17 IPMI Version : 2.0 Manufacturer ID : 0 Manufacturer Name : Unknown Product ID : 0 (0x0000) Product Name : Unknown (0x0) Device Available : no Provides Device SDRs : no Additional Device Support : Aux Firmware Rev Info : 0x00 0x00 0x00 0x00
Change-Id: I2a56390022fce7a974ed75ed6a72ad3fffed9bb6 Signed-off-by: John Chung <john.chung@arm.com>
show more ...
|
ee3983b0 | 05-Jan-2024 |
Chau Ly <chaul@amperecomputing.com> |
Correct chassis's PowerState reading condition
phosphor-dbus-interfaces defines 4 values for PowerState property under xyz.openbmc_project.State.Chassis interface [1]. The current logic causes all t
Correct chassis's PowerState reading condition
phosphor-dbus-interfaces defines 4 values for PowerState property under xyz.openbmc_project.State.Chassis interface [1]. The current logic causes all the other values except for `xyz.openbmc_project.State.Chassis.PowerState.On` to be interpreted as `Off` in `ipmitool power status`. This patch supports interpreting CurrentPowerState value to adapt all states following the logic in the Tested section below.
Tested: `D-Bus value ends with` <=> `$ipmitool power status` *.Off <=> Chassis Power is off *.TransitioningToOn <=> Chassis Power is off *.On <=> Chassis Power is on *.TransitioningToOff <=> Chassis Power is on
[1]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/State/Chassis.interface.yaml
Signed-off-by: Chau Ly <chaul@amperecomputing.com> Change-Id: Ic8e9f0a10b061137126ed3e24ad71e3bf80a5a34
show more ...
|
c6837ed7 | 05-Dec-2024 |
George Liu <liuxiwei@ieisystem.com> |
app: remove IPMI_CMD_WILDCARD
cmdWildcard is already declared in api-types.hpp, this commit remove IPMI_CMD_WILDCARD in app.hpp.
Change-Id: Ic1d944f012022e702a1e5a0aef7a039249684fa2 Signed-off-by:
app: remove IPMI_CMD_WILDCARD
cmdWildcard is already declared in api-types.hpp, this commit remove IPMI_CMD_WILDCARD in app.hpp.
Change-Id: Ic1d944f012022e702a1e5a0aef7a039249684fa2 Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
cacf8309 | 05-Dec-2024 |
George Liu <liuxiwei@ieisystem.com> |
usercommands: remove IPMI_CMD command
The IPMI_CMD declared in usercommands.hpp is redundant because these commands are already declared in api-types.hpp, so this commit removes all IPMI_CMD in user
usercommands: remove IPMI_CMD command
The IPMI_CMD declared in usercommands.hpp is redundant because these commands are already declared in api-types.hpp, so this commit removes all IPMI_CMD in usercommands.hpp.
Change-Id: I347c30e1907b6fd0b2d311c970455195ade383ee Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
e6cd4dfd | 05-Dec-2024 |
George Liu <liuxiwei@ieisystem.com> |
storagehandler: remove storagehandler.hpp
The IPMI_CMD declared in storagehandler.hpp is redundant because these commands are already declared in api-types.hpp, so this commit remove the storagehand
storagehandler: remove storagehandler.hpp
The IPMI_CMD declared in storagehandler.hpp is redundant because these commands are already declared in api-types.hpp, so this commit remove the storagehandler.hpp file.
Change-Id: I3b8beefe54833e9954525057034f382a33cb3944 Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
f7452cb6 | 05-Dec-2024 |
George Liu <liuxiwei@ieisystem.com> |
sensorhandler: remove IPMI_CMD command
The IPMI_CMD declared in sensorhandler.hpp is redundant because these commands are already declared in api-types.hpp, so this commit removes all IPMI_CMD in se
sensorhandler: remove IPMI_CMD command
The IPMI_CMD declared in sensorhandler.hpp is redundant because these commands are already declared in api-types.hpp, so this commit removes all IPMI_CMD in sensorhandler.hpp.
Change-Id: Idc3586d82f3d9905c5ae214e652724ca6425aae7 Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
2e327475 | 05-Dec-2024 |
George Liu <liuxiwei@ieisystem.com> |
globalhandler: remove globalhandler.hpp
The IPMI_CMD declared in globalhandler.hpp is redundant because these commands are already declared in api-types.hpp, so this commit remove the globalhandler.
globalhandler: remove globalhandler.hpp
The IPMI_CMD declared in globalhandler.hpp is redundant because these commands are already declared in api-types.hpp, so this commit remove the globalhandler.hpp file.
Change-Id: Id4b41ca90cd5f1ceb2179cefc237f5117ac9e14c Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
87993931 | 05-Dec-2024 |
George Liu <liuxiwei@ieisystem.com> |
chassishandler: remove IPMI_CMD command
The IPMI_CMD declared in chassishandler.hpp is redundant because these commands are already declared in api-types.hpp, so this commit removes all IPMI_CMD in
chassishandler: remove IPMI_CMD command
The IPMI_CMD declared in chassishandler.hpp is redundant because these commands are already declared in api-types.hpp, so this commit removes all IPMI_CMD in chassishandler.hpp.
Change-Id: I2ec33b4b6df7cad1585f3be829386dd25ea6da80 Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|