clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have b

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have been deprecated, so adjust the style file
accordingly.

See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style.
See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.

Change-Id: Iea764730919fa4e494d2be25f1dd0eddfe0d6fc9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: If87740ef153661e338448c9de753cbd61fd164eb
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

remove "Not enough samples" log to journal

Noticed on a few systems that this is filling up the journal. Not sure
why the "debug" logs are even making it to the journal via lg2 but this
one needs to

remove "Not enough samples" log to journal

Noticed on a few systems that this is filling up the journal. Not sure
why the "debug" logs are even making it to the journal via lg2 but this
one needs to go if debug is going always be going to the journal by
default.

Change-Id: I6667552186c38bd38a2105c7cbd8aeb0aa56f3e6
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

add json config and implementation for hysteresis

Add the json config for health metric hysteresis and implementation
logic for it. Update the health metric config test to validate the
hysteresis va

add json config and implementation for hysteresis

Add the json config for health metric hysteresis and implementation
logic for it. Update the health metric config test to validate the
hysteresis value.

Change-Id: I60c0daa601abee9ac1916581d23257cc04128dd0
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health metric: check hysteresis for value notify

Add hysteresis for metric value and check it before notifying the metric
value update.

Change-Id: I8dace4b9436dd9b16f1a075505079d5001928f52
Signed-o

health metric: check hysteresis for value notify

Add hysteresis for metric value and check it before notifying the metric
value update.

Change-Id: I8dace4b9436dd9b16f1a075505079d5001928f52
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health metric: use instantaneous value

For health metric value update use the instantaneous value rather than
average value as initial average value calculation takes around 2 mins
because of window

health metric: use instantaneous value

For health metric value update use the instantaneous value rather than
average value as initial average value calculation takes around 2 mins
because of window size requirement.

Change-Id: I5e53536b79374a75b1ddfa18ab7a6f782c5ae361
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health_metric: simplify type aliases

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I116b46a0633daae6c0b44e0419434f01a58aad58

storage metric: add generic implementation

Add the generic implementation for the storage metric, so there is no
need to add a new enum value and new code, every time a new storage
type needs to be

storage metric: add generic implementation

Add the generic implementation for the storage metric, so there is no
need to add a new enum value and new code, every time a new storage
type needs to be added.

Change-Id: Idcd99455ca559eb6274a71613684a99b4b63a6f0
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

improve enum logging

Ensure we're using an enumeration string everywhere we log one to
improve readability of the log statements.

This depends on I6850b0bb142f0ef5219a5fc07c2cb4e2c90d5779 from
phos

improve enum logging

Ensure we're using an enumeration string everywhere we log one to
improve readability of the log statements.

This depends on I6850b0bb142f0ef5219a5fc07c2cb4e2c90d5779 from
phosphor-logging for `to_string` conversion support.

Tested:

Running directly on development system shows:
```
<7> TYPE=CPU, NAME=CPU SUBTYPE=CPU PATH=, FREQ=1, WSIZE=120
<7> THRESHOLD TYPE=xyz.openbmc_project.Common.Threshold.Type.Warning THRESHOLD BOUND=xyz.openbmc_project.Common.Threshold.Bound.Upper VALUE=80.000000 LOG=False TARGET=
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5ea7a050e94833af272e79e6add716d1d3e66571

show more ...

threshold: use absolute value for D-Bus

Use the absolute value for threshold rather than percentage value.
This involves passing the total value from the metric collection so it
can be used in perce

threshold: use absolute value for D-Bus

Use the absolute value for threshold rather than percentage value.
This involves passing the total value from the metric collection so it
can be used in percentage calculation within health metric logic.

Change-Id: I46240aee54117c70637f9fbf882018f0eac520b2
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

Decrease logging severity for common message

The health monitor always logs this for each metric on start-up until
enough samples have been collected. Decrease it to debug log level.

Signed-off-by

Decrease logging severity for common message

The health monitor always logs this for each metric on start-up until
enough samples have been collected. Decrease it to debug log level.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4b321b02c88c9e4b8d0b557e711a1c4fa41b1e44

show more ...

health_metric: add threshold lower bound support

Add the lower bound logic to the threshold monitoring.

Change-Id: I445d58a798cdbc04c8d818b9156a8431daed6aa7
Signed-off-by: Jagpal Singh Gill <paligi

health_metric: add threshold lower bound support

Add the lower bound logic to the threshold monitoring.

Change-Id: I445d58a798cdbc04c8d818b9156a8431daed6aa7
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health_metric: add tmp storage support

Add the tmp storage support in health config parser and health metric.

Change-Id: Ibb265c28b22d786031ed152d2cc52f40814be984
Signed-off-by: Jagpal Singh Gill <

health_metric: add tmp storage support

Add the tmp storage support in health config parser and health metric.

Change-Id: Ibb265c28b22d786031ed152d2cc52f40814be984
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health_metric: avoid signal generation for init properties

Avoid signal generation for properties initialization for health
metrics.

Change-Id: If1d7f89a01f40022e6ed7073548291cf5f965b84
Signed-off-

health_metric: avoid signal generation for init properties

Avoid signal generation for properties initialization for health
metrics.

Change-Id: If1d7f89a01f40022e6ed7073548291cf5f965b84
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

add health_metric implementation

Add the interface and implementation for the health_metric to be used
in the rewrite for phosphor-health-monitor.
This change is in relation to following design and

add health_metric implementation

Add the interface and implementation for the health_metric to be used
in the rewrite for phosphor-health-monitor.
This change is in relation to following design and D-Bus interface
update -
https://gerrit.openbmc.org/c/openbmc/docs/+/64917
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/64914

gtest added for UT.

Change-Id: Iffcc52f9dff712890377b1222fd7e7d5d6661eaf
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...