use std::format instead of fmt::format

The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch

use std::format instead of fmt::format

The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch to std::format whenever possible.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib2576fb530a4d7ce238e1b0bd95b40b476ec2107

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I152f141a5e8343b92b5ce81d3ca16eec77b5606b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Monitor : add constant for service name

Add a symbolic constant for Inventory Service. Although its value
happens to be the same as its interface, only having one constant allows
it to be used in wa

Monitor : add constant for service name

Add a symbolic constant for Inventory Service. Although its value
happens to be the same as its interface, only having one constant allows
it to be used in ways that can cause confusion when reading the code.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: Ib97d7977a17c10be6ee874f6fe83865c58b50885

show more ...

monitor: Subscribe to tach target and feedback services

Subscribes to nameOwnerChanged signals for the services of the sensor
and target interfaces for each configured fan. If those services go
offl

monitor: Subscribe to tach target and feedback services

Subscribes to nameOwnerChanged signals for the services of the sensor
and target interfaces for each configured fan. If those services go
offline, the fan tach sensors should get marked nonfunctional due to no
longer receiving updated target or feedback values. In this design, we
use the existing method of determining when a fan tach sensor should be
marked nonfunctional to allow a recovery window, wherein a brief
offline/online transition (such as during a restart) will not trigger a
nonfunctional state change.

Change-Id: I0a935ccad5a864dc952d023185356a1ef1226830
Signed-off-by: Mike Capps <mikepcapps@gmail.com>

show more ...

Enhance fan tracing support - add device access info

Move file names for file errors to the journal message. Enhance
usablility.

Logging messages for file errors contain the file names and other
in

Enhance fan tracing support - add device access info

Move file names for file errors to the journal message. Enhance
usablility.

Logging messages for file errors contain the file names and other
information inside structured entries rather than directly in the log
message. This makes viewing errors more difficult than need be. Before
this change, the journal report needed to be run with '-o verbose' to
see the file names.

Tested:
- For cooling-type/cooling_type.cpp
Approx line 39:
A dry-dock test of this message was performed by commenting out the
return for the successful case just above and adding a successful
return just below the journal message.
Then the next test can output this log message:
Failed to get libevdev from file descriptor 4, return code 0

Approx line 71:
Do this to get error below:
"phosphor-cooling-type --air
--dev=/dev/input/by-path/platform-gpio-keys-polled-event
--path=/system/chassis/motherboard/ --event=21"
Message:
"Device does not support event type keycode 21"

- For cooling-type/main.cpp
Approx line 73:
Do this to provoke error below:
"phosphor-cooling-type --air
--dev=/dev/input/by-path/platform-gpio-keys-polled-event
--path=/system/chassis/motherboard/ --event=6"
Message:
"Uncaught DBus method failure exception Busname:
xyz.openbmc_project.Inventory.Manager Path:
/xyz/openbmc_project/inventory Interface
xyz.openbmc_project.Inventory.Manager Method: Notify"

- For presence/fallback.cpp
Approx line 56:
Run fan presence application using a 'fallback' rpolicy
for a fan and set that fan's gpio presence line to false within
simulation.

Journal Message:
Using backup presence sensor for fan /system/chassis/motherboard/fan0

For presence/fallback.cpp
Approx line 82:
Set a fan's gpio presence line to false within simulation and then run
the fan presence application using a 'fallback' rpolicy for that fan.

Journal Message:
Using backup presence sensor for fan /system/chassis/motherboard/fan0

- For presence/tach.cpp
Approx line 76:
Remove a fan sensor from the fan controller hwmon config that is
configured within the fan presence application. Then unbind and
rebind the fan controller device driver and start the fan presence
application.

Journal Message:
Unable to read fan tach sensor /xyz/openbmc_project/sensors/fan_tach/fan3_0

- For utility.hpp:
Approx line 65:
Do this to get error below:
"phosphor-cooling-type --air
--dev=/dev/input/by-path/platform-gpio-keys-polled-
--path=/system/chassis/motherboard/ --event=21"
Message:
"Failed to open file device path
/dev/input/by-path/platform-gpio-keys-polled-"

Signed-off-by: Jay Meyer <jaymeyer@us.ibm.com>
Change-Id: I592481d92b18b85e5ea5b7040389467530b581e1

show more ...

monitor: Track fan health in the System object

To prepare for being able to power off the system based on missing fans
or nonfunctional fan sensors, put a global view of this health for all
fans in

monitor: Track fan health in the System object

To prepare for being able to power off the system based on missing fans
or nonfunctional fan sensors, put a global view of this health for all
fans in the System object. This requires now keeping track of fan
presence.

This information is stored in a map based on the fan name. It is done
this way, as opposed to just always calling present/functional APIs on
the Fan objects, so that the code that will be using this information
can be tested in isolation without the System or Fan objects.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ieb1d4003bd13cebc806fd06f0064c63ea8ac6180

show more ...

Fix some gcc warnings and style suggestions

Building against gcc-10 produced warnings and style suggestions.
Fixed all the warnings, but only select style suggestions due to
readability and others a

Fix some gcc warnings and style suggestions

Building against gcc-10 produced warnings and style suggestions.
Fixed all the warnings, but only select style suggestions due to
readability and others appeared to be compiler confusion.

Tested: Compiled
No functional impacts appear to have been made with these changes

Change-Id: I1adcce355b831ae8b178bfba9b89cc18fe4f3cf7
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

utility: Clang format updates

Used `format-code.sh` build script to make changes to conform to clang
format.

Tested: Compiled

Change-Id: I8c300579c9c631f30cf4b789bb12b1f67b8ab7f4
Signed-off-by: Ma

utility: Clang format updates

Used `format-code.sh` build script to make changes to conform to clang
format.

Tested: Compiled

Change-Id: I8c300579c9c631f30cf4b789bb12b1f67b8ab7f4
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7b2bc0a8b34e4d276c0e8ea2243459aab4e1c177

utility: Remove getService function

The getService function is no longer used and is not necessary with the
getService function within sdbusplus.hpp

Tested: N/A

Change-Id: Ifad8ec1efb64508923d4f5c

utility: Remove getService function

The getService function is no longer used and is not necessary with the
getService function within sdbusplus.hpp

Tested: N/A

Change-Id: Ifad8ec1efb64508923d4f5c42bef318f0b03124c
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

utility: Remove getInvService function

The getInvService function is no longer used and is not necessary with
the getService function within sdbusplus.hpp

Tested: N/A

Change-Id: Ibb2d55ef5be1852ae

utility: Remove getInvService function

The getInvService function is no longer used and is not necessary with
the getService function within sdbusplus.hpp

Tested: N/A

Change-Id: Ibb2d55ef5be1852ae8ebd3dac32d66518d5d705c
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Update fan inventory method

Use the methods provided within sdbusplus.hpp to update fan inventory
along with prepping inventory to be updated for each fan rotor sensor's
functional state.

Change-Id

Update fan inventory method

Use the methods provided within sdbusplus.hpp to update fan inventory
along with prepping inventory to be updated for each fan rotor sensor's
functional state.

Change-Id: I7d3026d289b1dd22cd4e7b4457c4d4396309c0b5
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

phosphor-fan-presence elog error exception.

Implemented elog exception for phosphor fan presence,
replacing runtime_errors.

Change-Id: I70465060838b2cbaeadccf84ed5924e222ac59e3
Signed-off-by: Dines

phosphor-fan-presence elog error exception.

Implemented elog exception for phosphor fan presence,
replacing runtime_errors.

Change-Id: I70465060838b2cbaeadccf84ed5924e222ac59e3
Signed-off-by: Dinesh Chinari <chinari@us.ibm.com>

show more ...

Implement changes to read GPIO device for cooling type.

Change-Id: If40a54510fb05d67ee0bfdf24026c1d7470897ca
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

Fill in shell functions/files for cooling type.

Change-Id: I8d18d3141e955adeffdd8122ebb17549c88edd77
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

Fan control: Add getService() utility function

This function returns the service name from the mapper
based on the dbus path and interface passed in.

Eventually, getInvService can be removed and th

Fan control: Add getService() utility function

This function returns the service name from the mapper
based on the dbus path and interface passed in.

Eventually, getInvService can be removed and this call
can be used instead.

Change-Id: Ieb090a9b650803e8cfaf2f24143f25a4bbf1cd23
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Move getInvService() into utility function.

Resolves openbmc/openbmc#1299

Change-Id: I61f511dcc15e67393a47bd0395b752d2e6f17f11
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>