sensor-monitor/threshold_alarm_logger: Log sensor name

This patch introduces an optional feature to append the sensor name to
the error message description. This helps in identifying the specific
se

sensor-monitor/threshold_alarm_logger: Log sensor name

This patch introduces an optional feature to append the sensor name to
the error message description. This helps in identifying the specific
sensor that triggered the alarm, improving debugging and visibility.

Change-Id: I32942ab74ebdcf0675a35718a4140d221c3aa20a
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>

show more ...

sensor-mon: Add Threshold value for Threshold event

Add the threshold value for threshold event to let user knowing the
status of sensor through threshold event log.
Divide the ErrorName into ErrorS

sensor-mon: Add Threshold value for Threshold event

Add the threshold value for threshold event to let user knowing the
status of sensor through threshold event log.
Divide the ErrorName into ErrorStatus and ErrorName which ErrorName is
used for getting threshold property and ErrorStatus represents this
threshold event is cleared or triggered in the event log.

Change-Id: I1979544d89cd87a307c58909a566c05707a3c1f2
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

show more ...

sensor-mon: Watch for InterfacesAdded

Start handling the InterfacesAdded signal for the threshold interfaces.
This is so that if a sensor has a threshold alarm set, but then restarts
and then doesn'

sensor-mon: Watch for InterfacesAdded

Start handling the InterfacesAdded signal for the threshold interfaces.
This is so that if a sensor has a threshold alarm set, but then restarts
and then doesn't have it set, sensor-monitor will get the update to the
new good value.

Previously, sensor-monitor would still log a threshold alarm on every
power on after a sensor daemon restarted and then showed no alarm.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I691c8949165bc29ac2eab4190e5dc9a9283bd2e6

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9029cc722e7712633c15436bd3868d8c3209f567

show more ...

sensor-monitor: Fix missing function prototype

Add the missing ThresholdAlarmLogger::interfacesRemoved function
prototype. This passed CI because the --enable-sensor-monitor flag
must not be turned

sensor-monitor: Fix missing function prototype

Add the missing ThresholdAlarmLogger::interfacesRemoved function
prototype. This passed CI because the --enable-sensor-monitor flag
must not be turned on.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I5ad5617bd56ae6649d6adde31faa02f9326d0483

show more ...

sensor_monitor: Watch for interfacesRemoved

Now that the hwmontempsensor app can remove sensors from D-Bus when the
entity-manager config goes away, the sensor monitor needs to deal with
it. It doe

sensor_monitor: Watch for interfacesRemoved

Now that the hwmontempsensor app can remove sensors from D-Bus when the
entity-manager config goes away, the sensor monitor needs to deal with
it. It does so by watching for a threshold interface to be removed from
a sensor and removing that entry from its map of alarms to watch.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I6b48b20eb4d158e5e44566e46469421550d21686

show more ...

sensor:monitor: Use a single PowerState object

Now that both monitor classes need to know about power state, change
them to keep a shared_ptr to a PowerState object and then pass the
object into the

sensor:monitor: Use a single PowerState object

Now that both monitor classes need to know about power state, change
them to keep a shared_ptr to a PowerState object and then pass the
object into their constructors.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia83217e8af51204bbb3fc6e8e3f2eac5912b5913

show more ...

sensor-monitor: Threshold events only when on

Update the monitor that creates event logs for threshold alarms to only
create them when system power is on. When system power changes to on,
the code

sensor-monitor: Threshold events only when on

Update the monitor that creates event logs for threshold alarms to only
create them when system power is on. When system power changes to on,
the code will look for any active alarms to create event logs for. If
an alarm deasserts when power is off, the informational event log will
not be created.

While it could be argued that if event logs aren't desired when power is
off then sensors shouldn't even be active on D-Bus then, there are
cases where it could still be useful to see the sensor value and even an
asserted threshold alarm on Redfish then, such as inlet temp and
altitude/pressure.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I34ce6d26d06dbf1d7cabc184074c0c1f6be65d49

show more ...

sensor-mon: Create event logs

Fill in the function to create event logs. It creates a different log
for an alarm set versus an alarm clear.

The code will not create event logs for sensors of type

sensor-mon: Create event logs

Fill in the function to create event logs. It creates a different log
for an alarm set versus an alarm clear.

The code will not create event logs for sensors of type 'utilization'
because the application that provides CPU and memory utilization
thresholds hardcodes the threshold values and high CPU usage is expected
in some cases, like during a code update. If someone does want these
event logs from those alarms then that can be fixed up in the future.

There is also a FRU callout added for the sensor's FRU. This is done by
following an association, either 'inventory' or 'chassis', depending on
what application provided the sensor. While the sensor documentation
states that the 'inventory' association would be used to point to the
FRU, nothing in the dbus-sensors code does that and frankly trying to
make that happen isn't worth the effort at this point since it can work
how it is now.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I5689cb47250def28aa2b087f8b1975f5464eb98f

show more ...

sensor-mon: Check for threshold alarms on startup

Add the functionality to the ThresholdAlarmLogger class to check for any
active alarms on startup and make a createEventLog() call for them.

It als

sensor-mon: Check for threshold alarms on startup

Add the functionality to the ThresholdAlarmLogger class to check for any
active alarms on startup and make a createEventLog() call for them.

It also keeps track of the alarm values so that the propertiesChanged
handler can know if an alarm changed state or is just new.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I0dec7fc7c42d5007c1466700470faefbf6976dff

show more ...

sensor-mon: Threshold alarm logger framework

Add the new class ThresholdAlarmLogger that will watch the Warning,
Critical, and PerformanceLoss sensor threshold D-Bus interfaces and
create event logs

sensor-mon: Threshold alarm logger framework

Add the new class ThresholdAlarmLogger that will watch the Warning,
Critical, and PerformanceLoss sensor threshold D-Bus interfaces and
create event logs when their alarm properties set and clear.

This commit just creates the class with its three sdbusplus match
objects to watch those interfaces.

Change-Id: I67c629bcabe059952c2029dc034daace9b88f051
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...