clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ica590f8613f1fb89ab1ca676ac51c1cc7e38d67f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I3e9e6350864ac267819a4b8d670bef7d3746976e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I152f141a5e8343b92b5ce81d3ca16eec77b5606b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9029cc722e7712633c15436bd3868d8c3209f567

show more ...

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review size manageable, this commit contains only control
changes (plus one in sensor-monitor).

Change-Id: Ie20f1d9028add4b605e4cc9fb230940710365706
Signed-off-by: Mike Capps <mikepcapps@gmail.com>

show more ...

sdbusplus: remove usage of deprecated alias

The alias `server::match` has been deprecated since 2016. Use the new
alias under bus.

Change-Id: I21baf6b70401d996519b5940d0cd685535475a2f
Signed-off-b

sdbusplus: remove usage of deprecated alias

The alias `server::match` has been deprecated since 2016. Use the new
alias under bus.

Change-Id: I21baf6b70401d996519b5940d0cd685535475a2f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

control: Clang format updates

Used `format-code.sh` build script to make changes to conform to clang
format.

Tested: Compiled

Change-Id: Ic9d621d7c5647bde0a92c5f17938c99deeca0512
Signed-off-by: Ma

control: Clang format updates

Used `format-code.sh` build script to make changes to conform to clang
format.

Tested: Compiled

Change-Id: Ic9d621d7c5647bde0a92c5f17938c99deeca0512
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If06a676c19b2005c388a6ac48ba2d9f13e7615b2

Enhance handling sensor value property type change

From comments resulting in change
https://gerrit.openbmc-project.xyz/29187, simplified the check that both
the type configured and type of the sens

Enhance handling sensor value property type change

From comments resulting in change
https://gerrit.openbmc-project.xyz/29187, simplified the check that both
the type configured and type of the sensor value property are the same
along with doing an assert when the type configured does not match the
supported types of the sensor value property.

A static_assert was not able to be performed within the visitor due to
the type supported by the variant parameter and that the fan
configuration also provides the data type for the properties. Since all
properties configured to be used are ran thru this function, a
static_assert would cause those to fail to compile. This is the best
solution found until the type is removed from being provided in the
configuration.

Tested:
Configured sensor value property to an unsupported type causing an
assert
No change to a sensor value being configured as an int with the dbus
interface being int or double
No change to a sensor value being configured as a double with the
dbus interface being a double

Change-Id: I37955fd60ed23c9d6d198cdce22008258cc00014
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

zone: remove static_cast in float-to-int conversion

It is recommended to use library functions for conversions between
floating point and integers. Replace static_cast (which performs
truncation) w

zone: remove static_cast in float-to-int conversion

It is recommended to use library functions for conversions between
floating point and integers. Replace static_cast (which performs
truncation) with lround (which rounds).

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ied6633869b685d63abdbdaa249332e69b18b439b

show more ...

Support sensor value property to type double

Constructed an intermediate function that is used to apply a visitor
against the `xyz.openbmc_project.Sensor.Value` interface's `Value`
property. This fu

Support sensor value property to type double

Constructed an intermediate function that is used to apply a visitor
against the `xyz.openbmc_project.Sensor.Value` interface's `Value`
property. This function is called to apply the visitor at each point the
internally cached sensor value is updated and stores it as the data type
that is given for this property within the configured yaml.

The visitor provides storing the sensor value directly where the data
type configured matches the data type of the `Value` property on dbus.
However, in the case where the configured data type is the original
int64 and the data type on dbus is double, the visitor will scale the
value from dbus to millidegree C(as it was when stored as an int64 on
dbus) and cast it to the configured int64 data type. This resulting cast
value is stored within the internal cache now as an int64 until the
machine configuration yaml file is updated to reflect the change in the
sensor's value data type to be a double.

Tested:
No change with use of sensor value as int64 and configured as int64
No change with use of sensor value as double and configured as int64
Witherspoon fan control functions correctly with use of sensor value
as double and configuration updated to utilize as a double

Change-Id: Ieb0a646ea37bf7991b9b1f94a85977d9e8984e60
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Update default floor action

Add action to be able to update the default fan floor thru a configured
event.

Tested:
Default floor is updated based on state of group property value

Change-Id: I8

Update default floor action

Add action to be able to update the default fan floor thru a configured
event.

Tested:
Default floor is updated based on state of group property value

Change-Id: I83a4ae313636abbe1e5c8b6ddfc2d5f9d281f844
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add/Remove event timers by event name

Using the event name as the key, each timer an event adds to the list of
timers are associated to that event. This allows quick removal of those
timers when the

Add/Remove event timers by event name

Using the event name as the key, each timer an event adds to the list of
timers are associated to that event. This allows quick removal of those
timers when the event is removed and more efficient searching for a
timer within the smaller list of timers per event name.

Change-Id: I4624918d3a3bbe2a5224cde4bc3fc529e5b40df3
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add/Remove event signals by event name

Using the event name as the key, each signal trigger an event subscribes
to is added to the list of signals for that event only. This later
simplifies removal

Add/Remove event signals by event name

Using the event name as the key, each signal trigger an event subscribes
to is added to the list of signals for that event only. This later
simplifies removal of those subscribed signals if the event is removed.

Change-Id: I8c5f7b01e69e995647408eeb41397d6160beb079
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Move signals to event triggers

Move the generation and initialization of signals to be included in the
available event triggers. The signal trigger consists of subscribing to
a given signal match wh

Move signals to event triggers

Move the generation and initialization of signals to be included in the
available event triggers. The signal trigger consists of subscribing to
a given signal match where when the signal is received and handled, it
causes the event actions to be called.

Tested:
All current event signals are still registered and received
Speed changes occur based on temperature sensor change signals

Change-Id: Iab4ccabb50ad910d5d566bd8c1922109638bd760
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Persist zone object properties option

Add functions to set and get persisted properties on a zone by the
interface and property name. When a property exists, it is persisted
each time it is updated.

Persist zone object properties option

Add functions to set and get persisted properties on a zone by the
interface and property name. When a property exists, it is persisted
each time it is updated.

Tested:
Current property is added and persisted.
When Current property not added, it is not persisted.

Change-Id: I2540c3673affcda871c9342cad44e85a4510d756
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Store and access zone object properties

Properties on the zone object require their event data to be stored for
retrieval when their value changes, which allows the use of the current
event handlers

Store and access zone object properties

Properties on the zone object require their event data to be stored for
retrieval when their value changes, which allows the use of the current
event handlers to update the cached value and trigger the event actions.
When any event is initialized, any signals where the match string is
empty performs a lookup for each group member to determine if they are
on the zone object. Each member found to be on the zone object is then
stored with the that event's data.

Tested:
Verified event data is stored for members on the zone object
Verified event initialization correctly accesses zone object
member's event data

Change-Id: Id34f60eb12330428eeb1041de4e9bd1a4a686f21
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Override setting Current mode property

When the Current mode property changes, the persisted value is updated.

Change-Id: I319fbe2afb8112f7425dc0a1d765fe8f1c408bae
Signed-off-by: Matthew Barth <msb

Override setting Current mode property

When the Current mode property changes, the persisted value is updated.

Change-Id: I319fbe2afb8112f7425dc0a1d765fe8f1c408bae
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Restore current mode property

When the fan control zone is created, the current mode property is
restored from persistent storage. If the persistent storage file does
not exist or fails to be read,

Restore current mode property

When the fan control zone is created, the current mode property is
restored from persistent storage. If the persistent storage file does
not exist or fails to be read, the current mode property is set to
default.

Change-Id: I5ba699f9b6683aea4f39444eace8c7d19a22c92d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Persist current mode property framework

Add the ability to save the current mode property value to
persisted storage.

Change-Id: I354fce7c11a61871a49c9b205dc79ee598f8b1c8
Signed-off-by: Matthew Ba

Persist current mode property framework

Add the ability to save the current mode property value to
persisted storage.

Change-Id: I354fce7c11a61871a49c9b205dc79ee598f8b1c8
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add thermal control interface to zone objects

When in control mode, the thermal control interface and mode property
are added to each zone object. The object path for each zone consists of
the confi

Add thermal control interface to zone objects

When in control mode, the thermal control interface and mode property
are added to each zone object. The object path for each zone consists of
the configured object path plus the zone number.
Ex) /xyz/openbmc_project/control/thermal/0

Tested:
After fan control is started in control mode, dbus interface exists

Change-Id: I88578a7e0eb7c730ffaa4cfc10989e280dc1d46d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Remove timer in favor of sdeventplus/utility/timer

This removes the custom timer implementation and moves to the
sdeventplus utility. Functionally this should make no change

Tested:
Built and r

Remove timer in favor of sdeventplus/utility/timer

This removes the custom timer implementation and moves to the
sdeventplus utility. Functionally this should make no change

Tested:
Built and run through the unit test suite.

Change-Id: Ib7ee90d489d5db72496aaaca91c3cf5490ad47d6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

control/zone: Fix missing cassert include

This was relying on sdbusplus to provide a transitive include for
<cassert>. Since we are directly using the assert() call we should
include <cassert> ourse

control/zone: Fix missing cassert include

This was relying on sdbusplus to provide a transitive include for
<cassert>. Since we are directly using the assert() call we should
include <cassert> ourselves.

Change-Id: I095af26c7a589ab337facc6ac2d0c4983a0f0c2c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Remove all signals when an event is removed

Each event could have multiple signals associated and when the event is
removed, all of those signals should also be removed. This ensures no
dangling sig

Remove all signals when an event is removed

Each event could have multiple signals associated and when the event is
removed, all of those signals should also be removed. This ensures no
dangling signals remain after an event is removed from be processed by
fan control

Tested:
The total number of signals subscribed are reduced by the same
number of signals of a removed event

Change-Id: I651f70dbe6aed9c7eef06aff4eac9eae7ad89d77
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control/zone: Reference instead of copying timer data

Tested:
Built and ran through unit tests.

Change-Id: I9a98d9a3eaee47885b18b642ffd01a38a864dd02
Signed-off-by: William A. Kennington III <wa

control/zone: Reference instead of copying timer data

Tested:
Built and ran through unit tests.

Change-Id: I9a98d9a3eaee47885b18b642ffd01a38a864dd02
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...