clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ica590f8613f1fb89ab1ca676ac51c1cc7e38d67f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I3e9e6350864ac267819a4b8d670bef7d3746976e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I152f141a5e8343b92b5ce81d3ca16eec77b5606b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson support: configuration option removal

D-Bus names and paths that were previously configurable at build-time
are now hard-coded and moved to dbus_paths.hpp to reduce the number of
configure-tim

meson support: configuration option removal

D-Bus names and paths that were previously configurable at build-time
are now hard-coded and moved to dbus_paths.hpp to reduce the number of
configure-time options and simplify maintenance.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I16d88daad90e747cc40d87c853874b1a5fedf5fa

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9029cc722e7712633c15436bd3868d8c3209f567

show more ...

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review size manageable, this commit contains only control
changes (plus one in sensor-monitor).

Change-Id: Ie20f1d9028add4b605e4cc9fb230940710365706
Signed-off-by: Mike Capps <mikepcapps@gmail.com>

show more ...

Use regular std::filesystem

Now that std::filesystem is available there's no need to use
std::experimental::filesystem.

Note the '/' operator does behave differently when the RHS is an
absolute pat

Use regular std::filesystem

Now that std::filesystem is available there's no need to use
std::experimental::filesystem.

Note the '/' operator does behave differently when the RHS is an
absolute path (starts with /), but none of the uses here make use of an
absolute path.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ice5ed7e85f6bf9c8355a66b5b00fe8550899a258

show more ...

control: Split JSON and YAML based binaries

Effectively split the binary built for JSON based configurations from
YAML based configurations. Since each will have objects of the same
name, this split

control: Split JSON and YAML based binaries

Effectively split the binary built for JSON based configurations from
YAML based configurations. Since each will have objects of the same
name, this split is necessary in order to keep the functional
differences apart while keeping the same object names since the JSON
based objects that are created will eventually replace the others.

Change-Id: I937606781fbfa5d23607f81c0fd445289f2bd036
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Create manager object for JSON configs

Begin to transition to separate JSON vs YAMl source objects by creating
a manager object that will contain all the cached data to be used across
all e

control: Create manager object for JSON configs

Begin to transition to separate JSON vs YAMl source objects by creating
a manager object that will contain all the cached data to be used across
all events & zones of a system. This will remove the issue in the YAML
based source where the zone objects contained the cache and essentially
restricted a system to having a single zone object.

Also, include parsing of any configured profiles of the system on the
manager object. These profiles will be used to determine which
configurations are to be used on a system given the active state of any
profiles configured.

Change-Id: I817210f8bb763f03b922651192231529bc48a306
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Construct base zone group from JSON

Pulls together the profiles, zones, and fans JSON configurations to
construct a single zone group to be used as fan control's configuration.
This base zo

control: Construct base zone group from JSON

Pulls together the profiles, zones, and fans JSON configurations to
construct a single zone group to be used as fan control's configuration.
This base zone group includes all that is necessary to get a basic fan
control configuration that will hold fans at the zone's given full
speed. A single zone group is created since the active state of any
configured profiles is checked while creating the zone group.

*Note that "profiles" in JSON configs replace what was called
"Conditions" in YAML based configs.

Tested:
Loaded profile based configurations
Loaded non-profile based configurations
Loaded combination of profile and non-profile based configurations

Change-Id: Id010c899a7633824b80c5cef21c848eadfb66243
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Setup configured power on delay retrieval

A configured power on delay comes from either a compile time YAML
generated `_powerOnDelay` entry or from parsing a future manager JSON
configurati

control: Setup configured power on delay retrieval

A configured power on delay comes from either a compile time YAML
generated `_powerOnDelay` entry or from parsing a future manager JSON
configuration file.

Tested:
No impact to YAML driven configurations
An initial power on delay of zero when use of JSON enabled

Change-Id: If87260d1cb310a0c30698c47024127cd5e8a37e1
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Setup configured zone groups retrieval

Configured zone groups come from either a compile time YAML generated
`_zoneLayouts` list or from a future list created at runtime after
parsing a set

control: Setup configured zone groups retrieval

Configured zone groups come from either a compile time YAML generated
`_zoneLayouts` list or from a future list created at runtime after
parsing a set of JSON configuration files.

Tested:
No impact to YAML driven configurations
Empty list of zone groups created when use of JSON enabled

Change-Id: I3253ccf5c54e5397d5de0b7105fc3918dc59e24a
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: JSON parsing compile framework

Add the enabling framework of use of JSON config files for fan control.

Tested:
Compile passes when `--enable-json` configure flag given
Compile pass

control: JSON parsing compile framework

Add the enabling framework of use of JSON config files for fan control.

Tested:
Compile passes when `--enable-json` configure flag given
Compile passes without enabling JSON
No functional change when not using JSON

Change-Id: Ic70bfc63ad74cb79559ed839784cd214df403cb2
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Clang format updates

Used `format-code.sh` build script to make changes to conform to clang
format.

Tested: Compiled

Change-Id: Ic9d621d7c5647bde0a92c5f17938c99deeca0512
Signed-off-by: Ma

control: Clang format updates

Used `format-code.sh` build script to make changes to conform to clang
format.

Tested: Compiled

Change-Id: Ic9d621d7c5647bde0a92c5f17938c99deeca0512
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add thermal control interface to zone objects

When in control mode, the thermal control interface and mode property
are added to each zone object. The object path for each zone consists of
the confi

Add thermal control interface to zone objects

When in control mode, the thermal control interface and mode property
are added to each zone object. The object path for each zone consists of
the configured object path plus the zone number.
Ex) /xyz/openbmc_project/control/thermal/0

Tested:
After fan control is started in control mode, dbus interface exists

Change-Id: I88578a7e0eb7c730ffaa4cfc10989e280dc1d46d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Fan control dbus busname and object path

Add fan control's default dbus busname and object path to use or what's
provided thru configure. The fan control manager requests the busname
after all the z

Fan control dbus busname and object path

Add fan control's default dbus busname and object path to use or what's
provided thru configure. The fan control manager requests the busname
after all the zones are created.

Tested:
Found the requested busname for a zone in the busctl list

Change-Id: I8ee1e9e4094dcec958e8ae81ad4299357b8f792d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: manager: Avoid the need for fconcepts

Use of auto in a function parameter list is supported in c++17 but
gcc8 requires enabling concepts TS support. We don't require a
template anyway - ju

control: manager: Avoid the need for fconcepts

Use of auto in a function parameter list is supported in c++17 but
gcc8 requires enabling concepts TS support. We don't require a
template anyway - just be explicit here and avoid the need for
-fconcepts until such a time that other concepts TS features are
required.

Change-Id: Iec6205a2e4da41aeb5840dd9942778ba0f373842
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Switch sd_event loops to sdeventplus

This change is mostly focused around plumbing the sdeventplus::Event
object everywhere and using the member functions provided for the event.
No migration to the

Switch sd_event loops to sdeventplus

This change is mostly focused around plumbing the sdeventplus::Event
object everywhere and using the member functions provided for the event.
No migration to the timer utility is performed yet.

Change-Id: I912ab82bc081239d3b7c3cf7c5caca6742ef9c87
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Use shared callMethod function in control manager

To better handle exit/restart of the fan control application use the
shared callMethod function to call systemd's startunit on the fan
control ready

Use shared callMethod function in control manager

To better handle exit/restart of the fan control application use the
shared callMethod function to call systemd's startunit on the fan
control ready target. This allows the fan control application to exit
and restart quickly in its allowed attempts configured in systemd.

Tested:
StartUnit on fan control ready target works the same

Change-Id: Idce2d8831b4e8de0ef181a0849587e465419f68c
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Use shared getProperty function in control manager

When the manager checks a getProperty condition for fan control, it
should use the shared getProperty function that now returns a
DbusMethodError t

Use shared getProperty function in control manager

When the manager checks a getProperty condition for fan control, it
should use the shared getProperty function that now returns a
DbusMethodError to better exit/restart the fan control application.

Tested:
Condition check functions the same

Change-Id: I37f83ef4273343bd527ac149ac5eee213d0ad63d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Timer to decrease fan speeds

Create a repeating timer for decreasing fan speeds where the fan speeds
in the zone are decreased when the timer expires and a decrease speed
request exists with no incr

Timer to decrease fan speeds

Create a repeating timer for decreasing fan speeds where the fan speeds
in the zone are decreased when the timer expires and a decrease speed
request exists with no increase request present or active.

Change-Id: I419592f6f50c0ed524f8bf3ebf183854ab5ef2ea
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

phosphor-fan-presence elog error exception.

Implemented elog exception for phosphor fan presence,
replacing runtime_errors.

Change-Id: I70465060838b2cbaeadccf84ed5924e222ac59e3
Signed-off-by: Dines

phosphor-fan-presence elog error exception.

Implemented elog exception for phosphor fan presence,
replacing runtime_errors.

Change-Id: I70465060838b2cbaeadccf84ed5924e222ac59e3
Signed-off-by: Dinesh Chinari <chinari@us.ibm.com>

show more ...

Evaluate conditions to determine zone

Change-Id: Idb825b27ecf98503ddc2405a0cafc30c644efc71
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Only setup set speed events when not init mode

Change-Id: Ia6987295a3eb4e23b9d6ae13a383e440386572de
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

Add modes to phosphor-fan-control

phosphor-fan-control can behave differently based
on its command line arguments

--init: Set fans to full speed, delay for a
configurable amount of time t

Add modes to phosphor-fan-control

phosphor-fan-control can behave differently based
on its command line arguments

--init: Set fans to full speed, delay for a
configurable amount of time to allow fans to ramp up,
start the fan control ready target, and then exit.

--control: Start the control algorithm. Never exits.
Will be started as part of the fan control ready target.

Change-Id: I453daf8cc05a5c85a19c098e1cca64cac2ad9520
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...