clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ica590f8613f1fb89ab1ca676ac51c1cc7e38d67f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I3e9e6350864ac267819a4b8d670bef7d3746976e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

use std::format instead of fmt::format

The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch

use std::format instead of fmt::format

The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch to std::format whenever possible.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib2576fb530a4d7ce238e1b0bd95b40b476ec2107

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I152f141a5e8343b92b5ce81d3ca16eec77b5606b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

control: Fix InterfacesRemoved match string

The interfaces_removed trigger was using the wrong match for the
InterfacesRemoved signal. It was trying look for the object path in
question to be the '

control: Fix InterfacesRemoved match string

The interfaces_removed trigger was using the wrong match for the
InterfacesRemoved signal. It was trying look for the object path in
question to be the 'path' field, but 'path' is just the path of the
object manager sending the signal. It should be looking at argument 0
instead. This was previously fixed for InterfacesAdded but somehow
missed for this one.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: If818b228472606dd204d507cfe04c7bacdc5fc03

show more ...

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review size manageable, this commit contains only control
changes (plus one in sensor-monitor).

Change-Id: Ie20f1d9028add4b605e4cc9fb230940710365706
Signed-off-by: Mike Capps <mikepcapps@gmail.com>

show more ...

control: `nameOwnerChanged` signals update all caches

When a `nameOwnerChanged` signal is received, update all entries within
the service tree cache for the given service's owner state change. Also,

control: `nameOwnerChanged` signals update all caches

When a `nameOwnerChanged` signal is received, update all entries within
the service tree cache for the given service's owner state change. Also,
use the service tree cache to cross reference removal of the associated
interfaces from objects within the objects cache.

Change-Id: Idab52a7533d626f1f7ef03397f904a74cb6457a3
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Support group service names in name owner triggers

If a group provides a service name, which is required to be the service
name for all group members and their interfaces, use that service

control: Support group service names in name owner triggers

If a group provides a service name, which is required to be the service
name for all group members and their interfaces, use that service name
when subscribing to nameOwnerChanged signals or calling the nameHasOwner
method. This can be used so that the service name does not have to be
looked up for each group member(and interface) or where the service for
a group(and interface) may not be on dbus when subscribing.

Change-Id: Ic52aef519eef61103478742c7a32e1f268809d38
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Create parameter trigger

Create a new event trigger that will run actions when a parameter is
either added, removed, or changed.

When the trigger is enabled it is added to the Manager clas

control: Create parameter trigger

Create a new event trigger that will run actions when a parameter is
either added, removed, or changed.

When the trigger is enabled it is added to the Manager class since that
is where parameters are stored, and then the Manager watches for
parameter changes and runs actions as needed.

The JSON config would look like:
{
"class": "parameter",
"parameter": "pcie_floor_index"
}

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I8ff281d49ac780e8ff38f3e8ed02ab95395f1fd3

show more ...

sdbusplus: remove usage of deprecated alias

The alias `server::match` has been deprecated since 2016. Use the new
alias under bus.

Change-Id: I21baf6b70401d996519b5940d0cd685535475a2f
Signed-off-b

sdbusplus: remove usage of deprecated alias

The alias `server::match` has been deprecated since 2016. Use the new
alias under bus.

Change-Id: I21baf6b70401d996519b5940d0cd685535475a2f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

control: Correct same signal object subscription of actions

When the same signal for a signal object is subscribed to (such as
across events), the actions should be included on the list of actions t

control: Correct same signal object subscription of actions

When the same signal for a signal object is subscribed to (such as
across events), the actions should be included on the list of actions to
be called when that specific signal is received. Previously these
actions were being moved off the event's list of actions, which was not
ideal. This instead copies a reference to the event's list of actions to
the list of actions to be called when the particular signal is received.

Change-Id: I260f7134a67ec82f9e90a66c4cfe9189ca7d4304
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Correct subscribing/handling of signals

When subscribing to signals, a pointer to the signal packages should be
used for the location to store the list of signal packages. This way the
call

control: Correct subscribing/handling of signals

When subscribing to signals, a pointer to the signal packages should be
used for the location to store the list of signal packages. This way the
callback is bound to the pointer and not the local variable that was
then getting moved.

Also, in handling signal messages, since there could be more than one
signal package to check against the signal received, a rewind must be
done to the signal message so that additional signal packages can read
the message contents again.

Change-Id: Iddea2011d25068d6f71bdee91801537cd5994728
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Have iA match use arg0Path param

InterfacesAdded signals are sent from the path the ObjectManager is
implemented on, and the path that has the new interface is in the first
argument of the

control: Have iA match use arg0Path param

InterfacesAdded signals are sent from the path the ObjectManager is
implemented on, and the path that has the new interface is in the first
argument of the signal.

For example, this dbus-monitor output:
path=/org/open_power/control;
interface=org.freedesktop.DBus.ObjectManager;
member=InterfacesAdded
object path "/org/open_power/control/occ1"

Update the match string for this signal to match on the group member
using 'arg0path' (the .../occ1 entry above) instead of 'path' (the
/org/open_power/control entry).

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: If22157aa863504415f771aa366bc45b0e91405d7

show more ...

control: Subscribe to nameOwnerChanged once per service

When more than one member of an event group's service is the same,
there's no need to subscribe to the nameOwnerChanged signal again for
the s

control: Subscribe to nameOwnerChanged once per service

When more than one member of an event group's service is the same,
there's no need to subscribe to the nameOwnerChanged signal again for
the same service. This was causing the same actions that the first
subscription already moved into the list of actions for this signal to
be "moved" again which is not possible nor what should be done since
those same actions were already associated to the signal.

Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
Change-Id: Idfc1da551cbdf8ca2e1697c02c408d3ed51bc31f

show more ...

control: `member` signal triggers use event groups

Remove the ability to provide a `member` trigger's attributes from the
event trigger configuration in favor of using the configured event's
groups.

control: `member` signal triggers use event groups

Remove the ability to provide a `member` trigger's attributes from the
event trigger configuration in favor of using the configured event's
groups. This aligns with the recent design direction that event triggers
are setup from the event groups.

Change-Id: I304cfdffedd54317e440e7566988392a1410af6a
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Use event groups on `signal` triggers

Use the provided event groups when enabling any `signal` triggers
instead of the action groups. Event groups are what's used with setting
up event trig

control: Use event groups on `signal` triggers

Use the provided event groups when enabling any `signal` triggers
instead of the action groups. Event groups are what's used with setting
up event triggers and may or may not be a different set of groups than
what's used when actions are run depending on event configuration.

Change-Id: I78b6255ada52ed718469a6700b4bc2603b2a85cb
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Pass event groups when enabling triggers

The `init` and `signal` triggers need to use the event groups when
retrieving group member values and subscribing to signals respectively.
This is t

control: Pass event groups when enabling triggers

The `init` and `signal` triggers need to use the event groups when
retrieving group member values and subscribing to signals respectively.
This is the first step towards fixing that actions are optional on
events and the design direction that `init` and `signal` triggers will
use the event groups (which may or may not be the same as the groups on
same event's actions) when populating/updating the cached state of all
the group members.

Change-Id: Id5a1891f94572d6c843d98603eb1c8233471e23c
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Support `member` signal triggers

`member` signals are signals that a dbus object could send out on dbus
that acts as a notification that does not contain any other data. This
adds support t

control: Support `member` signal triggers

`member` signals are signals that a dbus object could send out on dbus
that acts as a notification that does not contain any other data. This
adds support to fan control events that can be triggered by this type of
signal on dbus to essentially run a set of actions. The configuration of
this trigger is contained within the JSON configuration of the trigger
on the event and not against the event's group(s).

i.e.)
"triggers": [
{
"class": "signal",
"signal": "member",
"member":
{
"name": "Pressed",
"path": "/xyz/openbmc_project/Chassis/Buttons/Power0",
"interface": "xyz.openbmc_project.Chassis.Buttons.Power"
}
}
]

Change-Id: Ie7924174333c604fb54c8f18560a890bf6a7c489
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Provide trigger JSON to signal trigger subscribing

An upcoming signal class trigger will have additional JSON configuration
details for subscribing to it. This removes the generally unused

control: Provide trigger JSON to signal trigger subscribing

An upcoming signal class trigger will have additional JSON configuration
details for subscribing to it. This removes the generally unused event
name passed to each type of signal and replaces it with the trigger's
JSON configuration where used, which will not be used until the upcoming
`member` type of signal.

Change-Id: I7f9be935ba32ea71d0529f27e8e1c9016f7cec1f
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Store signal packages as a reference

Switch from storing signal package data from a pointer to a reference.

Change-Id: I2d9051273e54709c0c8abd0c72f513bac36a2c89
Signed-off-by: Matthew Bart

control: Store signal packages as a reference

Switch from storing signal package data from a pointer to a reference.

Change-Id: I2d9051273e54709c0c8abd0c72f513bac36a2c89
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Remove manager parameter from create trigger function

The pointer to the manager object is no longer needed when creating a
trigger since its provided when the trigger is enabled.

Change-I

control: Remove manager parameter from create trigger function

The pointer to the manager object is no longer needed when creating a
trigger since its provided when the trigger is enabled.

Change-Id: Ib5b3923bf87c405243630e622f383b27f50453a5
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Store/use trigger enable functions on events

Create and store trigger enablement functions on the events based on the
trigger's configuration so that they can be enabled separately from whe

control: Store/use trigger enable functions on events

Create and store trigger enablement functions on the events based on the
trigger's configuration so that they can be enabled separately from when
the event is created. This will allow actions that load events to be
able to be parsed and then enabled when the action determines that the
events should be enabled. It also supports the use of SIGHUP to reload
the event configuration since the events JSON configuration must
successfully be loaded before the newly created events can be enabled in
place of the currently enabled events.

Change-Id: I31871ee1691d5e6b26fe16cde2a829c426ad6504
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Handle `Current` property changing

It appears there's no longer a need to handle objects owned by fan
control that it may also be subscribed to for propertiesChanged signals.
This may be du

control: Handle `Current` property changing

It appears there's no longer a need to handle objects owned by fan
control that it may also be subscribed to for propertiesChanged signals.
This may be due to updates in sdbusplus's async capabilities, but in
case these signals begin to get dropped to the fan control service, an
issue was created to re-test the handling of the `Current` thermal mode
property changing (https://github.com/ibm-openbmc/dev/issues/3195)

This commit adds a `TODO` note along with some minor changes to updating
the value of the `Current` property.

Change-Id: Id26d80566318327982ac8c72406803e55059d9b8
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Add nameOwnerChanged signal support

Subscribe to and handle nameOwnerChanged signals to trigger event
actions.

Change-Id: I7d5a472d31a2af5297581c18d84ef4ac897ff3ea
Signed-off-by: Matthew B

control: Add nameOwnerChanged signal support

Subscribe to and handle nameOwnerChanged signals to trigger event
actions.

Change-Id: I7d5a472d31a2af5297581c18d84ef4ac897ff3ea
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Add interfacesRemoved signal support

Subscribe to and handle interfacesRemoved signals to trigger event
actions.

Change-Id: I270dc02bfa78c1801c545712710b27a3d2ba2180
Signed-off-by: Matthew

control: Add interfacesRemoved signal support

Subscribe to and handle interfacesRemoved signals to trigger event
actions.

Change-Id: I270dc02bfa78c1801c545712710b27a3d2ba2180
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...