clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ica590f8613f1fb89ab1ca676ac51c1cc7e38d67f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I3e9e6350864ac267819a4b8d670bef7d3746976e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

use std::format instead of fmt::format

The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch

use std::format instead of fmt::format

The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch to std::format whenever possible.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib2576fb530a4d7ce238e1b0bd95b40b476ec2107

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I152f141a5e8343b92b5ce81d3ca16eec77b5606b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review size manageable, this commit contains only control
changes (plus one in sensor-monitor).

Change-Id: Ie20f1d9028add4b605e4cc9fb230940710365706
Signed-off-by: Mike Capps <mikepcapps@gmail.com>

show more ...

control: Be more lenient toward missing sensors

In the cases where the service name of a sensor (i.e. group member) is
known ahead of time, but that service isn't actually running, the code
will try

control: Be more lenient toward missing sensors

In the cases where the service name of a sensor (i.e. group member) is
known ahead of time, but that service isn't actually running, the code
will try to make a get property call on it anyway and crash. Fix that
by catching the exception and continuing on.

Also, if the same type of service isn't running but is used in an action
that runs on a timer with 'preload_groups' set in the config to have the
code try to get all properties in the groups after each timer
expiration, there will be an exception thrown there too. In that case,
the exception is caught by the sdeventplus handler so the app doesn't
crash, but it prevents the run() call from completing. Catch that
exception as well in Manager::addGroups() so the actions can complete.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ifb56333508c3ceb6027e1e004d946c330dbd8634

show more ...

control: Let Manager::addObjects() take a service

When calling Manager::addObjects(), pass in the service of the object,
if known, so that addObjects() can use that service to call
getManagedObjects

control: Let Manager::addObjects() take a service

When calling Manager::addObjects(), pass in the service of the object,
if known, so that addObjects() can use that service to call
getManagedObjects() with and add objects to the cache even if the
D-Bus path passed in doesn't exist.

This fixes a bug where if the path doesn't exist, that function won't
add anything at all, even though getProperties() in init.cpp was
depending on it doing that so that it only needed to call addObjects()
once per group as a performance enhancement.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I971a244d665d3aaf493c3d03e7a4fec87e7e512d

show more ...

control:init trigger: Only call addObjects once

The 'init' trigger will attempt to add the D-Bus properties of all of
its group members to the objects cache with the Manager::addObjects()
function.

control:init trigger: Only call addObjects once

The 'init' trigger will attempt to add the D-Bus properties of all of
its group members to the objects cache with the Manager::addObjects()
function.

That function will call GetManagedObjects to add *all* group D-Bus
paths provided by the service that has the path/interface/property
passed in.

If the group had a service listed in its JSON configuration, then all
members of the group come from the same service, so we know the
first addObjects call would add all group members so there is no need to
keep calling it on the remaining members.

This can lead to a significant performance improvement on startup when
the D-Bus objects in the groups don't exist yet since it would end up
calling addObjects on each member which drives at least GetSubTree
mapper calls each time.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Icc27fdae922fa6f068cd72d9c2299451f768e7d6

show more ...

control - Ensure `nameHasOwner` set on all group members

It was found that `nameHasOwner` method calls upon fan control starting
was not setting all group members' service owned states. This was due

control - Ensure `nameHasOwner` set on all group members

It was found that `nameHasOwner` method calls upon fan control starting
was not setting all group members' service owned states. This was due to
skipping group members if they were hosted by the same service, which
actually caused a problem later when the action would be run looking at
the service state for all groups members. With this fix all group
members get an initial service owned state thru `nameHasOwner`.

Change-Id: Icd8e16e0a2235522aa531a629a82aa2af47c5199
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Support group service names in name owner triggers

If a group provides a service name, which is required to be the service
name for all group members and their interfaces, use that service

control: Support group service names in name owner triggers

If a group provides a service name, which is required to be the service
name for all group members and their interfaces, use that service name
when subscribing to nameOwnerChanged signals or calling the nameHasOwner
method. This can be used so that the service name does not have to be
looked up for each group member(and interface) or where the service for
a group(and interface) may not be on dbus when subscribing.

Change-Id: Ic52aef519eef61103478742c7a32e1f268809d38
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Use event groups on `init` triggers

Use the provided event groups when enabling any `init` triggers instead
of the action groups. Event groups is what's used with setting up event
triggers

control: Use event groups on `init` triggers

Use the provided event groups when enabling any `init` triggers instead
of the action groups. Event groups is what's used with setting up event
triggers and may or may not be a different set of groups than what's
used when actions are run depending on event configuration.

Change-Id: I804e798e169598080583965e6922fc5fb1cfa2be
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Pass event groups when enabling triggers

The `init` and `signal` triggers need to use the event groups when
retrieving group member values and subscribing to signals respectively.
This is t

control: Pass event groups when enabling triggers

The `init` and `signal` triggers need to use the event groups when
retrieving group member values and subscribing to signals respectively.
This is the first step towards fixing that actions are optional on
events and the design direction that `init` and `signal` triggers will
use the event groups (which may or may not be the same as the groups on
same event's actions) when populating/updating the cached state of all
the group members.

Change-Id: Id5a1891f94572d6c843d98603eb1c8233471e23c
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Remove manager parameter from create trigger function

The pointer to the manager object is no longer needed when creating a
trigger since its provided when the trigger is enabled.

Change-I

control: Remove manager parameter from create trigger function

The pointer to the manager object is no longer needed when creating a
trigger since its provided when the trigger is enabled.

Change-Id: Ib5b3923bf87c405243630e622f383b27f50453a5
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Store/use trigger enable functions on events

Create and store trigger enablement functions on the events based on the
trigger's configuration so that they can be enabled separately from whe

control: Store/use trigger enable functions on events

Create and store trigger enablement functions on the events based on the
trigger's configuration so that they can be enabled separately from when
the event is created. This will allow actions that load events to be
able to be parsed and then enabled when the action determines that the
events should be enabled. It also supports the use of SIGHUP to reload
the event configuration since the events JSON configuration must
successfully be loaded before the newly created events can be enabled in
place of the currently enabled events.

Change-Id: I31871ee1691d5e6b26fe16cde2a829c426ad6504
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Add init trigger support

Add init trigger support to the available triggers where init triggered
event actions are run immediately when fan control starts. Initially the
`getProperties` and

control: Add init trigger support

Add init trigger support to the available triggers where init triggered
event actions are run immediately when fan control starts. Initially the
`getProperties` and `nameHasOwner` methods are supported to be triggered
when fan control starts. The `getProperties` method populates the dbus
object cache for each group member's property configured. The
`nameHasOwner` method populates the service owned state from dbus for
each group member. Each of these attempts to do bulk
reads(getManagedObjects for `getProperties` and getSubTree for
`nameHasOwner`) from dbus when populating the caches to minimize dbus
calls.

Change-Id: Ib5d89eceadd26db1bf7610113ea30fc8ba69ab12
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...