Move the control application to lg2

Update the logging API used for files in phosphor-fan-presence/control
from the older phosphor::logging::log to the more recent lg2::log.

Tested:
* Verified jour

Move the control application to lg2

Update the logging API used for files in phosphor-fan-presence/control
from the older phosphor::logging::log to the more recent lg2::log.

Tested:
* Verified journal traces worked correctly in simulation.
* Modified json to force various property errors and verified
correct key/value pairs in the journalctl output.

Change-Id: If1ac33b90abe2a9baae6f3cc788863bd514fa80e
Signed-off-by: Anwaar Hadi <anwaar.hadi@ibm.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ica590f8613f1fb89ab1ca676ac51c1cc7e38d67f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I3e9e6350864ac267819a4b8d670bef7d3746976e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

use std::format instead of fmt::format

The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch

use std::format instead of fmt::format

The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch to std::format whenever possible.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib2576fb530a4d7ce238e1b0bd95b40b476ec2107

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I152f141a5e8343b92b5ce81d3ca16eec77b5606b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review size manageable, this commit contains only control
changes (plus one in sensor-monitor).

Change-Id: Ie20f1d9028add4b605e4cc9fb230940710365706
Signed-off-by: Mike Capps <mikepcapps@gmail.com>

show more ...

control: Delete a parameter when nullopt is used

This commit changes the Manager::setParameter function to take a
std::optional. When std::nullopt is passed in, the parameter is
deleted. This remo

control: Delete a parameter when nullopt is used

This commit changes the Manager::setParameter function to take a
std::optional. When std::nullopt is passed in, the parameter is
deleted. This removes the need for a separate deleteParameter function
and simplifies a code path that uses it.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia32bc0e977245bd7d06b8d12c0cdfd79b981e4ba

show more ...

control: set_parameter_from_group: handle no max

Handle the case where no members of the group have a value (i.e. they
aren't on D-Bus). In that case, remove that parameter from the
manager.

Chan

control: set_parameter_from_group: handle no max

Handle the case where no members of the group have a value (i.e. they
aren't on D-Bus). In that case, remove that parameter from the
manager.

Change-Id: Idc70d637b1031288fa9bf3a8f23cd7fca09ae8fb

show more ...

control: set_parameter_from_group_max action

This action will write a D-Bus property value to the Manager's parameter
cache. The property value written is the maximum value of all the
configured gr

control: set_parameter_from_group_max action

This action will write a D-Bus property value to the Manager's parameter
cache. The property value written is the maximum value of all the
configured groups. The value can be modified using the Modifier utility
class's expressions before storing it.

The use case for this is that this action would be configured to write a
parameter that could then be used by another action.

An example JSON config is:

{
"name": "set_parameter_from_group",
"parameter_name": "proc_0_throttle_temp",
"modifier": {
"operator": "minus",
"value": 4
}
}

This would read the maximum D-Bus property found in all the groups
configured for the action, subtract 4 from it, and then store it as a
Manager parameter under the name proc_0_throttle_temp.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I75d91110023e0de9908d694997676e4854917ea8

show more ...