control: Support target_path option in configuration file

The target path containing the interface
xyz.openbmc_project.control.FanPwm or
xyz.openbmc_project.control.FanSpeed can be different between

control: Support target_path option in configuration file

The target path containing the interface
xyz.openbmc_project.control.FanPwm or
xyz.openbmc_project.control.FanSpeed can be different between
phosphor-hwmon and dbus-sensor.

In phosphor-hwmon, it is "/xyz/openbmc_project/sensors/fan_tach/".
In dbus-sensor, it is "/xyz/openbmc_project/control/fanpwm/"

This commit supports making this path configurable via "target_path".
By default, it is "/xyz/openbmc_project/sensors/fan_tach/".

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: Id799986ff69455b7c7054070ed2ab3b2e2500a6c

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9029cc722e7712633c15436bd3868d8c3209f567

show more ...

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia432ec5539a6af3c761dfbb86916464de5455149

show more ...

control: Clang format updates

Used `format-code.sh` build script to make changes to conform to clang
format.

Tested: Compiled

Change-Id: Ic9d621d7c5647bde0a92c5f17938c99deeca0512
Signed-off-by: Ma

control: Clang format updates

Used `format-code.sh` build script to make changes to conform to clang
format.

Tested: Compiled

Change-Id: Ic9d621d7c5647bde0a92c5f17938c99deeca0512
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Handle SdBusError exceptions

When the SdBusError exception was added, all sdbusplus::bus::call
function use required this exception be handled appropriately in each
case where it could occur. These

Handle SdBusError exceptions

When the SdBusError exception was added, all sdbusplus::bus::call
function use required this exception be handled appropriately in each
case where it could occur. These changes are the result of handling the
possibility of this exception correctly within the fan applications.

Change-Id: I6ecef3008412b299a4fedbb13716f656cfbf1a90
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Use setProperty function in fan set speed

When a fan's target speed is set, using the setProperty function
allows for better handling of dbus failures setting the fan target
property. If a failure o

Use setProperty function in fan set speed

When a fan's target speed is set, using the setProperty function
allows for better handling of dbus failures setting the fan target
property. If a failure occurs setting this property, a journal entry is
created and a DBusPropertyError exception is thrown to allow the fan
control application to exit and restart quickly in its allowed attempts
configured in systemd.

Tested:
Fan control application logs an error to the journal and then
terminates when a dbus error occurs setting a fan target speed.

Change-Id: Ibd4bd8b18b6010727831d97e32c14fd6c681e170
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

perf: Cache service name for fan target sensors

Cache the service name for each fan target sensor path and use that
service when a new target speed is set on the Target property.

Tested:
Fan ta

perf: Cache service name for fan target sensors

Cache the service name for each fan target sensor path and use that
service when a new target speed is set on the Target property.

Tested:
Fan target sensor created and set speed functions the same

Change-Id: I3e25e355cf5d31ce814a73c801c6f086fa45531a
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add target interface for fan control

Current fan control assumes the use of the FanSpeed interface for fan
targets.
For fans controlled by pwm, FanPwm interface is added.

This commit adds "target_i

Add target interface for fan control

Current fan control assumes the use of the FanSpeed interface for fan
targets.
For fans controlled by pwm, FanPwm interface is added.

This commit adds "target_interface" config parameter, so that user can
specify the interface for the fan targets.

E.g.

- inventory: /system/chassis/motherboard/fan0
cooling_zone: 0
cooling_profile: air
sensors:
- fan0
target_interface: xyz.openbmc_project.Control.FanPwm

The config is optional and defaults to FanSpeed, so the current code
will not be affected.

Tested: Use this config on Romulus, ensures the fan control sets
target on FanPwm interface and works fine.

Change-Id: I73adccaa770d657b5d7aaeb307917f89588524de
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Fix indentation from review comment

https://gerrit.openbmc-project.xyz/#/c/7574/7/control/fan.cpp@89

Change-Id: I572093d1bbe636f5fb4f021b3b8478de19acc673
Signed-off-by: Matthew Barth <msbarth@us.ib

Fix indentation from review comment

https://gerrit.openbmc-project.xyz/#/c/7574/7/control/fan.cpp@89

Change-Id: I572093d1bbe636f5fb4f021b3b8478de19acc673
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Init zone target speed to current target speed

Whenever fan control (control mode) is started, the target speed for
each zone should be initialized to the currently set target speed.

In the case wh

Init zone target speed to current target speed

Whenever fan control (control mode) is started, the target speed for
each zone should be initialized to the currently set target speed.

In the case where a watchdog has triggered the fans to full speed
and the target speed does not reflect this, the proper set of set speed
events should be configured. In this case, an event could be defined to
use the current tach feedback to adjust the target speed prior to
account for the real state of the fan speeds.

Change-Id: I538644ffc83a6e01469174304d393c889038d066
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

phosphor-fan-presence elog error exception.

Implemented elog exception for phosphor fan presence,
replacing runtime_errors.

Change-Id: I70465060838b2cbaeadccf84ed5924e222ac59e3
Signed-off-by: Dines

phosphor-fan-presence elog error exception.

Implemented elog exception for phosphor fan presence,
replacing runtime_errors.

Change-Id: I70465060838b2cbaeadccf84ed5924e222ac59e3
Signed-off-by: Dinesh Chinari <chinari@us.ibm.com>

show more ...

Fan control: Create Fan class

This class contains the inventory name of the fan,
and the sensor names representing the rotors.

Calling setSpeed on this object will set the speed
on all contained se

Fan control: Create Fan class

This class contains the inventory name of the fan,
and the sensor names representing the rotors.

Calling setSpeed on this object will set the speed
on all contained sensors.

Change-Id: I850e2d69067813005270105618fcf69b04382b03
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...