#
fa6a47bf |
| 25-Mar-2024 |
Jian Zhang <zhangjian.3032@bytedance.com> |
watch: fix memory leak in Watch class
See systemd manunal[0], ``` If the second parameter of sd_event_add_io() is NULL no reference to the event source object is returned. In this case the event sou
watch: fix memory leak in Watch class
See systemd manunal[0], ``` If the second parameter of sd_event_add_io() is NULL no reference to the event source object is returned. In this case the event source is considered "floating", and will be destroyed implicitly when the event loop itself is destroyed. ```
The Watch class should release the event source object when destructing the Watch object.
Tested: 1. Run CreateDump Stress Test ``` while true; do busctl call xyz.openbmc_project.Dump.Manager /xyz/openbmc_project/dump/bmc xyz.openbmc_project.Dump.Create CreateDump a{sv} 0; sleep 200; done
``` 2. run the command to monitor the memory heap size of dump-manager, and no memory leak found. ~# watch -n 10 "cat /proc/[PID]/smaps | grep heap -A 4 | grep ^Rss"
[0]: https://www.freedesktop.org/software/systemd/man/latest/sd_event_add_io.html
Change-Id: I530bda40a7a7307ee87f03a24c242dde4eae2b14 Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>
show more ...
|
#
4f68fc46 |
| 25-Nov-2024 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy: Initial Commit
This commit introduces clang-tidy and modifies code to address issues flagged by the checks. Additionally, it includes the initial infrastructure setup.
Tested: Build and
clang-tidy: Initial Commit
This commit introduces clang-tidy and modifies code to address issues flagged by the checks. Additionally, it includes the initial infrastructure setup.
Tested: Build and unit tests completed successfully.
Change-Id: I55f9f4a2a9a1b1cd2016773b47935484d6a57867 Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
#
3fc6df48 |
| 08-Apr-2021 |
Jayanth Othayoth <ojayanth@in.ibm.com> |
c++17: drop experimental::filesystem
Use the real filesystem library, and drop support for building with experimental under c++14.
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com> Change-Id: I
c++17: drop experimental::filesystem
Use the real filesystem library, and drop support for building with experimental under c++14.
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com> Change-Id: I730c0d6dce53b5e0aa0867cddb7f325cdb9b45fc
show more ...
|
#
cb65ffce |
| 16-Oct-2018 |
Jayanth Othayoth <ojayanth@in.ibm.com> |
Enable clang code format
Change-Id: Ib640ef7cea99ff505965182ec9900a2d53a8986e Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
#
7861079e |
| 21-Feb-2018 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
timer: Add missing functional include
std::function is not found with a GCC 7.2 runtime.
Change-Id: Id28ea8da225c6bae0742848ba3d379fbafcfc190 Tested: Built repository with GCC 7.2 Signed-off-by: Br
timer: Add missing functional include
std::function is not found with a GCC 7.2 runtime.
Change-Id: Id28ea8da225c6bae0742848ba3d379fbafcfc190 Tested: Built repository with GCC 7.2 Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
show more ...
|
#
95a72983 |
| 25-Oct-2017 |
Gunnar Mills <gmills@us.ibm.com> |
Spelling fixes
Spelling errors found using github.com/lucasdemarchi/codespell A tool to fix common misspellings. This tool is licensed under GNU General Public License, version 2.
Change-Id: I562cc
Spelling fixes
Spelling errors found using github.com/lucasdemarchi/codespell A tool to fix common misspellings. This tool is licensed under GNU General Public License, version 2.
Change-Id: I562cc5b407fb2a3a728c6167aaab75acde3adfca Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
#
671fc7f3 |
| 14-Jun-2017 |
Jayanth Othayoth <ojayanth@in.ibm.com> |
Add support for generic inotify based directory watch.
Watch a directory for the changes based on user configuration and then report changes to the user.
Change-Id: I9f53d3135dd4bff6187840c0c53d2a6
Add support for generic inotify based directory watch.
Watch a directory for the changes based on user configuration and then report changes to the user.
Change-Id: I9f53d3135dd4bff6187840c0c53d2a64509808cd Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
show more ...
|