#
aa0937f9 |
| 22-Jul-2023 |
Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> |
Generate error map as part of dump types
An error type is a specific type of BMC dump that is generated when a particular error is logged in the BMC. Previously, dump types and error types were mana
Generate error map as part of dump types
An error type is a specific type of BMC dump that is generated when a particular error is logged in the BMC. Previously, dump types and error types were managed independently, with error types being defined in separate files, namely 'error_map.hpp' and its associated mako template 'error_map.mako.cpp'. However, this practice led to inconsistencies, as the dreport script, which is used for handling dump collection and packaging, was interpreting error type as another dump type rather than as additional parameters.
The separate error_map.hpp file and its associated mako template (error_map.mako.cpp) have been removed. Instead, error types are now incorporated directly into the dump types along with an error type map for validating the error names. This integration aligns the code with the existing behaviour of the dreport script, allowing for more consistent processing of dump types
As a result of this integration, the error map generation is now part of the dump_types_mako.cpp file. To support these changes, a second input YAML file has been added to the map_gen.py script to generate the dump types and error types together.
Tests: Create InternalFailure > busctl call xyz.openbmc_project.Logging /xyz/openbmc_project/logging \ xyz.openbmc_project.Logging.Create Create ssa{ss} \ xyz.openbmc_project.Common.Error.InternalFailure \ xyz.openbmc_project.Logging.Entry.Level.Error 0 > dump created /var/lib/phosphor-debug-collector/dumps/1/\ BMCDUMP.XXXXXXXX.0000001.20230723084043
Create Checkstop > busctl call xyz.openbmc_project.Logging /xyz/openbmc_project/logging \ xyz.openbmc_project.Logging.Create Create ssa{ss} \ org.open_power.Host.Boot.Error.Checkstop \ xyz.openbmc_project.Logging.Entry.Level.Error 0 > /var/lib/phosphor-debug-collector/dumps/4/\ BMCDUMP.XXXXXXXX.0000004.20230723094150
Change-Id: Iac483f4993b59cf0fc063ed9584785f1a1fa04a8 Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
show more ...
|
#
c1f5ed6f |
| 09-Jul-2023 |
Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> |
Generate dump types table
This commit refines the map generation process in phosphor-debug-collector. The existing Python script is enhanced to accept varying templates and variable names, A new Mak
Generate dump types table
This commit refines the map generation process in phosphor-debug-collector. The existing Python script is enhanced to accept varying templates and variable names, A new Mako template is introduced for generating dump types. This enhancement allows different architectures to support various types of dumps without requiring major changes.
Tests: Successfully tested the creation of different types of BMC dumps.
Built with master and p10bmc
Change-Id: I347e218cb66386665bd15b72612dbe8e1e4fc7cf Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
show more ...
|