#
93f06410 |
| 02-Jun-2024 |
Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> |
Add Serialization Support for Dump Entry Attributes
Implemented serialization of dump entry attributes using the nlohmann::json library. Added serialization support in the Dump Entry class, serializ
Add Serialization Support for Dump Entry Attributes
Implemented serialization of dump entry attributes using the nlohmann::json library. Added serialization support in the Dump Entry class, serializing attributes including originatorId, originatorType, and startTime. These attributes are not part of the dump filename and thus require serialization to ensure their state is preserved.
Deserialization will occur only if the serialization version matches and the dump ID in the dump object matches the ID in the serialized file.
Tests: - Created BMC dumps and restarted service - Created BMC dumps and restarted BMC - Created 200 BMC dumps and restarted service and BMC multiple times
File: ``` {"dumpId":2,"originatorId":"","originatorType":1,"startTime":1718199238942411,"version":1} ```
Change-Id: I16ecb058bddd464c8771bd8d08a50ea1877747ed Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
show more ...
|
#
64f8da9e |
| 08-Dec-2021 |
Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> |
Implement GetFileHandle in dump entry interface
Certain applications need to offload the dump in various ways, for example, performing DMA transfer of the dump to the host memory. These applications
Implement GetFileHandle in dump entry interface
Certain applications need to offload the dump in various ways, for example, performing DMA transfer of the dump to the host memory. These applications require direct access to the file to read from the BMC storage.
This commit introduces the GetFileHandle method in the dump entry interface. This method provides direct access to the Unix file handle of the dump entry, facilitating more direct read operations on the dump file. The returned file descriptor is read-only, which ensures the integrity of the dump file.
The definition of the file handle is moved from the specific 'bmc_dump_entry' class to the parent 'dump_entry' class. This allows all dump types inheriting from 'dump_entry' to use this new method, thus increasing its utility across various dump types.
The introduction of this method primarily benefits PLDM for offloading the dump to the host, and bmcweb for offloading the dump to Redfish clients. By providing a file handle instead of exposing the file path, it resolves potential access issues for applications running in non-root contexts.
Test: Created a dump and made sure it reached host successfully Executed with additional traces Jun 21 10:56:09 pldmd[1856]: Requesting file handle Jun 21 10:56:09 pldmd[1856]: File handle received fd=9 Jun 21 10:56:09 pldmd[1856]: Transfer data rc= 0 Jun 21 10:56:09 phosphor-dump-manager[480]: File handle \ request Jun 21 10:56:09 phosphor-dump-manager[480]: returning fd=11 Jun 21 10:56:09 pldmd[1856]: File handle received fd=9 Jun 21 10:56:09 pldmd[1856]: File read rc=15
In th host: Service Processor Dump: Maximum file size: 0 (0x00000000) bytes (0 MBs) Dumps this PHYP IPL: 1 Pending Dump: Dump ID: 00000009 File size: 3749662 \ (0x000000000039371E) bytes (3 MBs) SP dump sub type: 0x000000000000000F BMC File name: \ BMCDUMP.1392A20.00000009.20230621105510 Dump create time: 06/21/2023 10:55:10.00 PHYP notify time: 06/21/2023 10:56:00.5918570000 LP recipient: 1 LP notify time: 06/21/2023 10:56:00.5918580000
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> Change-Id: If398940b655b4d90688273f0c76a20d4ead61992
show more ...
|
#
0b566d54 |
| 14-Jun-2023 |
Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> |
Minor cleanup: Remove unused header file and namespace
This commit performs minor by removing an unnecessary header file: phosphor-logging/log.hpp and namespace: using namespace phosphor::logging
T
Minor cleanup: Remove unused header file and namespace
This commit performs minor by removing an unnecessary header file: phosphor-logging/log.hpp and namespace: using namespace phosphor::logging
These cleanup changes have no impact on the functionality. They enhance code cleanliness, reduce potential confusion, and promote better code maintenance and readability.
Test: Created a full build to make sure no errors
Change-Id: I68f2d81c538d3f632e6edd24702efc6ae7b07086 Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
show more ...
|
#
4a98e8fe |
| 29-Jan-2020 |
Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> |
Update dump manager and entry to have multiple types
Created a base dump entry, who ever implementing a new dump type need to inherit from the base dump entry.
Signed-off-by: Dhruvaraj Subhashchand
Update dump manager and entry to have multiple types
Created a base dump entry, who ever implementing a new dump type need to inherit from the base dump entry.
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> Change-Id: Ie85d393f75ec697a7b02b84d131a4a8c0116c3e7
show more ...
|
#
cb65ffce |
| 16-Oct-2018 |
Jayanth Othayoth <ojayanth@in.ibm.com> |
Enable clang code format
Change-Id: Ib640ef7cea99ff505965182ec9900a2d53a8986e Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
#
580cb2d4 |
| 17-Jul-2017 |
Jayanth Othayoth <ojayanth@in.ibm.com> |
Delete dump ID directory during dump entry deletion
Change-Id: Ic77e86c9e45d4b25397a4b7cfd70e131a40bdfa8 Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
#
a3f6aa7f |
| 04-Jul-2017 |
Jayanth Othayoth <ojayanth@in.ibm.com> |
Handle filesystem exceptions during dump file removal.
Change-Id: If77e549ead60e6b6e21cd9069fbc0a324db6bc80 Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
#
a320c7ca |
| 14-Jun-2017 |
Jayanth Othayoth <ojayanth@in.ibm.com> |
Implementation of create interface.
Both the external and internal Dump managers define "Create" interfaces. This commit implements these.
Change-Id: If857ec6ea7267fd72e9b420e6b44fa68b6abab66 Signe
Implementation of create interface.
Both the external and internal Dump managers define "Create" interfaces. This commit implements these.
Change-Id: If857ec6ea7267fd72e9b420e6b44fa68b6abab66 Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
show more ...
|
#
224882b0 |
| 04-May-2017 |
Jayanth Othayoth <ojayanth@in.ibm.com> |
Initial commit for Dump.
Added initial version of Dump infrastructre code.
Change-Id: Icd9bc779035d12d2dabd6f49d0d04e9aa060d6c1 Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|