OpenPOWER: Return Unavailable Instead of NotAllowed for Delete

This commit changes the exception thrown from 'NotAllowed'
to 'Unavailable' when attempting to delete a system dump
that is currently b

OpenPOWER: Return Unavailable Instead of NotAllowed for Delete

This commit changes the exception thrown from 'NotAllowed'
to 'Unavailable' when attempting to delete a system dump
that is currently being offloaded. This modification aligns
with the objective to return an HTTP 'Unavailable' status
via Redfish interface in this scenario.

The 'Unavailable' response more accurately reflects the
system state, as the dump is not disallowed from deletion
under normal circumstances, but temporarily unavailable
due to the ongoing offload process.

Tests:
- Attempt to delete resource dump while offloading it
- Attempt to delete system dump while offloading it

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I6c5d9aba16380d86e68c06537417ad9d725826e5

show more ...

Implementing Phosphor-Logging/LG2 logging

This commit introduces changes in the phosphor-debug-collector
repository to implement structured logging using the LG2
framework. The existing log calls in

Implementing Phosphor-Logging/LG2 logging

This commit introduces changes in the phosphor-debug-collector
repository to implement structured logging using the LG2
framework. The existing log calls in the repository,
have been replaced with LG2 logging, facilitates better
log tracking and troubleshooting by offering improved
detail in JSON object values.

Test:
- Created BMC dump
- Created system dump

Here is a example
{
"_EXE" : "/tmp/phosphor-dump-manager",
"_MACHINE_ID" : "f9ca96d99c7b4ba688556f632ffeff5d",
"_CAP_EFFECTIVE" : "1ffffffffff",
"LOG2_FMTMSG" : "Invalid Dump file name, FILENAME: {FILENAME}",
"__CURSOR" : "s=721ae7a5b6ed43ec904f2bb03e3c0403;i=2a8d0;\
b=b372b9a5989e46bb8e62b33310e181ea;m=2c05fda2b;t=5fdf0684c1e70;x=1592f60584d6486c",
"CODE_FUNC" : "void phosphor::dump::bmc::Manager::\
createEntry(const std::filesystem::__cxx11::path&)",
"_SYSTEMD_SLICE" : "system-dropbear.slice",
"CODE_LINE" : "174",
"__REALTIME_TIMESTAMP" : "1686583867350640",
"PRIORITY" : "3",
"_SYSTEMD_UNIT" : "dropbear@1-9.3.29.238:22-9.3.84.138:45432.service",
"_PID" : "16209",
"_BOOT_ID" : "b372b9a5989e46bb8e62b33310e181ea",
"_SOURCE_REALTIME_TIMESTAMP" : "1686583867350580",
"_TRANSPORT" : "journal",
"_HOSTNAME" : "openbmc",
"SYSLOG_IDENTIFIER" : "phosphor-dump-manager",
"MESSAGE" : "Invalid Dump file name, \
FILENAME: BMCDUMP.XXXXXXX.0000006.20230612153010",
"CODE_FILE" : \
"/usr/src/debug/phosphor-debug-collector/1.0+gitAUTOINC+a17f1c92ce-r1\
/dump_manager_bmc.cpp",
"_UID" : "0",
"_CMDLINE" : "/tmp/phosphor-dump-manager",
"_RUNTIME_SCOPE" : "system",
"FILENAME" : "BMCDUMP.XXXXXXXX.0000006.20230612153010",
"_SYSTEMD_INVOCATION_ID" : "64a11629aade4c96ab62154cbc4be8b7",
"__MONOTONIC_TIMESTAMP" : "11817441835",
"_SYSTEMD_CGROUP" : "/system.slice/system-dropbear.slice/\
dropbear@1-9.3.29.238:22-9.3.84.138:45432.service",
"_COMM" : "phosphor-dump-m",
"_GID" : "0"
}

Change-Id: I3a52b812b059b64d945493de2e2cc68a43f6d72a
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

OpenPower: Return unavailable if any error in deleting host dump

If there is a failure in sending dump delete request to host
for resource and system dump, return unavailable error.

Signed-off-by:

OpenPower: Return unavailable if any error in deleting host dump

If there is a failure in sending dump delete request to host
for resource and system dump, return unavailable error.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: Ia85ef46c55c5a2b54af2b8632f94c3318ef1d4d1

show more ...

OpenPOWER: Prevent dump delete while offloading

Prevent the deletion of the dumps stored in host memory
while offload is in progress

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

OpenPOWER: Prevent dump delete while offloading

Prevent the deletion of the dumps stored in host memory
while offload is in progress

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I053d802a96548fdd9240cf21ef2bf91c4b38e367

show more ...

OpenPOWER: Use non blocking call for host dump offload request

Currently dump manager is using pldm_send_recv which is
a blocking call and if the host is not responding
dump manager will hang to avo

OpenPOWER: Use non blocking call for host dump offload request

Currently dump manager is using pldm_send_recv which is
a blocking call and if the host is not responding
dump manager will hang to avoid this using pldm_send
which is a non-blocking call.

Tests:

Send message while host is down and dump manager is
not hung.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: Ie90e217325da4c8778c7527afcd453a8fdce02c8

show more ...

OpenPOWER: Add additional trace to host dump operations

Adding additional traces to dump offload and
delete operations

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I5f

OpenPOWER: Add additional trace to host dump operations

Adding additional traces to dump offload and
delete operations

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I5f5ae40798483b4d4ef52fd518d4d8ffab6e15c4

show more ...

OpenPOWER: Do not wait for response deleting host dump

The resource dump delete is long running operation with
dbus call to PLDM for instance id, making it inside a
dbus call will end up timeouts wh

OpenPOWER: Do not wait for response deleting host dump

The resource dump delete is long running operation with
dbus call to PLDM for instance id, making it inside a
dbus call will end up timeouts when PLDM tries to
access dump manager. To avoid dead-locks dump manager
will not be waiting for response after a delete
operation

Testing:
Create system dump and delete the dump
Create 10 resource dumps and delete one by one

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I9c98c40672274a33097d9c4129ea52b5984c4246

show more ...

OpenPOWER: Fix for host dump delete

If the dump is not created by host or the request is not
complete the dump id provided by the host will not be
valid. When deleting such dump entries a request fo

OpenPOWER: Fix for host dump delete

If the dump is not created by host or the request is not
complete the dump id provided by the host will not be
valid. When deleting such dump entries a request for
delete should not be send to the host.

Tests:

Deleting a dump which is not finished when host is running

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: If7e8b7fad67c215f057152bb64b5232f198fee9e

show more ...

Error while invalidating the resource dump over PLDM.

Problem:
The wrong identifier type was passed to the host dump
transport for deleting the dump, so an exception
is thrown.
Fix was needed in two

Error while invalidating the resource dump over PLDM.

Problem:
The wrong identifier type was passed to the host dump
transport for deleting the dump, so an exception
is thrown.
Fix was needed in two places
1) Dump identifier number was old in resource dump manager
2) PLDM_FILE_TYPE_RESOURCE_DUMP_PARAMS was given as dump
identifier instead of PLDM_FILE_TYPE_RESOURCE_DUMP.
Test:
- Created a new dump
- Invalidated the dump
Result: Dump is deleted from the host.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: If68f415439d8322f47fa6a6bc7a9b230e9f67fb1

show more ...

Add support for resource dump delete.

Add support for deleting resource dumps in host memory.
Change requestDelete to accept dump type.
Update system dump delete to pass dump type.

Signed-off-by: D

Add support for resource dump delete.

Add support for deleting resource dumps in host memory.
Change requestDelete to accept dump type.
Update system dump delete to pass dump type.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I8dcf85a2b38da15ff8451003c11232e340c4ca89

show more ...

Change the the namespace of OpenPOWER dumps.

Change the namespace of OpenPOWER dumps to openpower
instead of phosphor.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I0b

Change the the namespace of OpenPOWER dumps.

Change the namespace of OpenPOWER dumps to openpower
instead of phosphor.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I0b99da60cb19f3cf559ce40c971b3ba6f4888238

show more ...

Add Resource dump support

To build use option -Dhost-transport=pldm and
-Dopenpower-dumps-extension=enabled
Add support for resource dump operations like
creation and offloading.
Tests:(Dump manager

Add Resource dump support

To build use option -Dhost-transport=pldm and
-Dopenpower-dumps-extension=enabled
Add support for resource dump operations like
creation and offloading.
Tests:(Dump manager tests)
Created dump entry.
Faked notify to check whether progress is turning to completed.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: Ifeec5670a7806d7ee1b572158b4fff7dc14729a6

show more ...