clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I9bb0aaa05541fe88ccabfaa5d00e3117e489ea8d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: Move callback instead of copy

We always want to instantiate these a single time, so we can move them.
In the future, the callback_t may chnage to a move only type so we can
support it thi

sdbusplus: Move callback instead of copy

We always want to instantiate these a single time, so we can move them.
In the future, the callback_t may chnage to a move only type so we can
support it this way.

Change-Id: I839298f43df108fd9d282fb4e4390e2d32ac3e78
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6a559082fed34ae62b648345ead793436d2d03f6

show more ...

logging: switch to lg2

After switching to C++20, it is recommended to use `phosphor::lg2`
to format log, and the correct `CODE_LINE` and `CODE_FUNC` values
can be used in log tracking.

Signed-off-b

logging: switch to lg2

After switching to C++20, it is recommended to use `phosphor::lg2`
to format log, and the correct `CODE_LINE` and `CODE_FUNC` values
can be used in log tracking.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I7de1e3782363c0c7f57ff917cf9487e4599cac8e

show more ...

Update clang-format

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I58738190d06bf216a13048d768aa4054d820d2e8

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If98df395e3717aa119e192457220e31ce3ea4fe7

show more ...

string: ensure string included

Latest upstream yocto appears to have removed a free include of string.
This is causing compile failures for files which do not include it
properly.

Signed-off-by: An

string: ensure string included

Latest upstream yocto appears to have removed a free include of string.
This is causing compile failures for files which do not include it
properly.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ie93f251b00db4d4a543b361262fad2201923e2c5

show more ...

update .clang-format

Added the header inclusion order to the .clang-format file generated
these changes.

Change-Id: I4f51a20f469de431ee6a5ba78e3f4da39c980fab
Signed-off-by: Patrick Venture <venture

update .clang-format

Added the header inclusion order to the .clang-format file generated
these changes.

Change-Id: I4f51a20f469de431ee6a5ba78e3f4da39c980fab
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

sdbusplus: Improve error handling

Ignore exceptions from sdbusplus for objects that are queried
as part of a property watch but are expected to be missing
when the BMC starts up.

Tested: The phosph

sdbusplus: Improve error handling

Ignore exceptions from sdbusplus for objects that are queried
as part of a property watch but are expected to be missing
when the BMC starts up.

Tested: The phosphor-dbus-monitor app does not core dump
with the latest sdbusplus changes.

Change-Id: I0f6a850f0e426478bd1ccacb910a44079b9c8a54
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Remove journal entries for failed sdbusplus calls

Calling code is already handling any missing method
call response data appropriately, and many times
the failed call is expected.

For example, any

Remove journal entries for failed sdbusplus calls

Calling code is already handling any missing method
call response data appropriately, and many times
the failed call is expected.

For example, any time there is a dbus monitor rule
that watches a property, it will try to read that
property right away on startup to cache the value
if possible. It's possible that some D-Bus objects
may not exist at that moment in time, and the code
already expects that.

Tested: No more 'Failed to parse method response'
journal entries.

Change-Id: Iaa84020a34a96395abf7a3460c96ec0dc255fa23
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add sdbusplus exception handling

Tested: Verified that the phosphor-dbus-monitor does
not core dump with the latest sdbusplus changes to
support sdbusplus exceptions. Instead it logs the
"Failed to

Add sdbusplus exception handling

Tested: Verified that the phosphor-dbus-monitor does
not core dump with the latest sdbusplus changes to
support sdbusplus exceptions. Instead it logs the
"Failed to parse method response" error msg in the journal.

Resolves openbmc/openbmc#3213

Change-Id: I11347725364b5a43df6c0c1c377d65ce361a419c
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Enable clang-format

Fix up errors and enable clang-format during CI builds.

Change-Id: I4176b81f8b85a287af9354165e09ff66aeb9fb29
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

Change the access mode of the function getBus

GetBus function provides the same instance of the
bus application in the process.

Now there is a need where we need the same bus instance
at multiple p

Change the access mode of the function getBus

GetBus function provides the same instance of the
bus application in the process.

Now there is a need where we need the same bus instance
at multiple places.

Remove the friend loop, now it is not needed as we have
changed the scope of getBus.

Change-Id: I7e8cda45f3835b1d93be36f317741bc4ae6951a2
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Add getBusName() utility function to SDBusPlus

Add a function to SDBusPlus to get the D-Bus bus
name for an object path and interface.

Change-Id: I7d7a533c7430fcf42e1e0f6a21a2453e6c8197ea
Signed-of

Add getBusName() utility function to SDBusPlus

Add a function to SDBusPlus to get the D-Bus bus
name for an object path and interface.

Change-Id: I7d7a533c7430fcf42e1e0f6a21a2453e6c8197ea
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Attach sdevent mainloop to dbus

Switch from sd_bus process to sd_event run so that sd event
handlers are invoked.

Change-Id: If7c1f046f30cc845c6e9fcc72eb99c5bdfb36052
Signed-off-by: Brad Bishop <br

Attach sdevent mainloop to dbus

Switch from sd_bus process to sd_event run so that sd event
handlers are invoked.

Change-Id: If7c1f046f30cc845c6e9fcc72eb99c5bdfb36052
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Method support

Add support for a method callback. The method callback enables
arbitrary DBus method calls. A sample use case could be
starting a systemd unit via the sytemd DBus API.

Change-Id: I

Method support

Add support for a method callback. The method callback enables
arbitrary DBus method calls. A sample use case could be
starting a systemd unit via the sytemd DBus API.

Change-Id: If25131d11497c82f862ae1f47da066c5fd8b2e2e
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Add sdbusplus delegate

Add a DBus interface abstraction to facilitate
mocking and unit test.

Change-Id: I914cba7500d79bc4d3022cb12e4c02adf6a78c19
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel

Add sdbusplus delegate

Add a DBus interface abstraction to facilitate
mocking and unit test.

Change-Id: I914cba7500d79bc4d3022cb12e4c02adf6a78c19
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...