clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I9bb0aaa05541fe88ccabfaa5d00e3117e489ea8d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Iccc8a6107616afb3a6b772420651e717a688ce86
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ic2c9732543fc02a10df820078faa767638b179b5
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I7801712fe34e10fec586d1e962afebd9ebcce46c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6a559082fed34ae62b648345ead793436d2d03f6

show more ...

Fix cppcheck warnings

Warning message:
mslverify/verify.cpp:30:5: style: Struct 'BusMeetsMSL < decltype ( arg . second ) :: value_type >' has a constructor with 1 argument that is not explicit. [noE

Fix cppcheck warnings

Warning message:
mslverify/verify.cpp:30:5: style: Struct 'BusMeetsMSL < decltype ( arg . second ) :: value_type >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
BusMeetsMSL(const std::string& p) : path(p)
^
src/callback.hpp:222:5: warning: Member variable 'DeferrableCallback::ctx' is not initialized in the constructor. [uninitMemberVar]
DeferrableCallback(const std::vector<size_t>& graphEntry, Conditional& cond,
^
src/elog.hpp:102:5: style: Class 'Elog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
Elog(Args&&... arguments) :
^
src/propertywatch.hpp:133:5: style: Class 'PropertyWatchOfType' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
PropertyWatchOfType(const PropertyIndex& watchIndex,
^
src/event_manager.cpp:56:18: style: Local variable 'path' shadows outer variable [shadowVariable]
fs::path path(eventQueue.back()->objectPath);
^
src/event_manager.cpp:44:10: note: Shadowed declaration
auto path = "path="s + objectPath;
^
src/event_manager.cpp:56:18: note: Shadow variable
fs::path path(eventQueue.back()->objectPath);
^
src/snmp_trap.hpp:65:10: style: The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
void operator()(Context /* ctx */)
^
src/callback.hpp:41:18: note: Virtual function in base class
virtual void operator()(Context /* ctx */) = 0;
^
src/snmp_trap.hpp:65:10: note: Function in derived class
void operator()(Context /* ctx */)
^
src/snmp_trap.hpp:72:10: style: The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
void operator()(Context /* ctx */, sdbusplus::message::message& msg)
^
src/callback.hpp:50:18: note: Virtual function in base class
virtual void operator()(Context /* ctx */,
^
src/snmp_trap.hpp:72:10: note: Function in derived class
void operator()(Context /* ctx */, sdbusplus::message::message& msg)
^
src/snmp_trap.cpp:44:17: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm]
message += " " + s;
^
src/test/pathgentest.cpp:118:21: style: Local variable 'meta' shadows outer variable [shadowVariable]
const auto& meta = std::get<1>(pathMeta[i]).get();
^
src/test/pathgentest.hpp:1:34: note: Shadowed declaration
const std::array<std::string, 3> meta = {
^
src/test/pathgentest.cpp:118:21: note: Shadow variable
const auto& meta = std::get<1>(pathMeta[i]).get();
^
src/test/propertygentest.cpp:133:25: style: Local variable 'expectedMeta' shadows outer variable [shadowVariable]
const auto& expectedMeta = std::get<1>(expectedGroups[i][j]).get();
^
src/test/propertygentest.cpp:17:34: note: Shadowed declaration
const std::array<std::string, 3> expectedMeta = {
^
src/test/propertygentest.cpp:133:25: note: Shadow variable
const auto& expectedMeta = std::get<1>(expectedGroups[i][j]).get();
^
src/test/propertywatchtest.cpp:263:21: style: Local variable 'interfaces' shadows outer variable [shadowVariable]
const auto& interfaces = o.second;
^
src/test/propertywatchtest.cpp:18:34: note: Shadowed declaration
const std::array<std::string, 2> interfaces = {
^
src/test/propertywatchtest.cpp:263:21: note: Shadow variable
const auto& interfaces = o.second;
^
src/test/propertywatchtest.cpp:280:25: style: Local variable 'properties' shadows outer variable [shadowVariable]
const auto& properties = i.second;
^
src/test/propertywatchtest.cpp:23:34: note: Shadowed declaration
const std::array<std::string, 2> properties = {
^
src/test/propertywatchtest.cpp:280:25: note: Shadow variable
const auto& properties = i.second;
^

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ica5d54cefe22fed961f01aa6288b4cf76a9db563

show more ...

Fix cppcheck warnings

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: If5d808b9cb3bc733e7e21d546247d745ac5e1bf8

Update clang-format

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I58738190d06bf216a13048d768aa4054d820d2e8

size_t: ensure cstddef included

Latest upstream yocto appears to have removed a free include of cstddef.
This is causing compile failures for files which do not include it
properly.

Signed-off-by:

size_t: ensure cstddef included

Latest upstream yocto appears to have removed a free include of cstddef.
This is causing compile failures for files which do not include it
properly.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I5933ec83cfb654d000c24c49a9e4ace79c5666e3

show more ...

Saving current context in DeferrableCallback added.

DeferrableCallback operator() saves the context in
self instance. When the timer expires, it calls
operator() for the ConditionalCallback with the

Saving current context in DeferrableCallback added.

DeferrableCallback operator() saves the context in
self instance. When the timer expires, it calls
operator() for the ConditionalCallback with the
context saved in DeferrableCallback instance.

Resolves openbmc/phosphor-dbus-monitor#1

Change-Id: I8d235b0747005c403829f8262d0290548b0a9910
Signed-off-by: Alexander Soldatov <a.soldatov@yadro.com>

show more ...

sdevent: Remove in favor of sdeventplus

This change removes the one off sd-event wrapper from the project and
uses the openbmc wide sdeventplus library.

Change-Id: I8e042f875d06082e15606c7191a80739

sdevent: Remove in favor of sdeventplus

This change removes the one off sd-event wrapper from the project and
uses the openbmc wide sdeventplus library.

Change-Id: I8e042f875d06082e15606c7191a8073974f93990
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

update .clang-format

Added the header inclusion order to the .clang-format file generated
these changes.

Change-Id: I4f51a20f469de431ee6a5ba78e3f4da39c980fab
Signed-off-by: Patrick Venture <venture

update .clang-format

Added the header inclusion order to the .clang-format file generated
these changes.

Change-Id: I4f51a20f469de431ee6a5ba78e3f4da39c980fab
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Add SNMP event callback for error notification

Added callback support for SNMP events.

Parse the callback message and raise SNMP trap

Clients specify the object paths to watch and callbacks
to inv

Add SNMP event callback for error notification

Added callback support for SNMP events.

Parse the callback message and raise SNMP trap

Clients specify the object paths to watch and callbacks
to invoke in the config yaml.

Change-Id: I105652f65e4e1c5354c934c88e4d59866540f71c
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Enable clang-format

Fix up errors and enable clang-format during CI builds.

Change-Id: I4176b81f8b85a287af9354165e09ff66aeb9fb29
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

Add callback contexts

Add the notion of a callback context. This enables callbacks
to have logic around the conditions they were invoked in.

There are two context on which call back can be invoked

Add callback contexts

Add the notion of a callback context. This enables callbacks
to have logic around the conditions they were invoked in.

There are two context on which call back can be invoked
1) Startup: during startup all the call backs will be called
2) Signal: As part of condition match on the watched properties.

Callback would behave differently based on the context.
eg: eventCallback
1) Startup: Don't take any action.
2) Signal: Create the Dbus Object for the event.

Change-Id: If455558798ac3e44bbd8a93de0ce1b09d2e308ae
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I83c84

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I83c844373ea41d762367085cb16b01d31676e33d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add deferrable callbacks

Deferrable callbacks delay callback invocation until a
pre configured length of time has elapsed. One example
scenario where deferrable callbacks help is to avoid
oscillati

Add deferrable callbacks

Deferrable callbacks delay callback invocation until a
pre configured length of time has elapsed. One example
scenario where deferrable callbacks help is to avoid
oscillation when testing a condition and making callbacks
frequently.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I180c99b57ec1c9bde4da76d947a026f809341c8a

show more ...

Add conditional callbacks

Enable conditional application of callbacks.

Change-Id: I9d765e5f585aac40994b65da3b51ea891beae9bf
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

Add callback groups

Allow named collections of callbacks to be defined and used anywhere
callbacks are used.

Change-Id: I3224aa06b2250e9a055bc70d20c186caecd033af
Signed-off-by: Brad Bishop <bradley

Add callback groups

Allow named collections of callbacks to be defined and used anywhere
callbacks are used.

Change-Id: I3224aa06b2250e9a055bc70d20c186caecd033af
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Add support for callbacks

Callbacks are the response in the PDM 'trigger->response' model.
Add general support for implementing callbacks and implement
a log to systemd journal using that framework.

Add support for callbacks

Callbacks are the response in the PDM 'trigger->response' model.
Add general support for implementing callbacks and implement
a log to systemd journal using that framework.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I8bead5368ee5472a02b47e8bba9e9df3a1f346bc

show more ...