#
c5fe26a6 |
| 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: I7801712fe34e10fec586d1e962afebd9ebcce46c Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
#
ecef1191 |
| 06-Jul-2022 |
George Liu <liuxiwei@inspur.com> |
Fix cppcheck warnings
Warning message: mslverify/verify.cpp:30:5: style: Struct 'BusMeetsMSL < decltype ( arg . second ) :: value_type >' has a constructor with 1 argument that is not explicit. [noE
Fix cppcheck warnings
Warning message: mslverify/verify.cpp:30:5: style: Struct 'BusMeetsMSL < decltype ( arg . second ) :: value_type >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] BusMeetsMSL(const std::string& p) : path(p) ^ src/callback.hpp:222:5: warning: Member variable 'DeferrableCallback::ctx' is not initialized in the constructor. [uninitMemberVar] DeferrableCallback(const std::vector<size_t>& graphEntry, Conditional& cond, ^ src/elog.hpp:102:5: style: Class 'Elog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] Elog(Args&&... arguments) : ^ src/propertywatch.hpp:133:5: style: Class 'PropertyWatchOfType' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] PropertyWatchOfType(const PropertyIndex& watchIndex, ^ src/event_manager.cpp:56:18: style: Local variable 'path' shadows outer variable [shadowVariable] fs::path path(eventQueue.back()->objectPath); ^ src/event_manager.cpp:44:10: note: Shadowed declaration auto path = "path="s + objectPath; ^ src/event_manager.cpp:56:18: note: Shadow variable fs::path path(eventQueue.back()->objectPath); ^ src/snmp_trap.hpp:65:10: style: The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] void operator()(Context /* ctx */) ^ src/callback.hpp:41:18: note: Virtual function in base class virtual void operator()(Context /* ctx */) = 0; ^ src/snmp_trap.hpp:65:10: note: Function in derived class void operator()(Context /* ctx */) ^ src/snmp_trap.hpp:72:10: style: The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] void operator()(Context /* ctx */, sdbusplus::message::message& msg) ^ src/callback.hpp:50:18: note: Virtual function in base class virtual void operator()(Context /* ctx */, ^ src/snmp_trap.hpp:72:10: note: Function in derived class void operator()(Context /* ctx */, sdbusplus::message::message& msg) ^ src/snmp_trap.cpp:44:17: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] message += " " + s; ^ src/test/pathgentest.cpp:118:21: style: Local variable 'meta' shadows outer variable [shadowVariable] const auto& meta = std::get<1>(pathMeta[i]).get(); ^ src/test/pathgentest.hpp:1:34: note: Shadowed declaration const std::array<std::string, 3> meta = { ^ src/test/pathgentest.cpp:118:21: note: Shadow variable const auto& meta = std::get<1>(pathMeta[i]).get(); ^ src/test/propertygentest.cpp:133:25: style: Local variable 'expectedMeta' shadows outer variable [shadowVariable] const auto& expectedMeta = std::get<1>(expectedGroups[i][j]).get(); ^ src/test/propertygentest.cpp:17:34: note: Shadowed declaration const std::array<std::string, 3> expectedMeta = { ^ src/test/propertygentest.cpp:133:25: note: Shadow variable const auto& expectedMeta = std::get<1>(expectedGroups[i][j]).get(); ^ src/test/propertywatchtest.cpp:263:21: style: Local variable 'interfaces' shadows outer variable [shadowVariable] const auto& interfaces = o.second; ^ src/test/propertywatchtest.cpp:18:34: note: Shadowed declaration const std::array<std::string, 2> interfaces = { ^ src/test/propertywatchtest.cpp:263:21: note: Shadow variable const auto& interfaces = o.second; ^ src/test/propertywatchtest.cpp:280:25: style: Local variable 'properties' shadows outer variable [shadowVariable] const auto& properties = i.second; ^ src/test/propertywatchtest.cpp:23:34: note: Shadowed declaration const std::array<std::string, 2> properties = { ^ src/test/propertywatchtest.cpp:280:25: note: Shadow variable const auto& properties = i.second; ^
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: Ica5d54cefe22fed961f01aa6288b4cf76a9db563
show more ...
|
#
13e3df60 |
| 22-Jun-2022 |
George Liu <liuxiwei@inspur.com> |
logging: switch to lg2
After switching to C++20, it is recommended to use `phosphor::lg2` to format log, and the correct `CODE_LINE` and `CODE_FUNC` values can be used in log tracking.
Signed-off-b
logging: switch to lg2
After switching to C++20, it is recommended to use `phosphor::lg2` to format log, and the correct `CODE_LINE` and `CODE_FUNC` values can be used in log tracking.
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I7de1e3782363c0c7f57ff917cf9487e4599cac8e
show more ...
|
#
3fe976cc |
| 20-Jun-2022 |
George Liu <liuxiwei@inspur.com> |
Update clang-format
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I58738190d06bf216a13048d768aa4054d820d2e8
|
#
3d6d3182 |
| 31-Aug-2018 |
Patrick Venture <venture@google.com> |
update .clang-format
Added the header inclusion order to the .clang-format file generated these changes.
Change-Id: I4f51a20f469de431ee6a5ba78e3f4da39c980fab Signed-off-by: Patrick Venture <venture
update .clang-format
Added the header inclusion order to the .clang-format file generated these changes.
Change-Id: I4f51a20f469de431ee6a5ba78e3f4da39c980fab Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
#
d1eac88d |
| 29-Mar-2018 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
Enable clang-format
Fix up errors and enable clang-format during CI builds.
Change-Id: I4176b81f8b85a287af9354165e09ff66aeb9fb29 Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
#
b1e329a6 |
| 02-Aug-2017 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
Add phosphor-msl-verify
phosphor-msl-verify is a oneshot application for basic minimum ship level (MSL) verification.
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_pro
Add phosphor-msl-verify
phosphor-msl-verify is a oneshot application for basic minimum ship level (MSL) verification.
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Control/README.msl.md
Change-Id: Ifa036bb0a45255af7c7773bd910e83c64842d868 Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
show more ...
|