Dump.Create: Add system dump path

Update paths to include SYSTEM segment too, which is needed
for xyz.openbmc_project.Dump.Entry.System interface

Change-Id: I7ca769871c9cdc5ce7c4d4b80187f447bb169cb

Dump.Create: Add system dump path

Update paths to include SYSTEM segment too, which is needed
for xyz.openbmc_project.Dump.Entry.System interface

Change-Id: I7ca769871c9cdc5ce7c4d4b80187f447bb169cb6
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Dump.Create.CreateParameters: Fix documentation typo

Change-Id: I0f18f881afc09f0d1e76b5ccec1cf21c33902601
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

Dump.Create: add default path and service names

Add default service name for the phosphor-debug-collector
implementation and paths for the dump namespace.

Signed-off-by: Patrick Williams <patrick@s

Dump.Create: add default path and service names

Add default service name for the phosphor-debug-collector
implementation and paths for the dump namespace.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I30714dbe9f91e0bbff53b0fa45086ec871421d63

show more ...

Add 'EventId' parameter to BMC Dump creation parameters

This commit adds a new 'EventId' parameter to the BMC Dump
creation parameters. The 'EventId' parameter is used to
link a BMC dump with a spec

Add 'EventId' parameter to BMC Dump creation parameters

This commit adds a new 'EventId' parameter to the BMC Dump
creation parameters. The 'EventId' parameter is used to
link a BMC dump with a specific system event, providing
clearer context and allowing for the collection of additional,
relevant diagnostic data related to the event.

Change-Id: Ia092caa42c3917febfd5e8b447f49bc9078812c2
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Update InternalFailure Type and Add Error Type Parameter

This commit modifies the 'InternalFailure' dump type and replaces
it with a more generic 'ErrorLog' type. In addition, it introduces
a new pa

Update InternalFailure Type and Add Error Type Parameter

This commit modifies the 'InternalFailure' dump type and replaces
it with a more generic 'ErrorLog' type. In addition, it introduces
a new parameter for specifying the type of the error that
triggered the dump.

This is allowing it to cater to various types of errors beyond just
internal failures. With the capability to pass architecture-specific
errors, this change increases compatibility and maintainability without
requiring alterations in the common interface YAML file for each new
error type to be supported.

Change-Id: I896bb995632dad1206385ef92819f3bfffd16f88
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Use createDump method to create different types of BMC dumps

There are two create interfaces for phosphor-debug-collector.
1- external create - this interface
Which accepts a list of key-value pairs

Use createDump method to create different types of BMC dumps

There are two create interfaces for phosphor-debug-collector.
1- external create - this interface
Which accepts a list of key-value pairs as input,
but initially, this was not accepting any parameters.

2- A create interface in phosphor-debug-collector,
which accepts the type of the BMC dump and a set of
paths to dbus or files to collect as part of dump creation.

The internal create is called by core-monitor or ramoops monitor
to create BMC dump when the error has occurred, or a core is created,
and now there is a new requirement to pass error log id along with
these create calls.

The internal create is added to pass parameters, and the external
one is always assumed as user-initiated. Since now the createDump method
is accepting additional parameters, internal create can be removed
and both system-generated and user-initiated dumps can use the
same interface and method.

This commit adds the dump type and enumeration for the types,
additionally changing the path parameter from the array of strings
to a single string because only for the core dump, there is an attempt
to send multiple paths but that can be captured in the packaging script
if the folder is sent.

Change-Id: Icbeb8499fbdfc1f8919b571495a50867bdcecac1
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts (and
copy latest config files where appropriate). Fix a few minor
markdownlint issues.

Signed-off-by: Pat

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts (and
copy latest config files where appropriate). Fix a few minor
markdownlint issues.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I55205817c29dc3f182a165ddf9cd5d4e07b90063

show more ...

Dump: Create: Add Unavailable error

Some types of dumps cannot be initiated when another dump
is in progress, return Unavailable error when the dump
cannot be created.

Signed-off-by: Dhruvaraj Subh

Dump: Create: Add Unavailable error

Some types of dumps cannot be initiated when another dump
is in progress, return Unavailable error when the dump
cannot be created.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I5590181a7d6c31cd40dc1d673924b56a1a38f186

show more ...

createDump: Add Originator info as additional parameter

This commit adds "OriginatorId" & "OriginatorType" of the
"xyz.openbmc_project.Common.OriginatedBy" interface as
additional parameter in the c

createDump: Add Originator info as additional parameter

This commit adds "OriginatorId" & "OriginatorType" of the
"xyz.openbmc_project.Common.OriginatedBy" interface as
additional parameter in the createDump dbus call.

The "AdditionalData" parameter in createDump call will
be in a key-value format and the key in this case would be
"xyz.openbmc_project.Common.OriginatorId"; the value
would be any unique identifier of the user/component that
initiated the dump. This is an optional parameter and will be
implemented for user-triggered dumps.

The createDump dbus call with OriginatorId will now look like:
busctl call xyz.openbmc_project.Dump.Manager \
/xyz/openbmc_project/dump/bmc xyz.openbmc_project.Dump.Create \
CreateDump a{sv} 2 "xyz.openbmc_project.Dump.Create.CreateParameters.OriginatorId" \
s "<unique-id>" "xyz.openbmc_project.Dump.Create.CreateParameters.OriginatorType" \
s "<originatorType>"

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I220f20077fc069f798b40583b8918695e18152c2

show more ...

Dump: add file open error to Create interface

Add "xyz.openbmc_project.Common.File.Error.Open" to the list of errors
for the case where a dump file couldn't be opened in the course of dump
creation.

Dump: add file open error to Create interface

Add "xyz.openbmc_project.Common.File.Error.Open" to the list of errors
for the case where a dump file couldn't be opened in the course of dump
creation.

Initial usage in phosphor-debug-collector repo:
https://github.com/openbmc/phosphor-debug-collector/commit/919f71c652728da24e3e78e3ef14662265c5f812#diff-917a58c38d39e3d9353bec42ba512927c880aa5df49a3aa1700498fb17b25926R80

Signed-off-by: Claire Weinan <cweinan@google.com>
Change-Id: Ief61e89e0b5976a500447a445d90a3520ea20164

show more ...

yaml: format with prettier

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I193f690f3612fe72ec69030f81f4d5096a761601

In dump create add type uint64 for values in additional parameters

The additional parameters passed to the dump create interfaces
are accepting a key-value pair and the value should be a string.
In

In dump create add type uint64 for values in additional parameters

The additional parameters passed to the dump create interfaces
are accepting a key-value pair and the value should be a string.
In some of the dump use cases an integer error log id needs to be
passed, it was being passed as a string. But to make it
more readable and to reduce conversion errors, updating the dict
definition to accept 32 bit unsigned integer.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: Iefc3a49c2d569a4b179fc515938349f8f84bb3ae

show more ...

Add InvalidArgument to the list of errors while creating dump.

Add xyz.openbmc_project.Common.Error.InvalidArgument to the
list of errors while creating dump.
The xyz.openbmc_project.Dump.Create acc

Add InvalidArgument to the list of errors while creating dump.

Add xyz.openbmc_project.Common.Error.InvalidArgument to the
list of errors while creating dump.
The xyz.openbmc_project.Dump.Create accepts a list of
arguments as key-value pairs. InvalidArgument exception
may be raised if any of the arguments are not correct.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I995547d32042b4ad1acd1a3f853d4a9b6358424f

show more ...

treewide: Create yaml directory

This allows the propagated yamldir paramter to work correctly in
subproject style builds. We don't want other files in the project
conflicting with tools that scan th

treewide: Create yaml directory

This allows the propagated yamldir paramter to work correctly in
subproject style builds. We don't want other files in the project
conflicting with tools that scan the yamldir.

Change-Id: Ie2759c7f3baf399392cdda0e507055ceb262d2e1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...