#
a2f68d8b |
| 16-Aug-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda forma
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda formatting also changed, so we have made changes to the organization default style format to better handle lambda formatting.
See I5e08687e696dd240402a2780158664b7113def0e for updated style. See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.
Change-Id: Ic1ad64722b2368169dfb0e62c37f7f3c1ff20fe8 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
#
6f45ce04 |
| 19-Sep-2022 |
Nan Zhou <nanzhoumails@gmail.com> |
bmc-vmi-ca: use processs_loop
In reference [1], sdbusplus introduces its own process loop. This patch removed the unncesssary sdeventplus dependency from bmc-vmi-ca, and uses the sdbusplus built-in
bmc-vmi-ca: use processs_loop
In reference [1], sdbusplus introduces its own process loop. This patch removed the unncesssary sdeventplus dependency from bmc-vmi-ca, and uses the sdbusplus built-in process loop instead.
[1] https://gerrit.openbmc.org/c/openbmc/sdbusplus/+/56891
Tested: 1. The daemon starts correctly 2. Tested several dbus commands via busctl (introspect, DeleteAll, etc)
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com> Change-Id: I802f18f077e7b0bd3bf0b910c56b1f560fe342e7
show more ...
|
#
b3dbfb37 |
| 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are for: * bus_t * exception_t * manager_t * match_t * message_t * object_t * slot_t
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I9bb7b9a430d029ddaf2a08ea26acb775b9b2b152
show more ...
|
#
cf06ccdc |
| 28-Dec-2021 |
Nan Zhou <nanzhoumails@gmail.com> |
clean up using directives and type alias
Most C++ style guides try to avoid using directives in headers and also suggest using type alias carefully, according to which, this change does the followin
clean up using directives and type alias
Most C++ style guides try to avoid using directives in headers and also suggest using type alias carefully, according to which, this change does the following clean up:
1. used Enum class to represent Certificate type 2. removed all using directives: e.g. the phosphor logging namespace; instead, this change uses using declarations 3. removed unnecessary type alias; in existing codes, we only support strings as types of UnitToRestart, InstallPath, UploadPath, etc; this change uses std::string directly 4. moved all alias outside any class scope into source files or an internal namespace 5. renamed types, constants, classes as per OpenBMC style guide 6. fixed all compilation errors and some warnings after the refactoring; built with both Clang & GCC
Reference: https://docs.microsoft.com/en-us/cpp/cpp/header-files-cpp?view=msvc-170#what-to-put-in-a-header-file https://google.github.io/styleguide/cppguide.html#Namespaces
Tested: Unit tests
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com> Change-Id: I58e026934a4e969f4d8877801c8f3c671990468a
show more ...
|
#
e1289adf |
| 28-Dec-2021 |
Nan Zhou <nanzhoumails@gmail.com> |
Use nested namespace
Nested namespace is introduced in C++ 17. This saves nearly 50 lines. This change also puts tests into a nested namespace, which saves unnecessary using directives.
Signed-off-
Use nested namespace
Nested namespace is introduced in C++ 17. This saves nearly 50 lines. This change also puts tests into a nested namespace, which saves unnecessary using directives.
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com> Change-Id: I7c3e38588fd5c2cbd83ac13ee24327318e8c06a4
show more ...
|
#
ea7c3f0c |
| 15-Sep-2020 |
Ravi Teja <raviteja28031990@gmail.com> |
Add unit testcases for CA certificate authority manager
This test cases can be enabled by using below feature flag "--enable-ca-cert-extension"
Testcases: testObjectCreation testInvalidArgument Del
Add unit testcases for CA certificate authority manager
This test cases can be enabled by using below feature flag "--enable-ca-cert-extension"
Testcases: testObjectCreation testInvalidArgument DeleteAllCSRObjects DeleteObjectEntry
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com> Change-Id: I9e30f28ef73ecdc377ae357e9c73c42063f85137
show more ...
|
#
a49895ee |
| 16-Jun-2020 |
Ravi Teja <raviteja28031990@gmail.com> |
Implementation of BMC VMI certificate manager
This manager is to create and manage entries for each host CSR request which needs to shared with host.
this commits implements dbus interfaces https:/
Implementation of BMC VMI certificate manager
This manager is to create and manage entries for each host CSR request which needs to shared with host.
this commits implements dbus interfaces https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/31808
This feature can be enabled by using below feature flag "--enable-ca-cert-extension"
Testby: Creating CSR entries Deleting entries Setting properties
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com> Change-Id: I24829b839feac6264f32053b9be63daef6599379
show more ...
|