clang-tidy: Enable readability-simplify-boolean-expr check

This check looks for boolean expressions involving boolean
constants and simplifies them to use the appropriate boolean
expression directly

clang-tidy: Enable readability-simplify-boolean-expr check

This check looks for boolean expressions involving boolean
constants and simplifies them to use the appropriate boolean
expression directly.

Change-Id: I79d7e4486bd0ea5f5b9b5a1644af99384e41e251
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable readability-braces-around-statements check

This checks that bodies of if statements and loops (for, do while,
and while) are inside braces.

Change-Id: Iaf9d170f179f2363b632cbbc7d

clang-tidy: Enable readability-braces-around-statements check

This checks that bodies of if statements and loops (for, do while,
and while) are inside braces.

Change-Id: Iaf9d170f179f2363b632cbbc7da7b0ea3220aee7
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

Populate MinimumVersion property

The Minimum Version is now an available D-Bus interface:
```
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/70110
```
Populate its value if it's bei

Populate MinimumVersion property

The Minimum Version is now an available D-Bus interface:
```
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/70110
```
Populate its value if it's being defined.

Tested: If the msl meson options are defined, the D-Bus property is
populated with the value of the defined minimum version:
```
root@witherspoon:~# busctl get-property xyz.openbmc_project.Software.BMC.Updater /xyz/openbmc_project/software xyz.openbmc_project.Software.MinimumVersion MinimumVersion
s "2.15.0"
```

Change-Id: I0f9df0cfd7c06794df836e161b3416094a8535de
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

errors: Use non-deprecated namespaces

The error namespaces have been updated. Reference:
https://gerrit.openbmc.org/c/openbmc/sdbusplus/+/66308
https://gerrit.openbmc.org/c/openbmc/phosphor-logging/

errors: Use non-deprecated namespaces

The error namespaces have been updated. Reference:
https://gerrit.openbmc.org/c/openbmc/sdbusplus/+/66308
https://gerrit.openbmc.org/c/openbmc/phosphor-logging/+/66463

Tested: Compiled with the SDBUSPP_REMOVE_DEPRECATED_NAMESPACE option.

Change-Id: Idd1ca6f14635039bd8bd2f34d69afd3e97588648
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I50e60f2b1a9db9039cb5450ae509064eaeaa9d2e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Change location of MSL error

The prev_entry() functionality that was being used to pass meta
data was not performing as expected. To make sure all the
desired information is passed to the event logs

Change location of MSL error

The prev_entry() functionality that was being used to pass meta
data was not performing as expected. To make sure all the
desired information is passed to the event logs. This is done
by reporting directly from the msl_verify.cpp file where the
information is then directly reported.

Signed-off-by: Zami Seck <zimzam17@gmail.com>
Change-Id: I4c4a41a104db9dcf303914b4a5e4e43908082414

show more ...

logging: switch to lg2

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id62fbc10ab83a0cf94d235e1d1ea3e031295fbf5

msl_verify: dos2unix

These two files were saved with 'dos' newline characters. Run
'dos2unix' on them to make them Unix-style newline.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id

msl_verify: dos2unix

These two files were saved with 'dos' newline characters. Run
'dos2unix' on them to make them Unix-style newline.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9ac15b830a1becbfaba327967022a050beb8fe54

show more ...

BMC Minimum ship Level

This code compares the BMC_MSL defined at compile time,
It will parse the new fw (explicit at MANIFEST file) and use regex to
evaluate it and compare BMC_MSL against version

BMC Minimum ship Level

This code compares the BMC_MSL defined at compile time,
It will parse the new fw (explicit at MANIFEST file) and use regex to
evaluate it and compare BMC_MSL against version from MANIFEST.
If newer or equal it will apply, otherwise it will fail,
preventing activation operation.

Tested:
regex-bmc-msl="([a-z]+[0-9]{2})+([0-9]+).([0-9]+).([0-9]+)"
fw-package="version=fw1010.00-28.4-0-ge611abca21"
bmc-msl="fw1010.00-27" proceeds with activation...
bmc-msl="fw1010.00-29" returns:

Jul 15 20:35:45 tacoma1z-w81 phosphor-image-updater[766]:
BMC Minimum Ship Level NOT met

Jul 15 20:35:45 tacoma1z-w81 phosphor-image-updater[766]:
A system component has a software version that is incompatible as
determined by the implementation and needs to be updated....

Signed-off-by: Miguel Gomez <mgomez@mx1.ibm.com>
Change-Id: I0ab0eba7c7c89f38ca698aa3e369aa50797edb07

show more ...