clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I299e3888aee418ddcf391a44cd9ba563edabfe83
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

switch fmt::format to use std::format

fmt::format is supported in the c++ std. This will
help to remove fmt package dependency.

Change-Id: Ia3f5c607a348f062a0f112d5eae8b51ecc23fd37
Signed-off-by: J

switch fmt::format to use std::format

fmt::format is supported in the c++ std. This will
help to remove fmt package dependency.

Change-Id: Ia3f5c607a348f062a0f112d5eae8b51ecc23fd37
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I66785e0aa71a93f9370db0168049cd62c1f69728
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Change daily clock log to informational severity

The event log was using a severity of Error, and because the PEL message
registry had a severity of Informational, phosphor-log-manager would
spit ou

Change daily clock log to informational severity

The event log was using a severity of Error, and because the PEL message
registry had a severity of Informational, phosphor-log-manager would
spit out a trace about how the severities mismatched every time the PEL
was created.

Change-Id: Ia7559a5c3cfdf6ad93277783bfd85cb639af25a0
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I29672cb229bd07022b00f52105ac1d50ecacca62

show more ...

Revert "PHAL: Additional callout support during sbe chipop timeout"

This reverts commit c3119d8e6b2ad3cb04b14fffedc0f73831d5300c.

Added support in PEL message registry to make the callout common.

Revert "PHAL: Additional callout support during sbe chipop timeout"

This reverts commit c3119d8e6b2ad3cb04b14fffedc0f73831d5300c.

Added support in PEL message registry to make the callout common.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I3fb2dfcbe956b798646388d62e930e1b87a34c73

show more ...

PHAL: Additional callout support during sbe chipop timeout

Sbe chip-op timeout case BMC should run sbe_extract_rc
procedure to identify the correct callout and service
action. Currently this procedu

PHAL: Additional callout support during sbe chipop timeout

Sbe chip-op timeout case BMC should run sbe_extract_rc
procedure to identify the correct callout and service
action. Currently this procedure based callout handling
is not place. Adding callout recommended by RAS team till
the actual callout code in place.

Tested:
"Callout Count": "2",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Mandatory, replace all with this type as a unit",
"Procedure": "BMC0002"
}, {
"FRU Type": "Normal Hardware FRU",
"Priority": "Medium Priority",
"Location Code": "xxx", --> processor callout
"Part Number": "xxx",
"CCIN": "xxx",
"Serial Number": "xxx"

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I13a16f314fe3a5e9eaeb3f84fdaa5bfe1924c7c4

show more ...

PHAL: Log Informational error for PEL created during poweroff

1)Log informational PELS in case system state is transitioning to
power-off for IPL procedures/hardware access failures

2) Don't add ca

PHAL: Log Informational error for PEL created during poweroff

1)Log informational PELS in case system state is transitioning to
power-off for IPL procedures/hardware access failures

2) Don't add callouts to PEL's created during transition to
power-off as the CEC will not be in expected state.

Tested: transition to poweroff
root@xxxbmc:/usr# peltool -lfh
{
"0x50003BEB": {
"SRC": "BD503001",
"Message": "Failure occurred during boot process",
"PLID": "0x50003BEB",
"CreatorID": "BMC",
"Subsystem": "CEC Hardware",
"Commit Time": "05/23/2022 13:57:53",
"Sev": "Informational Event",
"CompID": "0x3000"
}
}

root@xxxbmc:~# peltool -i 0x50003be0
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x3000",
"Created at": "05/23/2022 13:48:12",
"Committed at": "05/23/2022 13:48:12",
"Creator Subsystem": "BMC",
"CSSVER": "",
"Platform Log Id": "0x50003BE0",
"Entry Id": "0x50003BE0",
"BMC Event Log Id": "510"
},
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "0x2000",
"Subsystem": "CEC Hardware",
"Event Scope": "Entire Platform",
"Event Severity": "Informational Event",
"Event Type": "Miscellaneous, Informational Only",
"Action Flags": [
"Event not customer viewable",
"Report Externally"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Not Sent"
},

.
.
.
Tested: transition to running
root@ever8bmc:/tmp# peltool -i 0x50003CF9
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x3000",
},
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "0x2000",
"Subsystem": "CEC Hardware",
"Event Scope": "Entire Platform",
"Event Severity": "Unrecoverable Error",
},

"User Data 0": {
"Created by": "0x2000",
"BMCState": "Ready",
"BootState": "Unspecified",
"ChassisState": "On",
"FW Version ID": "fw1020.00-57.7-2-gd86188a773",
"HostState": "TransitioningToRunning",
"Process Name": "/usr/bin/openpower-proc-control",
"System IM": "50003000"
},

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I078d5cba2e0fb705bf424d2f8f3010f2cd2063bb

show more ...

PHAL: Additional callout support for sbe timeout error

Sbe Boot timeout or chip-op timeout case BMC should run
sbe_extract_rc procedure to identify the correct callout
and service action. Currently

PHAL: Additional callout support for sbe timeout error

Sbe Boot timeout or chip-op timeout case BMC should run
sbe_extract_rc procedure to identify the correct callout
and service action. Currently this procedure based callout
handling is not place. Adding callout recommended by RAS
team till the actual callout code in place.

Tested:

"Callout Count": "2",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Mandatory, replace all with this type as a unit",
"Procedure": "BMC0002"
}, {
"FRU Type": "Normal Hardware FRU",
"Priority": "Medium Priority",
"Location Code": "xxx", --> processor callout
"Part Number": "xxx",
"CCIN": "xxx",
"Serial Number": "xxx"

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I40444eb5da1a5f329b09dea1bce15e1bab53e1d8

show more ...

PHAL: Modify sbe error pel interface to pass in error type

At present all sbe related pels are created with severity
as Error(unrecoverable), modifying the API to specify the
severity type by the ca

PHAL: Modify sbe error pel interface to pass in error type

At present all sbe related pels are created with severity
as Error(unrecoverable), modifying the API to specify the
severity type by the caller.

Some of the chip-op is expected to fail in power-off/error path.
This commit will help to set custom priority of the failure.

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: If072061bf995b2db58259eba64e7e8f7ace20f6c

show more ...

PHAL: added createErrorPEL wrapper function

Refactored createBootErrorPEL to support callout and
additional data information as optional parameter to
support diffrent types of PEL creation.

Also re

PHAL: added createErrorPEL wrapper function

Refactored createBootErrorPEL to support callout and
additional data information as optional parameter to
support diffrent types of PEL creation.

Also renamed createBootErrorPEL -> createErrorPEL.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Iee6e356740179caf6486a2750cf30278240a5785

show more ...

PHAL: createSbePEL API updates

Dump D-bus API requires PLID information to create SBE dump.
Updated createSbePEL API to return PLID information for same.
Replaced PEL CreateWithFFDCFiles api with Cr

PHAL: createSbePEL API updates

Dump D-bus API requires PLID information to create SBE dump.
Updated createSbePEL API to return PLID information for same.
Replaced PEL CreateWithFFDCFiles api with CreatePELWithFFDCFiles
to get PEL id.

Tested: verified manually.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I38984e63029ae236b05744c81726296d2da17149

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia8f2ae95679f98f2fc3f32239bbf3b3578c35888

PHAL: added createSbePEL wrapper function

Added wrapper function to create SBE PEL based on event type
and user provided additional SBE provided FFDC information

Refer phosphor-logging/extensions/o

PHAL: added createSbePEL wrapper function

Added wrapper function to create SBE PEL based on event type
and user provided additional SBE provided FFDC information

Refer phosphor-logging/extensions/openpower-pels/README.md section
"Self Boot Engine(SBE) First Failure Data Capture(FFDC) Support"
for details on this implementation.

Tested: verified PEL log

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Ice41e224d92a773090d601d3154b4c30bdd09c02

show more ...

PHAL:createPEL function signature update

Extended createPEL function to support optional additional data.
This is to support new requirement for creating PEL with additional data.

Tested: verified

PHAL:createPEL function signature update

Extended createPEL function to support optional additional data.
This is to support new requirement for creating PEL with additional data.

Tested: verified the PEL log.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I02f8eea29e40ca65dbdd1631ba0027fbb75a6080

show more ...

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I013d8a225f7a15601a5defa487d7030daad77270

show more ...

PHAL: added createPEL wrapper function

Added wrapper function to create PEL based on event type.

Why: concurrent code update feature requires to create to
PEL, based on event types in various use

PHAL: added createPEL wrapper function

Added wrapper function to create PEL based on event type.

Why: concurrent code update feature requires to create to
PEL, based on event types in various use cases. This will
help to reduce duplicate code.

Tested: verified PEL log

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I21d46775994f5c2f86124e33bf98dd9044f3e5d8

show more ...

phal: Added extensions/phal folder

Added phal specific folder to keep all phal feature
based function in common place

Moved phal error specific source files to extensions/phal

Tested: build verif

phal: Added extensions/phal folder

Added phal specific folder to keep all phal feature
based function in common place

Moved phal error specific source files to extensions/phal

Tested: build verified.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Iabae2689444f355008802950a293e7c69cb19553

show more ...