clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Id6c141dd4eba2423f476499b999aec9cb42f6192
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I4530f5b9df4f5898e26a2eef7efcf82e9728197f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If9a7314dade153dd7dbd149a76352aca8257839d

show more ...

openssl: stop using deprecated SHA512_* functions

The openssl/sha.h header is deprecated for OpenSSL 3 along with all the
functions in it. Switch to use the EVP_MD interfaces.

Tested: CI passes.

openssl: stop using deprecated SHA512_* functions

The openssl/sha.h header is deprecated for OpenSSL 3 along with all the
functions in it. Switch to use the EVP_MD interfaces.

Tested: CI passes.

Change-Id: Icd7a83683e7b9778343b8e14bfcdeb31b9d5144a
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

style: update clang-format

Pull the most recent OpenBMC style rules and run clang-format.

Change-Id: Ifecce87b6aa64a2800dab3ba1e09ae415accb548
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.co

style: update clang-format

Pull the most recent OpenBMC style rules and run clang-format.

Change-Id: Ifecce87b6aa64a2800dab3ba1e09ae415accb548
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4caefe2492f88886ed485204fc347b71efa4bc5e

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I62deb24e0fc9784289124cc0fc8a6db2de5d6b98

Static layout: Do not crash on empty PNOR

When PNOR is empty, or corrupted and it fails to retrieve the version,
the service throws an exception.
This is not good because it should run on a corrupte

Static layout: Do not crash on empty PNOR

When PNOR is empty, or corrupted and it fails to retrieve the version,
the service throws an exception.
This is not good because it should run on a corrupted or empty PNOR,
which then could be used to re-program the PNOR.

This commit fixes the issue, by not throwing on the above case.

Tested: Verify the service does not crash on a corrupted VERSION
partition, and could be used to do code update to fix the
corruption.

Change-Id: Ic6a413a81ad13894a9c7f039df71fff9b9d4b2ad
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Static layout: Read PNOR VERSION using pflash

Use pflash to read VERSION partition to get the PNOR version
Add code to parse pflash's VERSION partition string.

Tested: Verify that the version and e

Static layout: Read PNOR VERSION using pflash

Use pflash to read VERSION partition to get the PNOR version
Add code to parse pflash's VERSION partition string.

Tested: Verify that the version and extended version are
retrieved correctly on Romulus and Palmetto.

Change-Id: Ia053c1683a5a969be0773d251cb88c4c5c9b6c60
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Fix std::variant usage

Use the std::get() interface instead of mapbox specific .get() member
interface.

Change-Id: I4ce467c49ea418adba422bbd09fa829acd53da3c
Signed-off-by: William A. Kennington III

Fix std::variant usage

Use the std::get() interface instead of mapbox specific .get() member
interface.

Change-Id: I4ce467c49ea418adba422bbd09fa829acd53da3c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clang-format: Update to match docs repo

Update the .clang-format file.
Now includes header sorting and updating PointerAlignment.

Change-Id: I7119c12f1cc0a461cb7e4576dff6a02dcc95cbc4
Signed-off-by:

clang-format: Update to match docs repo

Update the .clang-format file.
Now includes header sorting and updating PointerAlignment.

Change-Id: I7119c12f1cc0a461cb7e4576dff6a02dcc95cbc4
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

version: Check Chassis changed for Delete intf

The chassis path contains multiple properties. The code checks for
chassis state to decide if the Delete interface is added or removed.
If a different

version: Check Chassis changed for Delete intf

The chassis path contains multiple properties. The code checks for
chassis state to decide if the Delete interface is added or removed.
If a different property was modified, the chassis state would be
empty, leading to always removing the Delete interface in this
scenario. Check that chassis state was populated before modifying the
Delete interface.

Tested: Verified the Delete interface was added back during power off.

Change-Id: Iee32de8917930e2f9081ab369ad4998766f21cff
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Enable clang code format

Change-Id: I4490e930459a7eab6f6dd15198418c5314755d3f
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

PNOR: Fix the delete implementation

- In order to remove the delete object from functional
image, the delete interface is moved inside the
version class so that both item_updater and image_manag

PNOR: Fix the delete implementation

- In order to remove the delete object from functional
image, the delete interface is moved inside the
version class so that both item_updater and image_manager
can make use of the same implementation.
- To avoid having two delete objects attached to the same
HOST version (item_updater and image_manager), we are now
deleting the image_manager object once the activation
is complete.

Partially resolves openbmc/openbmc#2490

Change-Id: Ie515cc01d5f154e6e55b9a3fb71d831730cd46f6
Signed-off-by: Saqib Khan <khansa@us.ibm.com>

show more ...

remove Delete from Version

- Since the Activation object inherits Delete and implements a Delete
method, we don't need to do so for the Version object.

Change-Id: I1da26c3475872c1324a25b92ad8891ff8

remove Delete from Version

- Since the Activation object inherits Delete and implements a Delete
method, we don't need to do so for the Version object.

Change-Id: I1da26c3475872c1324a25b92ad8891ff8d3cabbc
Signed-off-by: Eddie James <eajames@us.ibm.com>

show more ...

Use sha512 to calcualte the versionID for images.

- We needed a hash algorithm that can be replicated on
multiple platforms and across multiple programming languages.
- This would allow the user t

Use sha512 to calcualte the versionID for images.

- We needed a hash algorithm that can be replicated on
multiple platforms and across multiple programming languages.
- This would allow the user to calculate the versionID by
executing the following command to obtain correct versionID.
echo -n "<versionID>" | sha512sum | cut -b 1-8
- This is part of the change required for openbmc/openbmc#2323

Change-Id: I799a9a2b83fdf35beaf61b9df5ed69162f610d2f
Signed-off-by: Saqib Khan <khansa@us.ibm.com>

show more ...

Style changes in version.cpp

Style only changes

Change-Id: I0eb3dedf400a734619bc0419c7c8bd398d912b03
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Fix error logs while trying to read MANIFEST.

After all lines have been read "while (getline(efile, line))"
will still try and read another line and returns an exception.
Checking the eof(end of fil

Fix error logs while trying to read MANIFEST.

After all lines have been read "while (getline(efile, line))"
will still try and read another line and returns an exception.
Checking the eof(end of file) bit confirms this and is not a
valid error.

This is part of a fix for openbmc/openbmc#2174

Change-Id: I0254b7f029a6343dae03d2fbc639f74c51d05d99
Signed-off-by: Saqib Khan <khansa@us.ibm.com>

show more ...

item_updater : Implementing Object.Delete for version

Change-Id: If962dec1da2d2fe925374bb37f89ed23f04c5ab6
Signed-off-by: Leonel Gonzalez <lgonzalez@us.ibm.com>

Create Version and Activation objects for current PNOR image

On BMC boot, create the Software version and activation that
points to the current PNOR version by reading:
/var/lib/phosphor-software-ma

Create Version and Activation objects for current PNOR image

On BMC boot, create the Software version and activation that
points to the current PNOR version by reading:
/var/lib/phosphor-software-manager/pnor/ro

Resolves openbmc/openbmc#1762

Change-Id: I46ddb37491a1a230699da9f3acbd3fcff23dc538
Signed-off-by: Saqib Khan <khansa@us.ibm.com>

show more ...