beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: I82c8272c4

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: I82c8272c4838e848615995a864dff3301d53925f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Ensure No Unnecessary Errors During Code Update

This commit fixes the problem of partitions that have
either been deleted or had their name changed. The partitions
are only preserved if they exist i

Ensure No Unnecessary Errors During Code Update

This commit fixes the problem of partitions that have
either been deleted or had their name changed. The partitions
are only preserved if they exist in both the running and
read only directories, otherwise, they are skipped and the
error is not triggered.

Tested:
Performed code update and verified that there were no errors
called.

Signed-off-by: Zami Seck <zimzam17@gmail.com>
Change-Id: I11288c4120247b443d4ddd61db34f723abf041c1

show more ...

Preserved Partition Change

This commit fixes the problem of corrupted or changed preserved
partitions. If one of the partitions becomes corrupted, or it
the size of the partition needs to be changes

Preserved Partition Change

This commit fixes the problem of corrupted or changed preserved
partitions. If one of the partitions becomes corrupted, or it
the size of the partition needs to be changes, these changes will
allow for the copying of the old partition, forcing the new one
to take its place.

Tested:
When a PRESERVED partition is altered (corrupted or contents
deleted) ensured that the contents was not copied into the
prsv directory and the working partition appeared upon
reboot.

Signed-off-by: Zami Seck <zimzam17@gmail.com>
Change-Id: I473bdef12dd14913c385ccd43693ad7176567313

show more ...

mmc: Add nvram hostfw directory

Created an nvram directory to store the hypervisor's NVRAM files.
Create a symlink to that directory for apps like PLDM to access it.
Add a dependency to the symlink

mmc: Add nvram hostfw directory

Created an nvram directory to store the hypervisor's NVRAM files.
Create a symlink to that directory for apps like PLDM to access it.
Add a dependency to the symlink service to start before the PLDM
services that would make use of the new NVRAM directory start.

Tested: Verified the directory and symlink got created. Verified the
PLDM services started after the symlink one.

Change-Id: I8cdef7cc2176ed10096712918a743efd304df6c1
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

openpower: mmc: physical reset triggers bios reset

The service openpower-bios-factory-reset runs during startup and
calls bios_reset_check. This method determines whether the
factory-reset-toggle gp

openpower: mmc: physical reset triggers bios reset

The service openpower-bios-factory-reset runs during startup and
calls bios_reset_check. This method determines whether the
factory-reset-toggle gpio has changed since the last reboot and
triggers a bios reset if it has. This decouples the code to check
for bios resets from the code in item_updater_mmc::reset and from
the BMC factory reset code.

Tested: Verified that the reset-gpio-val file was created to store
the previous value of the environment variable rwreset. Added files
to /media/hostfw and verified that they were removed upon reboot
when the value in reset-gpio-val differed from rwreset.

Signed-off-by: Isaac Kurth <isaac.kurth@ibm.com>
Change-Id: I9942c1826f800a2ce9aef4b9456b3f4acc4b94fe

show more ...

mmc: Handle missing pnor.toc file

The pnor.toc file is a mboxd implemenation, and therefore will not exist
once the host uses PLDM instead, which uses .lid files instead of pnor
partition files. As

mmc: Handle missing pnor.toc file

The pnor.toc file is a mboxd implemenation, and therefore will not exist
once the host uses PLDM instead, which uses .lid files instead of pnor
partition files. As part of the transition, the pnor.toc file is being
built into a .lid file for images that do not contain pnor partition
files. Handle this transition by creating a symlink from pnor partition
file to .lid file. This would remain in place until all the PLDM support
from the hostboot side is in place and mboxd is removed.

Tested: Verified rainier powers on and mboxd starts successfully, and
the volatile partition gets cleared.

Change-Id: I59364c0abf100dab5a38d277f0587d0dd221b53d
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

mmc: Copy only LID files during update

This is one step closer in replacing the PNOR partition files with LID
files:
- During an update, only copy LID files to the read-write directory. The
update

mmc: Copy only LID files during update

This is one step closer in replacing the PNOR partition files with LID
files:
- During an update, only copy LID files to the read-write directory. The
update-bios-attr-table service will create symlinks from PNOR
partition files to LID files.
- Use the pnor.toc from the read-only directory to get the list of
preserved partitions, since there won't be a pnor.toc file in the
read-write directory anymore. A future commit will read the PLDM file
table to determine which LID files to preserve.
- Preserve the symlink target (LID file) instead of the symlink name
(partition file name), otherwise the symlink gets broken if we copy a
file that was a symlink.

Tested: Verified after code update that all the partition files were
symlinks to a LID file, and a subsequent update preserved the LID files
that correspond to the preserved partitions.

Change-Id: I3fbe3de5a910d85c299ed7e5a535198283bd3f9a

show more ...

item_updater_mmc: Implement bios factory reset

Implemented the method ItemUpdaterMMC::reset. It clears files in
/media/hostfw/ related to managing console and virtualization
information, then recrea

item_updater_mmc: Implement bios factory reset

Implemented the method ItemUpdaterMMC::reset. It clears files in
/media/hostfw/ related to managing console and virtualization
information, then recreates those files using bus calls to service
files. Added checks to obmc-flash-bios so it doesn't cause problems
when its methods are run multiple times. Modified latest services to
allow them to run more than once. Services which depend on the init
service will run after it.

Tested: Created extra files in the directories that the reset method
removes. Called the reset method using busctl. Verified that the
added files were removed and that the removed files that belong were
recreated. Verified that all services called were run.

Signed-off-by: Isaac Kurth <blisaac91@gmail.com>
Change-Id: I1e04e97a7c5c9e3fa8b5ee7af47b7320ff3e91d3

show more ...

mmc: Move process host firmware to own service

The process-host-firmware subcommand waits for the Entity Manager
interface to appear in D-Bus. It's currently run from the mmc-init
script. But if a s

mmc: Move process host firmware to own service

The process-host-firmware subcommand waits for the Entity Manager
interface to appear in D-Bus. It's currently run from the mmc-init
script. But if a system does not support Entity Manager, then the init
service never exits, blocking its dependencies like PLDM from starting.

Move the process-host-firmware to its own service file so that if needs
to wait forever, it doesn't interfere with other processes. Need to
start it after the mmc-init so that all the directories are setup before
the symlinks are created.

Tested: Verified on tacoma that the service remains running and PLDM
starts successfully. Verified on rainier that the symlinks are created.

Change-Id: Ia746362e5ff688b972e9b92e9d78f3f5b3623a99
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

mmc/obmc-flash-bios: fix shellcheck warnings

Tested: Verified code update was successful on Tacoma.

Change-Id: Ieb87080f91e7d591f3dad1475d73bcbb920d799f
Signed-off-by: Adriana Kobylak <anoo@us.ibm.

mmc/obmc-flash-bios: fix shellcheck warnings

Tested: Verified code update was successful on Tacoma.

Change-Id: Ieb87080f91e7d591f3dad1475d73bcbb920d799f
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

mmc: process host firmware blob files

Invoke the new process-host-firmware subcommand when performing emmc
setup.

Change-Id: I47cf1e4b7139027b22623633caa05081af4ca2a8
Signed-off-by: Brad Bishop <br

mmc: process host firmware blob files

Invoke the new process-host-firmware subcommand when performing emmc
setup.

Change-Id: I47cf1e4b7139027b22623633caa05081af4ca2a8
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

mmc: Add staging directory

Add a staging directory for PLDM to use as a temporary
holding space during inband update where the host would
send individual image files and PLDM needs to reconstruct
th

mmc: Add staging directory

Add a staging directory for PLDM to use as a temporary
holding space during inband update where the host would
send individual image files and PLDM needs to reconstruct
the code update tarball before calling the BMC updater
to do an update.

Clear the directory after a successful update. This cleanup
will eventually be handled by PLDM.

Tested: New directory and symlink created.

Change-Id: I9a2eacb0f57696e799e983625c2a32efbe122e89
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

mmc: Support a patch directory for each version

Create a patch directory for the running and alternate hostfw
versions. Otherwise the patches may not be compatible if a
side switch occurs.

Also don

mmc: Support a patch directory for each version

Create a patch directory for the running and alternate hostfw
versions. Otherwise the patches may not be compatible if a
side switch occurs.

Also don't delete patches when updating the running version
because it's not known if it's just a side switch. This should
be handled by the code update app which currently is done by
the BMC updater.

Change-Id: Ie975e5f8176ad97ee5ed2dd7594a83ba8c57bdb3
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

mmc: Add read-only directory to support mboxd

The mboxd implementation assumes that there is a read-only and
read-write directory. During a write request, mboxd copies the
contents of the read-only

mmc: Add read-only directory to support mboxd

The mboxd implementation assumes that there is a read-only and
read-write directory. During a write request, mboxd copies the
contents of the read-only to the read-write directory. To continue
to support mboxd, mount a read-only directory of the hostfw image
for mboxd to use. Otherwise the write command fails (can't copy
the file to itself) and mboxd exits.

Tested: Verified mboxd didn't fail and system powered on.

Change-Id: Idcb8ff0c5eee0179d5d70e60e5e01c7d0f76b880
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

mmc: Setup hostfw directories

The BMC updater will take care of writing the new hostfw image
to flash since it's delivered in the single tarball file, but
when the BMC starts up, need to setup the d

mmc: Setup hostfw directories

The BMC updater will take care of writing the new hostfw image
to flash since it's delivered in the single tarball file, but
when the BMC starts up, need to setup the directories so that
the contents of the host FW are visible to consumers like pldm.

The first service is to setup the patch directory. This is
similar to UBI. The path that mboxd expects (pnor) will point to
a directory in the hostfw partition. Then create a similar
symlink (hostfw) for pldm to use. Eventually pldm will replace
mboxd.

The second service is an init setup. We need to make the 2 hostfw
versions visible. The secondary (non-running) will just be a
read-only mount of the non-running image. The primary (running)
version needs to be read-write. The mboxd code currently
handles 3 directories: ro, rw, prsv. This was deemed too complex
for pldm to replicate, so it was decided to have a single rw
directory, then pldm would determine if it allowed a write or not.
To handle the preserved files (that are not updated on an update),
need to copy them off to a tmp space, then set up the primary
directory with the contents of the running image, then restore the
preserved files. Currently only the PNOR contents are preserved,
at a later point the pldm files will be preserved and a different
list like the pnor.toc file will be added.

Finally, like the vpnor util does, if the version has changed on,
remove the patch files. Just that we need to do this when the init
service starts because the symlinks will not change at runtime
(the host fw version is tied to the bmc version).

Change-Id: I32b456bd363671404f573cb941a0f2f374a3eab2
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...