History log of /openbmc/openpower-pnor-code-mgmt/mmc/item_updater_mmc.hpp (Results 1 – 6 of 6)
Revision Date Author Comments
# 01f71428 07-Feb-2025 Adriana Kobylak <anoo@us.ibm.com>

mmc: clang-tidy: Add override keyword

Marked virtual functions with the `override` keyword to ensure
they correctly override base class functions. This resolves
-Winconsistent-missing-override warni

mmc: clang-tidy: Add override keyword

Marked virtual functions with the `override` keyword to ensure
they correctly override base class functions. This resolves
-Winconsistent-missing-override warnings and improves code safety
and readability by explicitly indicating overridden functions.

```
Error while processing /var/jenkins-openbmc/workspace/ci-repository/openbmc/openpower-pnor-code-mgmt/mmc/item_updater_mmc.hpp.
/var/jenkins-openbmc/workspace/ci-repository/openbmc/openpower-pnor-code-mgmt/mmc/item_updater_mmc.hpp:94:10: error: 'validateImage' overrides a member function but is not marked 'override' [clang-diagnostic-inconsistent-missing-override]
94 | bool validateImage(const std::string& path);
| ^
../item_updater.hpp:199:18: note: overridden virtual function is here
199 | virtual bool validateImage(const std::string& path) = 0;
| ^
```

Tested: CI runs with no errors.

Change-Id: I24e5cae09e2cdeacf0155d5de70a6ecbae5e00e0
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...


# f8e02429 16-Aug-2024 Patrick Williams <patrick@stwcx.xyz>

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Id6c141dd4eba2423f476499b999aec9cb42f6192
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...


# 96442c88 16-Jun-2024 Manojkiran Eda <manojkiran.eda@gmail.com>

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I014e7670ca4ba57f7e1b80e96c001474cf7a6676
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...


# 2b31497e 01-Jul-2022 Marri Devender Rao <devenrao@in.ibm.com>

Guard: Guarded DIMMS/CPU are not enabled back after factory reset

User not able to enable some of the guarded dimm/cpu after host
factory reset even though host cleared the guards in the guard
parti

Guard: Guarded DIMMS/CPU are not enabled back after factory reset

User not able to enable some of the guarded dimm/cpu after host
factory reset even though host cleared the guards in the guard
partition.

BMC will not know that host took a factory reset for it to clear the
disabled flag for the earlier guarded dimm/cpu.

Modified to force enable all the cpu/dimm during host factory reset.
Test result:
openpower-update-manager[2001]:ItemUpdaterMMC::reset
openpower-update-manager[2001]:GardResetMMC::reset
openpower-update-manager[2001]:GardResetMMC::enableInventoryItems
openpower-update-manager[2001]:GardResetMMC::enableInventoryItemsHelper
openpower-update-manager[2001]:enable specified inventory items
OBJ(/xyz/openbmc_project/inventory/system/chassis/motherboard/dcm0/cpu0/core13)
openpower-update-manager[2001]:enable specified inventory items
OBJ(/xyz/openbmc_project/inventory/system/chassis/motherboard/dcm0/cpu0/core14)
openpower-update-manager[2001]:GardResetMMC::enableInventoryItemsHelper
openpower-update-manager[2001]:enable specified inventory items
OBJ(/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0)

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>`
Change-Id: I7f7d3981d38cdc6cc7dda4e3ee49403c772dc5ef

show more ...


# 0dea1992 22-Jul-2022 Patrick Williams <patrick@stwcx.xyz>

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If9a7314dade153dd7dbd149a76352aca8257839d

show more ...


# 8bc2ab4e 15-Jul-2020 Adriana Kobylak <anoo@us.ibm.com>

Add MMC layout

Add support for eMMC layout. The actual update of the image will
be handled by the BMC updater since the image file will be
packaged in a single tarball, but the eMMC still needs to h

Add MMC layout

Add support for eMMC layout. The actual update of the image will
be handled by the BMC updater since the image file will be
packaged in a single tarball, but the eMMC still needs to have
some services to setup the host firmware mounts for the virtual
pnor configuration to use. Therefore the functions are empty.

Change-Id: Iaa052342a2bb66e46ab7b59bdcd5631f3dfc2999
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...